Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1335162 > unrolled thread

[PATCH 1/2] PM / OPP: Fix incorrect comments

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] PM / OPP: Fix incorrect comments Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-16 09:50 +0100
    Re: [PATCH 1/2] PM / OPP: Fix incorrect comments "Rafael J. Wysocki" <rafael@kernel.org> - 2016-02-18 21:00 +0100
    Re: [PATCH 1/2] PM / OPP: Fix incorrect comments Stephen Boyd <sboyd@codeaurora.org> - 2016-02-18 23:10 +0100
    Re: [PATCH 2/2] PM / OPP: Rename structures for clarity Stephen Boyd <sboyd@codeaurora.org> - 2016-02-18 23:10 +0100

#1335162 — [PATCH 1/2] PM / OPP: Fix incorrect comments

Some comments were just copy/pasted from other sections and don't match
to the routines they were added for. Fix them.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/base/power/opp/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/base/power/opp/core.c b/drivers/base/power/opp/core.c
index 5fb2f061129e..bdae09c1d8eb 100644
--- a/drivers/base/power/opp/core.c
+++ b/drivers/base/power/opp/core.c
@@ -1254,7 +1254,7 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_set_supported_hw);
 
 /**
  * dev_pm_opp_put_supported_hw() - Releases resources blocked for supported hw
- * @dev: Device for which supported-hw has to be set.
+ * @dev: Device for which supported-hw has to be put.
  *
  * This is required only for the V2 bindings, and is called for a matching
  * dev_pm_opp_set_supported_hw(). Until this is called, the device_opp structure
@@ -1303,7 +1303,7 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_put_supported_hw);
 
 /**
  * dev_pm_opp_set_prop_name() - Set prop-extn name
- * @dev: Device for which the regulator has to be set.
+ * @dev: Device for which the prop-name has to be set.
  * @name: name to postfix to properties.
  *
  * This is required only for the V2 bindings, and it enables a platform to
@@ -1362,7 +1362,7 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_set_prop_name);
 
 /**
  * dev_pm_opp_put_prop_name() - Releases resources blocked for prop-name
- * @dev: Device for which the regulator has to be set.
+ * @dev: Device for which the prop-name has to be put.
  *
  * This is required only for the V2 bindings, and is called for a matching
  * dev_pm_opp_set_prop_name(). Until this is called, the device_opp structure
-- 
2.7.1.410.g6faf27b

[toc] | [next] | [standalone]

#1337647

On Tue, Feb 16, 2016 at 9:47 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> Some comments were just copy/pasted from other sections and don't match
> to the routines they were added for. Fix them.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

I'm queuing up this and the [2/2] for 4.6.

Thanks,
Rafael

[toc] | [prev] | [next] | [standalone]

#1337750

On 02/16, Viresh Kumar wrote:
> Some comments were just copy/pasted from other sections and don't match
> to the routines they were added for. Fix them.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [next] | [standalone]

#1337751 — Re: [PATCH 2/2] PM / OPP: Rename structures for clarity

On 02/16, Viresh Kumar wrote:
> Stephen pointed out recently, that few structures always confuse him as
> they aren't named properly. And this patch tries to address that:
> 
> Names are updated as:
> - device_opp or dev_opp -> opp_table
> - dev_opp_list -> opp_tables
> - dev_opp_list_lock -> opp_table_lock
> - device_list_opp -> opp_device (it was never a list, but a structure)
> - list_dev -> opp_dev
> - And similar changes in comments and function names as well.
> 
> This also fixes checkpatch warnings that were generated with this patch.
> 
> No functional changes.
> 
> Suggested-by: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web