Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1336537 > unrolled thread

[PATCH] appletalk: fix erroneous return value

Started byAnton Protopopov <a.s.protopopov@gmail.com>
First post2016-02-17 17:00 +0100
Last post2016-02-18 21:10 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] appletalk: fix erroneous return value Anton Protopopov <a.s.protopopov@gmail.com> - 2016-02-17 17:00 +0100
    Re: [PATCH] appletalk: fix erroneous return value David Miller <davem@davemloft.net> - 2016-02-18 21:10 +0100

#1336537 — [PATCH] appletalk: fix erroneous return value

FromAnton Protopopov <a.s.protopopov@gmail.com>
Date2016-02-17 17:00 +0100
Subject[PATCH] appletalk: fix erroneous return value
Message-ID<r3cGf-8sZ-5@gated-at.bofh.it>
The atalk_sendmsg() function might return wrong value ENETUNREACH
instead of -ENETUNREACH.

Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
---
 net/appletalk/ddp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index d5871ac..f066781 100644
--- a/net/appletalk/ddp.c
+++ b/net/appletalk/ddp.c
@@ -1625,7 +1625,7 @@ static int atalk_sendmsg(struct socket *sock, struct msghdr *msg, size_t len)
 
 		rt = atrtr_find(&at_hint);
 	}
-	err = ENETUNREACH;
+	err = -ENETUNREACH;
 	if (!rt)
 		goto out;
 
-- 
2.6.5

[toc] | [next] | [standalone]


#1337652

FromDavid Miller <davem@davemloft.net>
Date2016-02-18 21:10 +0100
Message-ID<r3D3I-2sr-9@gated-at.bofh.it>
In reply to#1336537
From: Anton Protopopov <a.s.protopopov@gmail.com>
Date: Wed, 17 Feb 2016 10:53:59 -0500

> The atalk_sendmsg() function might return wrong value ENETUNREACH
> instead of -ENETUNREACH.
> 
> Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>

Applied.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web