Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1336084 > unrolled thread

[PATCH 2/2] drm/panel: Add support for LG lp120up1 panel

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 2/2] drm/panel: Add support for LG lp120up1 panel Jitao Shi <jitao.shi@mediatek.com> - 2016-02-17 08:00 +0100
    Re: [PATCH 2/2] drm/panel: Add support for LG lp120up1 panel Thierry Reding <treding@nvidia.com> - 2016-02-18 16:20 +0100
      Re: [PATCH 2/2] drm/panel: Add support for LG lp120up1 panel Jitao Shi <jitao.shi@mediatek.com> - 2016-02-22 03:20 +0100

#1336084 — [PATCH 2/2] drm/panel: Add support for LG lp120up1 panel

The LG lp120up1 panel is a 12.0" 1920x1280 panel,
which can be supported by the simple panel driver

Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
---
 drivers/gpu/drm/panel/panel-simple.c |   26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index f88a631..2030c37 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -982,6 +982,29 @@ static const struct panel_desc lg_lb070wv8 = {
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
 };
 
+static const struct drm_display_mode lg_lp120up1_mode = {
+	.clock = 162300,
+	.hdisplay = 1920,
+	.hsync_start = 1920 + 40,
+	.hsync_end = 1920 + 40 + 40,
+	.htotal = 1920 + 40 + 40+ 80,
+	.vdisplay = 1280,
+	.vsync_start = 1280 + 4,
+	.vsync_end = 1280 + 4 + 4,
+	.vtotal = 1280 + 4 + 4 + 12,
+	.vrefresh = 60,
+};
+
+static const struct panel_desc lg_lp120up1 = {
+	.modes = &lg_lp120up1_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 267,
+		.height = 183,
+	},
+};
+
 static const struct drm_display_mode lg_lp129qe_mode = {
 	.clock = 285250,
 	.hdisplay = 2560,
@@ -1256,6 +1279,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "lg,lb070wv8",
 		.data = &lg_lb070wv8,
 	}, {
+		.compatible = "lg,lp120up1",
+		.data = &lg_lp120up1,
+	}, {
 		.compatible = "lg,lp129qe",
 		.data = &lg_lp129qe,
 	}, {
-- 
1.7.9.5

[toc] | [next] | [standalone]

#1337451

[Multipart message — attachments visible in raw view] — view raw

On Wed, Feb 17, 2016 at 02:50:39PM +0800, Jitao Shi wrote:
> The LG lp120up1 panel is a 12.0" 1920x1280 panel,
> which can be supported by the simple panel driver

It'd be nice to mention the type of interface of the panel here. While
at it, please rewrite the commit message to make use of what width you
have (i.e. any line after the subject can be 72 characters wide).

Thierry

[toc] | [prev] | [next] | [standalone]

#1339068

On Thu, 2016-02-18 at 16:12 +0100, Thierry Reding wrote:
> On Wed, Feb 17, 2016 at 02:50:39PM +0800, Jitao Shi wrote:
> > The LG lp120up1 panel is a 12.0" 1920x1280 panel,
> > which can be supported by the simple panel driver
> 
> It'd be nice to mention the type of interface of the panel here. While
> at it, please rewrite the commit message to make use of what width you
> have (i.e. any line after the subject can be 72 characters wide).
> 
> Thierry

Thanks for your review.
I'll fix it next patchset.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web