Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1333504 > unrolled thread
| Started by | Axel Lin <axel.lin@ingics.com> |
|---|---|
| First post | 2016-02-14 15:00 +0100 |
| Last post | 2016-02-18 03:20 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] irqchip/ts4800: Make ts4800_ic_ops static const Axel Lin <axel.lin@ingics.com> - 2016-02-14 15:00 +0100
Re: [PATCH] irqchip/ts4800: Make ts4800_ic_ops static const Damien Riegel <damien.riegel@savoirfairelinux.com> - 2016-02-15 20:30 +0100
Re: [PATCH] irqchip/ts4800: Make ts4800_ic_ops static const Jason Cooper <jason@lakedaemon.net> - 2016-02-18 03:20 +0100
| From | Axel Lin <axel.lin@ingics.com> |
|---|---|
| Date | 2016-02-14 15:00 +0100 |
| Subject | [PATCH] irqchip/ts4800: Make ts4800_ic_ops static const |
| Message-ID | <r25ns-3lH-1@gated-at.bofh.it> |
ts4800_ic_ops is only referenced in this driver, so make it static.
In additional, it's never get modified thus also make it const.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/irqchip/irq-ts4800.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-ts4800.c b/drivers/irqchip/irq-ts4800.c
index 4192bdc..2325fb3 100644
--- a/drivers/irqchip/irq-ts4800.c
+++ b/drivers/irqchip/irq-ts4800.c
@@ -59,7 +59,7 @@ static int ts4800_irqdomain_map(struct irq_domain *d, unsigned int irq,
return 0;
}
-struct irq_domain_ops ts4800_ic_ops = {
+static const struct irq_domain_ops ts4800_ic_ops = {
.map = ts4800_irqdomain_map,
.xlate = irq_domain_xlate_onecell,
};
--
2.1.4
[toc] | [next] | [standalone]
| From | Damien Riegel <damien.riegel@savoirfairelinux.com> |
|---|---|
| Date | 2016-02-15 20:30 +0100 |
| Message-ID | <r2x0m-5sb-17@gated-at.bofh.it> |
| In reply to | #1333504 |
On Sun, Feb 14, 2016 at 09:50:04PM +0800, Axel Lin wrote: > ts4800_ic_ops is only referenced in this driver, so make it static. > In additional, it's never get modified thus also make it const. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> Reviewed-by: Damien Riegel <damien.riegel@savoirfairelinux.com> Thanks for catching this.
[toc] | [prev] | [next] | [standalone]
| From | Jason Cooper <jason@lakedaemon.net> |
|---|---|
| Date | 2016-02-18 03:20 +0100 |
| Message-ID | <r3mmd-775-7@gated-at.bofh.it> |
| In reply to | #1333504 |
On Sun, Feb 14, 2016 at 09:50:04PM +0800, Axel Lin wrote: > ts4800_ic_ops is only referenced in this driver, so make it static. > In additional, it's never get modified thus also make it const. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > drivers/irqchip/irq-ts4800.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to irqchip/core with Damien's Reviewed-by. thx, Jason.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web