Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1334239 > unrolled thread

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware  SPI driver Hanjun Guo <guohanjun@huawei.com> - 2016-02-15 09:30 +0100
    Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for  Designware SPI driver Mark Brown <broonie@kernel.org> - 2016-02-15 18:50 +0100
      Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for  Designware SPI driver One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-02-15 19:10 +0100

#1334239 — Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

On 2016/2/5 19:09, Mark Brown wrote:
> On Fri, Feb 05, 2016 at 03:11:20PM +0800, qiujiang wrote:
>
>> This patch added ACPI support for DesignWare SPI mmio driver. It
>> was based the corresponding DT driver and compatible for this two
>> way. This patch has been tested on Hisilicon D02 board. It relies
>> on the GPIO patchset.
> Intel are heavy users of this driver on their systems which also use
> ACPI.  Have you discussed this binding with them?  I've copied Andy and
> Jarkko who've worked on the driver recently.

There is no ACPI code in this driver yet, seems "PRP0001" is used to reuse
this driver directly.

[...]
>
>> +static const struct acpi_device_id dw_spi_mmio_acpi_match[] = {
>> +		{"HISI0171", 0},
>> +		{ }
>> +};
>> +MODULE_DEVICE_TABLE(acpi, dw_spi_mmio_acpi_match);
> I really do wish ACPI had some more sensible system for allocating
> device IDs so the tables were a little more legible. :(

Hmm, I agree. but for now, every OEM can request ACPI or PNP ID with specific
prefixes, and they can manage it by themselves, that would flexible for OEM verdors
to develop firmware and driver.

For this driver in particular, if DesignWare provides the ACPI or PNP ID, that would
be great for all OEMs can reuse it.

Thanks
Hanjun

[toc] | [next] | [standalone]

#1334662 — Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

[Multipart message — attachments visible in raw view] — view raw

On Mon, Feb 15, 2016 at 04:27:51PM +0800, Hanjun Guo wrote:
> On 2016/2/5 19:09, Mark Brown wrote:

> > Intel are heavy users of this driver on their systems which also use
> > ACPI.  Have you discussed this binding with them?  I've copied Andy and
> > Jarkko who've worked on the driver recently.

> There is no ACPI code in this driver yet, seems "PRP0001" is used to reuse
> this driver directly.

No, on Intel systems the devices appear on the PCI bus.

[toc] | [prev] | [next] | [standalone]

#1334676 — Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

On Mon, 15 Feb 2016 17:45:40 +0000
Mark Brown <broonie@kernel.org> wrote:

> On Mon, Feb 15, 2016 at 04:27:51PM +0800, Hanjun Guo wrote:
> > On 2016/2/5 19:09, Mark Brown wrote:  
> 
> > > Intel are heavy users of this driver on their systems which also use
> > > ACPI.  Have you discussed this binding with them?  I've copied Andy and
> > > Jarkko who've worked on the driver recently.  
> 
> > There is no ACPI code in this driver yet, seems "PRP0001" is used to reuse
> > this driver directly.  
> 
> No, on Intel systems the devices appear on the PCI bus.

They may be ACPI or PCI enumerated - depends upon the system and
firmware. See drivers/acpi/acpi_lpss.c


Alan

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web