Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1334485 > unrolled thread

Re: [Xen-devel] [PATCH] Fixes to Xen pcifront and pciback (v1)

Started byDavid Vrabel <david.vrabel@citrix.com>
First post2016-02-15 15:40 +0100
Last post2016-02-15 15:40 +0100
Articles 2 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [Xen-devel] [PATCH] Fixes to Xen pcifront and pciback (v1) David Vrabel <david.vrabel@citrix.com> - 2016-02-15 15:40 +0100
    Re: [Xen-devel] [PATCH] Fixes to Xen pcifront and pciback (v1) David Vrabel <david.vrabel@citrix.com> - 2016-02-15 15:40 +0100

#1334485 — Re: [Xen-devel] [PATCH] Fixes to Xen pcifront and pciback (v1)

FromDavid Vrabel <david.vrabel@citrix.com>
Date2016-02-15 15:40 +0100
SubjectRe: [Xen-devel] [PATCH] Fixes to Xen pcifront and pciback (v1)
Message-ID<r2stH-2fA-1@gated-at.bofh.it>
On 11/02/16 21:10, Konrad Rzeszutek Wilk wrote:
> Hey,
> 
> These are patches that were developed for the Debian bug
> 810379 which san Tommi had openned.
> 
> The issue around from the two XSA fixes - which introduced
> this regression.

Applied to for-linus-4.6, thanks.

I rewrote some of the commit messages for clarity.  Please only put
relevant information in them and for regression fixes, make sure it's
clear what functionality regressed.

e.g. #1 now reads:

    Commit 408fb0e5aa7fda0059db282ff58c3b2a4278baa0 (xen/pciback: Don't
    allow MSI-X ops if PCI_COMMAND_MEMORY is not set) prevented enabling
    MSI-X on passed-through virtual functions, because it checked the VF
    for PCI_COMMAND_MEMORY but this is not a valid bit for VFs.

    Instead, check the physical function for PCI_COMMAND_MEMORY.

David

[toc] | [next] | [standalone]


#1334488

FromDavid Vrabel <david.vrabel@citrix.com>
Date2016-02-15 15:40 +0100
Message-ID<r2stH-2fA-11@gated-at.bofh.it>
In reply to#1334485
On 15/02/16 14:35, David Vrabel wrote:
> On 11/02/16 21:10, Konrad Rzeszutek Wilk wrote:
>> Hey,
>>
>> These are patches that were developed for the Debian bug
>> 810379 which san Tommi had openned.
>>
>> The issue around from the two XSA fixes - which introduced
>> this regression.
> 
> Applied to for-linus-4.6, thanks.

I mean for-linus-4.5.

I also fixed the minor style quibbles.

David

> I rewrote some of the commit messages for clarity.  Please only put
> relevant information in them and for regression fixes, make sure it's
> clear what functionality regressed.
> 
> e.g. #1 now reads:
> 
>     Commit 408fb0e5aa7fda0059db282ff58c3b2a4278baa0 (xen/pciback: Don't
>     allow MSI-X ops if PCI_COMMAND_MEMORY is not set) prevented enabling
>     MSI-X on passed-through virtual functions, because it checked the VF
>     for PCI_COMMAND_MEMORY but this is not a valid bit for VFs.
> 
>     Instead, check the physical function for PCI_COMMAND_MEMORY.
> 
> David
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web