Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1330678 > unrolled thread

Re: [PATCH] arm: dts: AM57XX: Correct the thermal thresholds

Started byEduardo Valentin <edubezval@gmail.com>
First post2016-02-09 23:10 +0100
Last post2016-02-15 18:30 +0100
Articles 9 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] arm: dts: AM57XX: Correct the thermal thresholds Eduardo Valentin <edubezval@gmail.com> - 2016-02-09 23:10 +0100
    Re: [PATCH] arm: dts: AM57XX: Correct the thermal thresholds Nishanth Menon <nm@ti.com> - 2016-02-09 23:20 +0100
      Re: [PATCH] arm: dts: AM57XX: Correct the thermal thresholds Tony Lindgren <tony@atomide.com> - 2016-02-12 23:30 +0100
        Re: [PATCH] arm: dts: AM57XX: Correct the thermal thresholds Nishanth Menon <nm@ti.com> - 2016-02-12 23:40 +0100
          Re: [PATCH] arm: dts: AM57XX: Correct the thermal thresholds Tony Lindgren <tony@atomide.com> - 2016-02-12 23:50 +0100
            Re: [PATCH] arm: dts: AM57XX: Correct the thermal thresholds Keerthy <a0393675@ti.com> - 2016-02-15 05:40 +0100
              Re: [PATCH] arm: dts: AM57XX: Correct the thermal thresholds Nishanth Menon <nm@ti.com> - 2016-02-15 17:00 +0100
                Re: [PATCH] arm: dts: AM57XX: Correct the thermal thresholds Keerthy <a0393675@ti.com> - 2016-02-15 17:20 +0100
                  Re: [PATCH] arm: dts: AM57XX: Correct the thermal thresholds Nishanth Menon <nm@ti.com> - 2016-02-15 18:30 +0100

#1330678 — Re: [PATCH] arm: dts: AM57XX: Correct the thermal thresholds

FromEduardo Valentin <edubezval@gmail.com>
Date2016-02-09 23:10 +0100
SubjectRe: [PATCH] arm: dts: AM57XX: Correct the thermal thresholds
Message-ID<r0oDV-1LZ-11@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

On Mon, Feb 08, 2016 at 03:15:05PM +0530, Keerthy wrote:
> The thermal threholds for am57xx are different from that of dra7.
> Correcting the thresholds for the same.
> 
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> 
> Depends on: https://lkml.org/lkml/2016/2/8/90
> 
>  arch/arm/boot/dts/am57xx-beagle-x15.dts | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> Index: linux/arch/arm/boot/dts/am57xx-beagle-x15.dts
> ===================================================================
> --- linux.orig/arch/arm/boot/dts/am57xx-beagle-x15.dts	2016-02-08 14:57:05.514959101 +0530
> +++ linux/arch/arm/boot/dts/am57xx-beagle-x15.dts	2016-02-08 14:57:05.510959168 +0530

Sorry, did not bother to check, but is this the only user of am57xx?

Apart from the above:

Acked-by: Eduardo Valentin <edubezval@gmail.com>


> @@ -825,3 +825,27 @@
>  		status = "okay";
>  	};
>  };
> +
> +&cpu_alert0 {
> +	temperature = <90000>; /* milliCelsius */
> +};
> +
> +&cpu_crit {
> +	temperature = <105000>; /* milliCelsius */
> +};
> +
> +&gpu_crit {
> +	temperature = <105000>; /* milliCelsius */
> +};
> +
> +&core_crit {
> +	temperature = <105000>; /* milliCelsius */
> +};
> +
> +&dspeve_crit {
> +	temperature = <105000>; /* milliCelsius */
> +};
> +
> +&iva_crit {
> +	temperature = <105000>; /* milliCelsius */
> +};

[toc] | [next] | [standalone]

#1330682

FromNishanth Menon <nm@ti.com>
Date2016-02-09 23:20 +0100
Message-ID<r0oNz-1Pq-1@gated-at.bofh.it>
In reply to#1330678
On 02/09/2016 04:09 PM, Eduardo Valentin wrote:
> On Mon, Feb 08, 2016 at 03:15:05PM +0530, Keerthy wrote:
>> The thermal threholds for am57xx are different from that of dra7.
>> Correcting the thresholds for the same.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>>
>> Depends on: https://lkml.org/lkml/2016/2/8/90
>>
>>  arch/arm/boot/dts/am57xx-beagle-x15.dts | 24 ++++++++++++++++++++++++
>>  1 file changed, 24 insertions(+)
>>
>> Index: linux/arch/arm/boot/dts/am57xx-beagle-x15.dts
>> ===================================================================
>> --- linux.orig/arch/arm/boot/dts/am57xx-beagle-x15.dts	2016-02-08 14:57:05.514959101 +0530
>> +++ linux/arch/arm/boot/dts/am57xx-beagle-x15.dts	2016-02-08 14:57:05.510959168 +0530
> 
> Sorry, did not bother to check, but is this the only user of am57xx?

we will have AM57xx-IDK as well coming down the line. we already have
arch/arm/boot/dts/am57xx-cl-som-am57x.dts
arch/arm/boot/dts/am57xx-sbc-am57x.dts - not really sure what grade of
silicon are used in cl-SOM and sbc boards.


-- 
Regards,
Nishanth Menon

[toc] | [prev] | [next] | [standalone]

#1333182

FromTony Lindgren <tony@atomide.com>
Date2016-02-12 23:30 +0100
Message-ID<r1unU-4EM-15@gated-at.bofh.it>
In reply to#1330682
* Nishanth Menon <nm@ti.com> [160209 14:17]:
> On 02/09/2016 04:09 PM, Eduardo Valentin wrote:
> > On Mon, Feb 08, 2016 at 03:15:05PM +0530, Keerthy wrote:
> >> The thermal threholds for am57xx are different from that of dra7.
> >> Correcting the thresholds for the same.
> >>
> >> Signed-off-by: Keerthy <j-keerthy@ti.com>
> >> ---
> >>
> >> Depends on: https://lkml.org/lkml/2016/2/8/90
> >>
> >>  arch/arm/boot/dts/am57xx-beagle-x15.dts | 24 ++++++++++++++++++++++++
> >>  1 file changed, 24 insertions(+)
> >>
> >> Index: linux/arch/arm/boot/dts/am57xx-beagle-x15.dts
> >> ===================================================================
> >> --- linux.orig/arch/arm/boot/dts/am57xx-beagle-x15.dts	2016-02-08 14:57:05.514959101 +0530
> >> +++ linux/arch/arm/boot/dts/am57xx-beagle-x15.dts	2016-02-08 14:57:05.510959168 +0530
> > 
> > Sorry, did not bother to check, but is this the only user of am57xx?
> 
> we will have AM57xx-IDK as well coming down the line. we already have
> arch/arm/boot/dts/am57xx-cl-som-am57x.dts
> arch/arm/boot/dts/am57xx-sbc-am57x.dts - not really sure what grade of
> silicon are used in cl-SOM and sbc boards.

Hmm can this one wait for v4.6 or is it critical for v4.5-rc
cycle?

Regards,

Tony

[toc] | [prev] | [next] | [standalone]

#1333184

FromNishanth Menon <nm@ti.com>
Date2016-02-12 23:40 +0100
Message-ID<r1uxA-4IF-7@gated-at.bofh.it>
In reply to#1333182
On Fri, Feb 12, 2016 at 4:23 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Nishanth Menon <nm@ti.com> [160209 14:17]:
>> On 02/09/2016 04:09 PM, Eduardo Valentin wrote:
>> > On Mon, Feb 08, 2016 at 03:15:05PM +0530, Keerthy wrote:
>> >> The thermal threholds for am57xx are different from that of dra7.
>> >> Correcting the thresholds for the same.
>> >>
>> >> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> >> ---
>> >>
>> >> Depends on: https://lkml.org/lkml/2016/2/8/90
>> >>
>> >>  arch/arm/boot/dts/am57xx-beagle-x15.dts | 24 ++++++++++++++++++++++++
>> >>  1 file changed, 24 insertions(+)
>> >>
>> >> Index: linux/arch/arm/boot/dts/am57xx-beagle-x15.dts
>> >> ===================================================================
>> >> --- linux.orig/arch/arm/boot/dts/am57xx-beagle-x15.dts     2016-02-08 14:57:05.514959101 +0530
>> >> +++ linux/arch/arm/boot/dts/am57xx-beagle-x15.dts  2016-02-08 14:57:05.510959168 +0530
>> >
>> > Sorry, did not bother to check, but is this the only user of am57xx?
>>
>> we will have AM57xx-IDK as well coming down the line. we already have
>> arch/arm/boot/dts/am57xx-cl-som-am57x.dts
>> arch/arm/boot/dts/am57xx-sbc-am57x.dts - not really sure what grade of
>> silicon are used in cl-SOM and sbc boards.
>
> Hmm can this one wait for v4.6 or is it critical for v4.5-rc
> cycle?

personally, I'd like to NAK this patch -> lack of reference
documentation, and guidance for various AM57xx boards in a generic
patch should probably be followed IMHO.
---
Regards,
Nishanth Menon

[toc] | [prev] | [next] | [standalone]

#1333185

FromTony Lindgren <tony@atomide.com>
Date2016-02-12 23:50 +0100
Message-ID<r1uHf-4N4-11@gated-at.bofh.it>
In reply to#1333184
* Nishanth Menon <nm@ti.com> [160212 14:32]:
> On Fri, Feb 12, 2016 at 4:23 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Nishanth Menon <nm@ti.com> [160209 14:17]:
> >> On 02/09/2016 04:09 PM, Eduardo Valentin wrote:
> >> > On Mon, Feb 08, 2016 at 03:15:05PM +0530, Keerthy wrote:
> >> >> The thermal threholds for am57xx are different from that of dra7.
> >> >> Correcting the thresholds for the same.
> >> >>
> >> >> Signed-off-by: Keerthy <j-keerthy@ti.com>
> >> >> ---
> >> >>
> >> >> Depends on: https://lkml.org/lkml/2016/2/8/90
> >> >>
> >> >>  arch/arm/boot/dts/am57xx-beagle-x15.dts | 24 ++++++++++++++++++++++++
> >> >>  1 file changed, 24 insertions(+)
> >> >>
> >> >> Index: linux/arch/arm/boot/dts/am57xx-beagle-x15.dts
> >> >> ===================================================================
> >> >> --- linux.orig/arch/arm/boot/dts/am57xx-beagle-x15.dts     2016-02-08 14:57:05.514959101 +0530
> >> >> +++ linux/arch/arm/boot/dts/am57xx-beagle-x15.dts  2016-02-08 14:57:05.510959168 +0530
> >> >
> >> > Sorry, did not bother to check, but is this the only user of am57xx?
> >>
> >> we will have AM57xx-IDK as well coming down the line. we already have
> >> arch/arm/boot/dts/am57xx-cl-som-am57x.dts
> >> arch/arm/boot/dts/am57xx-sbc-am57x.dts - not really sure what grade of
> >> silicon are used in cl-SOM and sbc boards.
> >
> > Hmm can this one wait for v4.6 or is it critical for v4.5-rc
> > cycle?
> 
> personally, I'd like to NAK this patch -> lack of reference
> documentation, and guidance for various AM57xx boards in a generic
> patch should probably be followed IMHO.

OK let's wait for that then.

Regards,

Tony

[toc] | [prev] | [next] | [standalone]

#1334140

FromKeerthy <a0393675@ti.com>
Date2016-02-15 05:40 +0100
Message-ID<r2j74-4hS-3@gated-at.bofh.it>
In reply to#1333185

On Saturday 13 February 2016 04:11 AM, Tony Lindgren wrote:
> * Nishanth Menon <nm@ti.com> [160212 14:32]:
>> On Fri, Feb 12, 2016 at 4:23 PM, Tony Lindgren <tony@atomide.com> wrote:
>>> * Nishanth Menon <nm@ti.com> [160209 14:17]:
>>>> On 02/09/2016 04:09 PM, Eduardo Valentin wrote:
>>>>> On Mon, Feb 08, 2016 at 03:15:05PM +0530, Keerthy wrote:
>>>>>> The thermal threholds for am57xx are different from that of dra7.
>>>>>> Correcting the thresholds for the same.
>>>>>>
>>>>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>>>>> ---
>>>>>>
>>>>>> Depends on: https://lkml.org/lkml/2016/2/8/90
>>>>>>
>>>>>>   arch/arm/boot/dts/am57xx-beagle-x15.dts | 24 ++++++++++++++++++++++++
>>>>>>   1 file changed, 24 insertions(+)
>>>>>>
>>>>>> Index: linux/arch/arm/boot/dts/am57xx-beagle-x15.dts
>>>>>> ===================================================================
>>>>>> --- linux.orig/arch/arm/boot/dts/am57xx-beagle-x15.dts     2016-02-08 14:57:05.514959101 +0530
>>>>>> +++ linux/arch/arm/boot/dts/am57xx-beagle-x15.dts  2016-02-08 14:57:05.510959168 +0530
>>>>>
>>>>> Sorry, did not bother to check, but is this the only user of am57xx?
>>>>
>>>> we will have AM57xx-IDK as well coming down the line. we already have
>>>> arch/arm/boot/dts/am57xx-cl-som-am57x.dts
>>>> arch/arm/boot/dts/am57xx-sbc-am57x.dts - not really sure what grade of
>>>> silicon are used in cl-SOM and sbc boards.
>>>
>>> Hmm can this one wait for v4.6 or is it critical for v4.5-rc
>>> cycle?
>>
>> personally, I'd like to NAK this patch -> lack of reference
>> documentation, and guidance for various AM57xx boards in a generic
>> patch should probably be followed IMHO.
>
> OK let's wait for that then.

OK. I will send a v2 with better documentation.

>
> Regards,
>
> Tony
>

[toc] | [prev] | [next] | [standalone]

#1334556

FromNishanth Menon <nm@ti.com>
Date2016-02-15 17:00 +0100
Message-ID<r2tJ8-30g-19@gated-at.bofh.it>
In reply to#1334140
On 02/14/2016 10:27 PM, Keerthy wrote:
> 
> 
> On Saturday 13 February 2016 04:11 AM, Tony Lindgren wrote:
>> * Nishanth Menon <nm@ti.com> [160212 14:32]:
>>> On Fri, Feb 12, 2016 at 4:23 PM, Tony Lindgren <tony@atomide.com> wrote:
>>>> * Nishanth Menon <nm@ti.com> [160209 14:17]:
>>>>> On 02/09/2016 04:09 PM, Eduardo Valentin wrote:
>>>>>> On Mon, Feb 08, 2016 at 03:15:05PM +0530, Keerthy wrote:
>>>>>>> The thermal threholds for am57xx are different from that of dra7.
>>>>>>> Correcting the thresholds for the same.
>>>>>>>
>>>>>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>>>>>> ---
>>>>>>>
>>>>>>> Depends on: https://lkml.org/lkml/2016/2/8/90
>>>>>>>
>>>>>>>   arch/arm/boot/dts/am57xx-beagle-x15.dts | 24 ++++++++++++++++++++++++
>>>>>>>   1 file changed, 24 insertions(+)
>>>>>>>
>>>>>>> Index: linux/arch/arm/boot/dts/am57xx-beagle-x15.dts
>>>>>>> ===================================================================
>>>>>>> --- linux.orig/arch/arm/boot/dts/am57xx-beagle-x15.dts     2016-02-08 14:57:05.514959101 +0530
>>>>>>> +++ linux/arch/arm/boot/dts/am57xx-beagle-x15.dts  2016-02-08 14:57:05.510959168 +0530
>>>>>>
>>>>>> Sorry, did not bother to check, but is this the only user of am57xx?
>>>>>
>>>>> we will have AM57xx-IDK as well coming down the line. we already have
>>>>> arch/arm/boot/dts/am57xx-cl-som-am57x.dts
>>>>> arch/arm/boot/dts/am57xx-sbc-am57x.dts - not really sure what grade of
>>>>> silicon are used in cl-SOM and sbc boards.
>>>>
>>>> Hmm can this one wait for v4.6 or is it critical for v4.5-rc
>>>> cycle?
>>>
>>> personally, I'd like to NAK this patch -> lack of reference
>>> documentation, and guidance for various AM57xx boards in a generic
>>> patch should probably be followed IMHO.
>>
>> OK let's wait for that then.
> 
> OK. I will send a v2 with better documentation.



This data is in the AM572x datasheet:
http://www.ti.com/lit/ds/symlink/am5728.pdf

Table 5-3 in the current version contains the maximum junction
temperatures.

this indicates that there are "Commercial" and "extended" -> we may
need to introduce just 2 dtsis -> am57xx-commercial and
am57xx-extended and reuse those based on the part on the board. just a
suggestion..


-- 
Regards,
Nishanth Menon

[toc] | [prev] | [next] | [standalone]

#1334569

FromKeerthy <a0393675@ti.com>
Date2016-02-15 17:20 +0100
Message-ID<r2u2u-3n5-19@gated-at.bofh.it>
In reply to#1334556

On Monday 15 February 2016 09:19 PM, Nishanth Menon wrote:
> On 02/14/2016 10:27 PM, Keerthy wrote:
>>
>>
>> On Saturday 13 February 2016 04:11 AM, Tony Lindgren wrote:
>>> * Nishanth Menon <nm@ti.com> [160212 14:32]:
>>>> On Fri, Feb 12, 2016 at 4:23 PM, Tony Lindgren <tony@atomide.com> wrote:
>>>>> * Nishanth Menon <nm@ti.com> [160209 14:17]:
>>>>>> On 02/09/2016 04:09 PM, Eduardo Valentin wrote:
>>>>>>> On Mon, Feb 08, 2016 at 03:15:05PM +0530, Keerthy wrote:
>>>>>>>> The thermal threholds for am57xx are different from that of dra7.
>>>>>>>> Correcting the thresholds for the same.
>>>>>>>>
>>>>>>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>>>>>>> ---
>>>>>>>>
>>>>>>>> Depends on: https://lkml.org/lkml/2016/2/8/90
>>>>>>>>
>>>>>>>>    arch/arm/boot/dts/am57xx-beagle-x15.dts | 24 ++++++++++++++++++++++++
>>>>>>>>    1 file changed, 24 insertions(+)
>>>>>>>>
>>>>>>>> Index: linux/arch/arm/boot/dts/am57xx-beagle-x15.dts
>>>>>>>> ===================================================================
>>>>>>>> --- linux.orig/arch/arm/boot/dts/am57xx-beagle-x15.dts     2016-02-08 14:57:05.514959101 +0530
>>>>>>>> +++ linux/arch/arm/boot/dts/am57xx-beagle-x15.dts  2016-02-08 14:57:05.510959168 +0530
>>>>>>>
>>>>>>> Sorry, did not bother to check, but is this the only user of am57xx?
>>>>>>
>>>>>> we will have AM57xx-IDK as well coming down the line. we already have
>>>>>> arch/arm/boot/dts/am57xx-cl-som-am57x.dts
>>>>>> arch/arm/boot/dts/am57xx-sbc-am57x.dts - not really sure what grade of
>>>>>> silicon are used in cl-SOM and sbc boards.
>>>>>
>>>>> Hmm can this one wait for v4.6 or is it critical for v4.5-rc
>>>>> cycle?
>>>>
>>>> personally, I'd like to NAK this patch -> lack of reference
>>>> documentation, and guidance for various AM57xx boards in a generic
>>>> patch should probably be followed IMHO.
>>>
>>> OK let's wait for that then.
>>
>> OK. I will send a v2 with better documentation.
>
>
>
> This data is in the AM572x datasheet:
> http://www.ti.com/lit/ds/symlink/am5728.pdf
>
> Table 5-3 in the current version contains the maximum junction
> temperatures.
>
> this indicates that there are "Commercial" and "extended" -> we may
> need to introduce just 2 dtsis -> am57xx-commercial and
> am57xx-extended and reuse those based on the part on the board. just a
> suggestion..

Or use the minimum of the 2 to be on the safer side if we have to deal 
with one dtsi?

Regards,
Keerthy
>
>

[toc] | [prev] | [next] | [standalone]

#1334653

FromNishanth Menon <nm@ti.com>
Date2016-02-15 18:30 +0100
Message-ID<r2v8g-45p-53@gated-at.bofh.it>
In reply to#1334569
On 02/15/2016 10:13 AM, Keerthy wrote:
[...]
>>
>> This data is in the AM572x datasheet:
>> http://www.ti.com/lit/ds/symlink/am5728.pdf
>>
>> Table 5-3 in the current version contains the maximum junction
>> temperatures.
>>
>> this indicates that there are "Commercial" and "extended" -> we may
>> need to introduce just 2 dtsis -> am57xx-commercial and
>> am57xx-extended and reuse those based on the part on the board. just a
>> suggestion..
> 
> Or use the minimum of the 2 to be on the safer side if we have to deal 
> with one dtsi?

Why would we want to throttle earlier on customer platforms or other
boards using extended? at the very least -> if all upstream boards
have only commercial grade, then just introduce
am57xx-commercial-thermal.dtsi ..


-- 
Regards,
Nishanth Menon

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web