Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1334054 > unrolled thread

Re: [PATCH v3 1/6] pinctrl: qcom: ipq4019: Add IPQ4019 pinctrl support

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 1/6] pinctrl: qcom: ipq4019: Add IPQ4019 pinctrl support Bjorn Andersson <bjorn@kryo.se> - 2016-02-15 01:50 +0100
    Re: [PATCH v3 1/6] pinctrl: qcom: ipq4019: Add IPQ4019 pinctrl support Linus Walleij <linus.walleij@linaro.org> - 2016-02-16 16:00 +0100

#1334054 — Re: [PATCH v3 1/6] pinctrl: qcom: ipq4019: Add IPQ4019 pinctrl support

On Thu, Nov 19, 2015 at 3:19 PM, Matthew McClintock
<mmcclint@qca.qualcomm.com> wrote:
> From: Varadarajan Narayanan <varada@codeaurora.org>
>
> Add pinctrl driver support for IPQ4019 platform
>
> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
> Signed-off-by: Mathieu Olivari <mathieu@codeaurora.org>
> Signed-off-by: Varadarajan Narayanan <varada@codeaurora.org>
> Signed-off-by: Matthew McClintock <mmcclint@codeaurora.org>
> ---

I was asked to review this, to make sure that Linus wasn't waiting for
my ack or anything. But now I see that you have not added him as a
recipient. Please make sure to run ./scripts/get_maintainer.pl and
pick appropriate recipients in the future.

>
> v3
> - update example with actual values from dts
> - add missing pins 71-99
> - drop many functions and stick to basic functionality
>

I hope to see a patch later on adding all those functions back, but
that's fine with me.

[..]

> +static struct platform_driver ipq4019_pinctrl_driver = {
> +       .driver = {
> +               .name = "ipq4019-pinctrl",
> +               .owner = THIS_MODULE,

platform_drivers do get their .owner assigned by platform_drive_register().

> +               .of_match_table = ipq4019_pinctrl_of_match,
> +       },
> +       .probe = ipq4019_pinctrl_probe,
> +       .remove = msm_pinctrl_remove,
> +};

Part of the .owner above you have my
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>

@Linus, this still applies and builds cleanly on linux-next.
Would you be okay dropping the owner assignment while applying this patch?

Regards,
Bjorn

[toc] | [next] | [standalone]

#1335492

On Mon, Feb 15, 2016 at 1:41 AM, Bjorn Andersson <bjorn@kryo.se> wrote:

> Part of the .owner above you have my
> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Thx.

> @Linus, this still applies and builds cleanly on linux-next.
> Would you be okay dropping the owner assignment while applying this patch?

Yeah I fix.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web