Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1333881 > unrolled thread

[PATCH 4.3 165/200] crypto: algif_skcipher - Add key check exception for cipher_null

Started byGreg Kroah-Hartman <gregkh@linuxfoundation.org>
First post2016-02-15 01:00 +0100
Last post2016-02-15 01:00 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 4.3 165/200] crypto: algif_skcipher - Add key check exception for cipher_null Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-15 01:00 +0100

#1333881 — [PATCH 4.3 165/200] crypto: algif_skcipher - Add key check exception for cipher_null

FromGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Date2016-02-15 01:00 +0100
Subject[PATCH 4.3 165/200] crypto: algif_skcipher - Add key check exception for cipher_null
Message-ID<r2eK6-1jj-3@gated-at.bofh.it>
4.3-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Herbert Xu <herbert@gondor.apana.org.au>

commit 6e8d8ecf438792ecf7a3207488fb4eebc4edb040 upstream.

This patch adds an exception to the key check so that cipher_null
users may continue to use algif_skcipher without setting a key.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 crypto/algif_skcipher.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/crypto/algif_skcipher.c
+++ b/crypto/algif_skcipher.c
@@ -978,7 +978,7 @@ static int skcipher_accept_parent(void *
 {
 	struct skcipher_tfm *tfm = private;
 
-	if (!tfm->has_key)
+	if (!tfm->has_key && crypto_skcipher_has_setkey(tfm->skcipher))
 		return -ENOKEY;
 
 	return skcipher_accept_parent_common(private, sk);

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web