Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1332689 > unrolled thread

Re: [PATCH 1/2] mmc: dw_mmc: remove unused EVENT_XFER_ERROR

Started byShawn Lin <shawn.lin@rock-chips.com>
First post2016-02-12 12:40 +0100
Last post2016-02-14 23:30 +0100
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/2] mmc: dw_mmc: remove unused EVENT_XFER_ERROR Shawn Lin <shawn.lin@rock-chips.com> - 2016-02-12 12:40 +0100
    Re: [PATCH 1/2] mmc: dw_mmc: remove unused EVENT_XFER_ERROR Jaehoon Chung <jh80.chung@samsung.com> - 2016-02-14 23:30 +0100
      Re: [PATCH 1/2] mmc: dw_mmc: remove unused EVENT_XFER_ERROR Shawn Lin <shawn.lin@rock-chips.com> - 2016-02-15 01:30 +0100
    Re: [PATCH 1/2] mmc: dw_mmc: remove unused EVENT_XFER_ERROR Jaehoon Chung <jh80.chung@samsung.com> - 2016-02-14 23:30 +0100

#1332689 — Re: [PATCH 1/2] mmc: dw_mmc: remove unused EVENT_XFER_ERROR

FromShawn Lin <shawn.lin@rock-chips.com>
Date2016-02-12 12:40 +0100
SubjectRe: [PATCH 1/2] mmc: dw_mmc: remove unused EVENT_XFER_ERROR
Message-ID<r1keR-6lx-7@gated-at.bofh.it>
On 2016/2/4 14:12, Jaehoon Chung wrote:
> Hi, Shawn.
>
> On 02/03/2016 12:26 PM, Shawn Lin wrote:
>> EVENT_XFER_ERROR isn't been used now, so we can
>> remove it.
>
> If you are ok, after changing the commit message, I will apply this.
> Thanks!

Should I respin v2 to amend the commit msg? :-)

>
> Best Regards,
> Jaehoon Chung
>
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>> ---
>>
>>   include/linux/mmc/dw_mmc.h | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h
>> index 89df7ab..b29e06e 100644
>> --- a/include/linux/mmc/dw_mmc.h
>> +++ b/include/linux/mmc/dw_mmc.h
>> @@ -36,7 +36,6 @@ enum {
>>   	EVENT_XFER_COMPLETE,
>>   	EVENT_DATA_COMPLETE,
>>   	EVENT_DATA_ERROR,
>> -	EVENT_XFER_ERROR
>>   };
>>
>>   struct mmc_data;
>>
>
>
>
>


-- 
Best Regards
Shawn Lin

[toc] | [next] | [standalone]

#1333584

FromJaehoon Chung <jh80.chung@samsung.com>
Date2016-02-14 23:30 +0100
Message-ID<r2dl0-tX-5@gated-at.bofh.it>
In reply to#1332689
On 02/15/2016 07:27 AM, Jaehoon Chung wrote:
> On 02/12/2016 08:31 PM, Shawn Lin wrote:
>> On 2016/2/4 14:12, Jaehoon Chung wrote:
>>> Hi, Shawn.
>>>
>>> On 02/03/2016 12:26 PM, Shawn Lin wrote:
>>>> EVENT_XFER_ERROR isn't been used now, so we can
>>>> remove it.
>>>
>>> If you are ok, after changing the commit message, I will apply this.
>>> Thanks!
>>
>> Should I respin v2 to amend the commit msg? :-)
> 
> Not important..but i want to use this. :)
> "we can remove it" -> "It can be removed." 

One more..This patch is [1/2]..I didn't see the second patch [2/2].

> 
> Best Regards,
> Jaehoon Chung
> 
>>
>>>
>>> Best Regards,
>>> Jaehoon Chung
>>>
>>>>
>>>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>>>> ---
>>>>
>>>>   include/linux/mmc/dw_mmc.h | 1 -
>>>>   1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h
>>>> index 89df7ab..b29e06e 100644
>>>> --- a/include/linux/mmc/dw_mmc.h
>>>> +++ b/include/linux/mmc/dw_mmc.h
>>>> @@ -36,7 +36,6 @@ enum {
>>>>       EVENT_XFER_COMPLETE,
>>>>       EVENT_DATA_COMPLETE,
>>>>       EVENT_DATA_ERROR,
>>>> -    EVENT_XFER_ERROR
>>>>   };
>>>>
>>>>   struct mmc_data;
>>>>
>>>
>>>
>>>
>>>
>>
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
>

[toc] | [prev] | [next] | [standalone]

#1333993

FromShawn Lin <shawn.lin@rock-chips.com>
Date2016-02-15 01:30 +0100
Message-ID<r2fd8-1KG-33@gated-at.bofh.it>
In reply to#1333584
Hi Jaehoon,

On 2016/2/15 6:29, Jaehoon Chung wrote:
> On 02/15/2016 07:27 AM, Jaehoon Chung wrote:
>> On 02/12/2016 08:31 PM, Shawn Lin wrote:
>>> On 2016/2/4 14:12, Jaehoon Chung wrote:
>>>> Hi, Shawn.
>>>>
>>>> On 02/03/2016 12:26 PM, Shawn Lin wrote:
>>>>> EVENT_XFER_ERROR isn't been used now, so we can
>>>>> remove it.
>>>>
>>>> If you are ok, after changing the commit message, I will apply this.
>>>> Thanks!
>>>
>>> Should I respin v2 to amend the commit msg? :-)
>>
>> Not important..but i want to use this. :)
>> "we can remove it" -> "It can be removed."
>

yes, please.

> One more..This patch is [1/2]..I didn't see the second patch [2/2].

Only one patch here, no [2/2]. sorry for the noise

>
>>
>> Best Regards,
>> Jaehoon Chung
>>
>>>
>>>>
>>>> Best Regards,
>>>> Jaehoon Chung
>>>>
>>>>>
>>>>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>>>>> ---
>>>>>
>>>>>    include/linux/mmc/dw_mmc.h | 1 -
>>>>>    1 file changed, 1 deletion(-)
>>>>>
>>>>> diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h
>>>>> index 89df7ab..b29e06e 100644
>>>>> --- a/include/linux/mmc/dw_mmc.h
>>>>> +++ b/include/linux/mmc/dw_mmc.h
>>>>> @@ -36,7 +36,6 @@ enum {
>>>>>        EVENT_XFER_COMPLETE,
>>>>>        EVENT_DATA_COMPLETE,
>>>>>        EVENT_DATA_ERROR,
>>>>> -    EVENT_XFER_ERROR
>>>>>    };
>>>>>
>>>>>    struct mmc_data;
>>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>
>
>
>
>


-- 
Best Regards
Shawn Lin

[toc] | [prev] | [next] | [standalone]

#1333599

FromJaehoon Chung <jh80.chung@samsung.com>
Date2016-02-14 23:30 +0100
Message-ID<r2dl0-tX-7@gated-at.bofh.it>
In reply to#1332689
On 02/12/2016 08:31 PM, Shawn Lin wrote:
> On 2016/2/4 14:12, Jaehoon Chung wrote:
>> Hi, Shawn.
>>
>> On 02/03/2016 12:26 PM, Shawn Lin wrote:
>>> EVENT_XFER_ERROR isn't been used now, so we can
>>> remove it.
>>
>> If you are ok, after changing the commit message, I will apply this.
>> Thanks!
> 
> Should I respin v2 to amend the commit msg? :-)

Not important..but i want to use this. :)
"we can remove it" -> "It can be removed." 

Best Regards,
Jaehoon Chung

> 
>>
>> Best Regards,
>> Jaehoon Chung
>>
>>>
>>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>>> ---
>>>
>>>   include/linux/mmc/dw_mmc.h | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>> diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h
>>> index 89df7ab..b29e06e 100644
>>> --- a/include/linux/mmc/dw_mmc.h
>>> +++ b/include/linux/mmc/dw_mmc.h
>>> @@ -36,7 +36,6 @@ enum {
>>>       EVENT_XFER_COMPLETE,
>>>       EVENT_DATA_COMPLETE,
>>>       EVENT_DATA_ERROR,
>>> -    EVENT_XFER_ERROR
>>>   };
>>>
>>>   struct mmc_data;
>>>
>>
>>
>>
>>
> 
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web