Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1335801 > unrolled thread
| Started by | Kees Cook <keescook@chromium.org> |
|---|---|
| First post | 2016-02-16 21:40 +0100 |
| Last post | 2016-02-16 22:30 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] ARM: drop unused DEBUG_RODATA from XIP_KERNEL Kees Cook <keescook@chromium.org> - 2016-02-16 21:40 +0100
Re: [PATCH] ARM: drop unused DEBUG_RODATA from XIP_KERNEL Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-16 21:50 +0100
Re: [PATCH] ARM: drop unused DEBUG_RODATA from XIP_KERNEL Kees Cook <keescook@chromium.org> - 2016-02-16 23:00 +0100
Re: [PATCH] ARM: drop unused DEBUG_RODATA from XIP_KERNEL Arnd Bergmann <arnd@arndb.de> - 2016-02-16 22:30 +0100
| From | Kees Cook <keescook@chromium.org> |
|---|---|
| Date | 2016-02-16 21:40 +0100 |
| Subject | [PATCH] ARM: drop unused DEBUG_RODATA from XIP_KERNEL |
| Message-ID | <r2UzE-4qz-7@gated-at.bofh.it> |
With CONFIG_DEBUG_RODATA not being sensible under XIP_KERNEL, remove it
from the XIP linker script.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
Effectively the patch after Arnd's "ARM: mm: hide
__start_rodata_section_aligned for non-debug builds"
---
arch/arm/kernel/vmlinux-xip.lds.S | 10 ----------
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/arch/arm/kernel/vmlinux-xip.lds.S b/arch/arm/kernel/vmlinux-xip.lds.S
index 40bc4cadb959..cba1ec899a69 100644
--- a/arch/arm/kernel/vmlinux-xip.lds.S
+++ b/arch/arm/kernel/vmlinux-xip.lds.S
@@ -8,9 +8,6 @@
#include <asm/thread_info.h>
#include <asm/memory.h>
#include <asm/page.h>
-#ifdef CONFIG_DEBUG_RODATA
-#include <asm/pgtable.h>
-#endif
#define PROC_INFO \
. = ALIGN(4); \
@@ -92,10 +89,6 @@ SECTIONS
HEAD_TEXT
}
-#ifdef CONFIG_DEBUG_RODATA
- . = ALIGN(1<<SECTION_SHIFT);
-#endif
-
.text : { /* Real text segment */
_stext = .; /* Text and read-only data */
IDMAP_TEXT
@@ -115,9 +108,6 @@ SECTIONS
ARM_CPU_KEEP(PROC_INFO)
}
-#ifdef CONFIG_DEBUG_RODATA
- . = ALIGN(1<<SECTION_SHIFT);
-#endif
RO_DATA(PAGE_SIZE)
. = ALIGN(4);
--
2.6.3
--
Kees Cook
Chrome OS & Brillo Security
[toc] | [next] | [standalone]
| From | Nicolas Pitre <nicolas.pitre@linaro.org> |
|---|---|
| Date | 2016-02-16 21:50 +0100 |
| Message-ID | <r2UJk-4va-27@gated-at.bofh.it> |
| In reply to | #1335801 |
On Tue, 16 Feb 2016, Kees Cook wrote:
> With CONFIG_DEBUG_RODATA not being sensible under XIP_KERNEL, remove it
> from the XIP linker script.
If so you should also make DEBUG_RODATA depend on !XIP_KERNEL in Kconfig
to avoid offering a config option that does nothing.
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> Effectively the patch after Arnd's "ARM: mm: hide
> __start_rodata_section_aligned for non-debug builds"
> ---
> arch/arm/kernel/vmlinux-xip.lds.S | 10 ----------
> 1 files changed, 0 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/kernel/vmlinux-xip.lds.S b/arch/arm/kernel/vmlinux-xip.lds.S
> index 40bc4cadb959..cba1ec899a69 100644
> --- a/arch/arm/kernel/vmlinux-xip.lds.S
> +++ b/arch/arm/kernel/vmlinux-xip.lds.S
> @@ -8,9 +8,6 @@
> #include <asm/thread_info.h>
> #include <asm/memory.h>
> #include <asm/page.h>
> -#ifdef CONFIG_DEBUG_RODATA
> -#include <asm/pgtable.h>
> -#endif
>
> #define PROC_INFO \
> . = ALIGN(4); \
> @@ -92,10 +89,6 @@ SECTIONS
> HEAD_TEXT
> }
>
> -#ifdef CONFIG_DEBUG_RODATA
> - . = ALIGN(1<<SECTION_SHIFT);
> -#endif
> -
> .text : { /* Real text segment */
> _stext = .; /* Text and read-only data */
> IDMAP_TEXT
> @@ -115,9 +108,6 @@ SECTIONS
> ARM_CPU_KEEP(PROC_INFO)
> }
>
> -#ifdef CONFIG_DEBUG_RODATA
> - . = ALIGN(1<<SECTION_SHIFT);
> -#endif
> RO_DATA(PAGE_SIZE)
>
> . = ALIGN(4);
> --
> 2.6.3
>
>
> --
> Kees Cook
> Chrome OS & Brillo Security
>
>
[toc] | [prev] | [next] | [standalone]
| From | Kees Cook <keescook@chromium.org> |
|---|---|
| Date | 2016-02-16 23:00 +0100 |
| Message-ID | <r2VP3-5bH-1@gated-at.bofh.it> |
| In reply to | #1335824 |
On Tue, Feb 16, 2016 at 12:41 PM, Nicolas Pitre
<nicolas.pitre@linaro.org> wrote:
> On Tue, 16 Feb 2016, Kees Cook wrote:
>
>> With CONFIG_DEBUG_RODATA not being sensible under XIP_KERNEL, remove it
>> from the XIP linker script.
>
> If so you should also make DEBUG_RODATA depend on !XIP_KERNEL in Kconfig
> to avoid offering a config option that does nothing.
Yeah, that's what Arnd's other patch does. This is intended to follow
his cleanups that do this.
-Kees
>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>> ---
>> Effectively the patch after Arnd's "ARM: mm: hide
>> __start_rodata_section_aligned for non-debug builds"
>> ---
>> arch/arm/kernel/vmlinux-xip.lds.S | 10 ----------
>> 1 files changed, 0 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/arm/kernel/vmlinux-xip.lds.S b/arch/arm/kernel/vmlinux-xip.lds.S
>> index 40bc4cadb959..cba1ec899a69 100644
>> --- a/arch/arm/kernel/vmlinux-xip.lds.S
>> +++ b/arch/arm/kernel/vmlinux-xip.lds.S
>> @@ -8,9 +8,6 @@
>> #include <asm/thread_info.h>
>> #include <asm/memory.h>
>> #include <asm/page.h>
>> -#ifdef CONFIG_DEBUG_RODATA
>> -#include <asm/pgtable.h>
>> -#endif
>>
>> #define PROC_INFO \
>> . = ALIGN(4); \
>> @@ -92,10 +89,6 @@ SECTIONS
>> HEAD_TEXT
>> }
>>
>> -#ifdef CONFIG_DEBUG_RODATA
>> - . = ALIGN(1<<SECTION_SHIFT);
>> -#endif
>> -
>> .text : { /* Real text segment */
>> _stext = .; /* Text and read-only data */
>> IDMAP_TEXT
>> @@ -115,9 +108,6 @@ SECTIONS
>> ARM_CPU_KEEP(PROC_INFO)
>> }
>>
>> -#ifdef CONFIG_DEBUG_RODATA
>> - . = ALIGN(1<<SECTION_SHIFT);
>> -#endif
>> RO_DATA(PAGE_SIZE)
>>
>> . = ALIGN(4);
>> --
>> 2.6.3
>>
>>
>> --
>> Kees Cook
>> Chrome OS & Brillo Security
>>
>>
--
Kees Cook
Chrome OS & Brillo Security
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-02-16 22:30 +0100 |
| Message-ID | <r2Vm1-4ZP-1@gated-at.bofh.it> |
| In reply to | #1335801 |
On Tuesday 16 February 2016 12:29:57 Kees Cook wrote: > With CONFIG_DEBUG_RODATA not being sensible under XIP_KERNEL, remove it > from the XIP linker script. > > Signed-off-by: Kees Cook <keescook@chromium.org> > Acked-by: Arnd Bergmann <arnd@arndb.de>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web