Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1335582 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-02-16 17:00 +0100 |
| Last post | 2016-02-17 20:40 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] iio: health/afe4403: select REGMAP_SPI Arnd Bergmann <arnd@arndb.de> - 2016-02-16 17:00 +0100
Re: [PATCH] iio: health/afe4403: select REGMAP_SPI "Andrew F. Davis" <afd@ti.com> - 2016-02-16 17:20 +0100
Re: [PATCH] iio: health/afe4403: select REGMAP_SPI Jonathan Cameron <jic23@kernel.org> - 2016-02-17 20:40 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-02-16 17:00 +0100 |
| Subject | [PATCH] iio: health/afe4403: select REGMAP_SPI |
| Message-ID | <r2QcH-1mI-29@gated-at.bofh.it> |
The newly added afe4403 driver uses the regmap facility to abstract
the I2C and SPI access. However, it fails to ensure that regmap_spi
is actually present:
drivers/iio/built-in.o: In function `afe4403_probe':
:(.text+0x9bf8): undefined reference to `__devm_regmap_init_spi'
This adds a Kconfig select statement like the afe4404 I2C driver
has.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: eec96d1e2d31 ("iio: health: Add driver for the TI AFE4403 heart monitor")
---
drivers/iio/health/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/health/Kconfig b/drivers/iio/health/Kconfig
index f0c19779ac27..c5f004a8e447 100644
--- a/drivers/iio/health/Kconfig
+++ b/drivers/iio/health/Kconfig
@@ -10,6 +10,7 @@ menu "Heart Rate Monitors"
config AFE4403
tristate "TI AFE4403 Heart Rate Monitor"
depends on SPI_MASTER
+ select REGMAP_SPI
select IIO_BUFFER
select IIO_TRIGGERED_BUFFER
help
--
2.7.0
[toc] | [next] | [standalone]
| From | "Andrew F. Davis" <afd@ti.com> |
|---|---|
| Date | 2016-02-16 17:20 +0100 |
| Message-ID | <r2Qw1-1LV-3@gated-at.bofh.it> |
| In reply to | #1335582 |
On 02/16/2016 09:52 AM, Arnd Bergmann wrote:
> The newly added afe4403 driver uses the regmap facility to abstract
> the I2C and SPI access. However, it fails to ensure that regmap_spi
> is actually present:
>
> drivers/iio/built-in.o: In function `afe4403_probe':
> :(.text+0x9bf8): undefined reference to `__devm_regmap_init_spi'
>
> This adds a Kconfig select statement like the afe4404 I2C driver
> has.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: eec96d1e2d31 ("iio: health: Add driver for the TI AFE4403 heart monitor")
> ---
> drivers/iio/health/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/health/Kconfig b/drivers/iio/health/Kconfig
> index f0c19779ac27..c5f004a8e447 100644
> --- a/drivers/iio/health/Kconfig
> +++ b/drivers/iio/health/Kconfig
> @@ -10,6 +10,7 @@ menu "Heart Rate Monitors"
> config AFE4403
> tristate "TI AFE4403 Heart Rate Monitor"
> depends on SPI_MASTER
> + select REGMAP_SPI
> select IIO_BUFFER
> select IIO_TRIGGERED_BUFFER
> help
>
Oversight on my part, thanks for fix.
Acked-by: Andrew F. Davis <afd@ti.com>
[toc] | [prev] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2016-02-17 20:40 +0100 |
| Message-ID | <r3g77-2uR-1@gated-at.bofh.it> |
| In reply to | #1335594 |
On 16/02/16 16:14, Andrew F. Davis wrote:
> On 02/16/2016 09:52 AM, Arnd Bergmann wrote:
>> The newly added afe4403 driver uses the regmap facility to abstract
>> the I2C and SPI access. However, it fails to ensure that regmap_spi
>> is actually present:
>>
>> drivers/iio/built-in.o: In function `afe4403_probe':
>> :(.text+0x9bf8): undefined reference to `__devm_regmap_init_spi'
>>
>> This adds a Kconfig select statement like the afe4404 I2C driver
>> has.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: eec96d1e2d31 ("iio: health: Add driver for the TI AFE4403 heart monitor")
>> ---
>> drivers/iio/health/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/iio/health/Kconfig b/drivers/iio/health/Kconfig
>> index f0c19779ac27..c5f004a8e447 100644
>> --- a/drivers/iio/health/Kconfig
>> +++ b/drivers/iio/health/Kconfig
>> @@ -10,6 +10,7 @@ menu "Heart Rate Monitors"
>> config AFE4403
>> tristate "TI AFE4403 Heart Rate Monitor"
>> depends on SPI_MASTER
>> + select REGMAP_SPI
>> select IIO_BUFFER
>> select IIO_TRIGGERED_BUFFER
>> help
>>
>
> Oversight on my part, thanks for fix.
>
> Acked-by: Andrew F. Davis <afd@ti.com>
Applied to the togreg branch of iio.git - initially pushed out as testing
for the autobuilders to fail to trigger similar issues... (ah well, they can't
hammer everything!)
Thanks Arnd!
Jonathan
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web