Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1335064 > unrolled thread

[PATCH v5 0/3] arm64/clk: EXYNOS: Consolidate Exynos7 symbol

Back to article view | Back to linux.kernel

Contents

  [PATCH v5 0/3] arm64/clk: EXYNOS: Consolidate Exynos7 symbol Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-16 07:30 +0100
    [PATCH v5 1/3] clk: samsung: Enable COMPILE_TEST for Samsung clocks Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-16 07:30 +0100
    Re: [PATCH v5 0/3] arm64/clk: EXYNOS: Consolidate Exynos7 symbol Michael Turquette <mturquette@baylibre.com> - 2016-02-16 23:50 +0100

#1335064 — [PATCH v5 0/3] arm64/clk: EXYNOS: Consolidate Exynos7 symbol

Hi,

Patchset attempts to remove the ARCH_EXYNOS7 symbol.

I rebased this on top of James':
 - clk: Move vendor's Kconfig into CCF menu section
   http://www.spinics.net/lists/devicetree/msg111953.html

The third patch depends on previous ones so one way of merging this
would be to prepare a tag from clk tree with first two patches
and the dependency. The last third patch would go through arm-soc.

Changes since v4:
=================
1. Rebased on "clk: Move vendor's Kconfig into CCF menu section"
   existing in clock tree.
2. Re-work patch 2/3 (see specific changelog).

Changes since v3:
=================
1. Rebase on next-20160127 (s3c64xx became multiplatform).

Changes since v2:
=================
1. Follow Arnd's advice about not enabling silently the newly added
   EXYNOS_ARM64_COMMON_CLK, when COMPILE_TEST is enabled. This was
   also a trigger for some changes in placement of Samsung clocks
   Kconfig entries...
2. ... which lead to introducing patch 1.


Rationale:
==========
We don't need ARCH_EXYNOS7 symbol because all ARMv8 platforms should
fall under generic ARCH_EXYNOS. In the same time there is no sense
in building clocks for these ARMv8 SoCs on ARMv7 builds.


Best regards,
Krzysztof

Krzysztof Kozlowski (3):
  clk: samsung: Enable COMPILE_TEST for Samsung clocks
  clk: samsung: Don't build ARMv8 clock drivers on ARMv7
  arm64: EXYNOS: Consolidate ARCH_EXYNOS7 symbol into ARCH_EXYNOS

 arch/arm64/Kconfig.platforms        | 11 ++---------
 arch/arm64/boot/dts/exynos/Makefile |  2 +-
 arch/arm64/configs/defconfig        |  2 +-
 drivers/clk/samsung/Kconfig         | 18 +++++++++++++-----
 drivers/clk/samsung/Makefile        |  4 ++--
 5 files changed, 19 insertions(+), 18 deletions(-)

-- 
2.5.0

[toc] | [next] | [standalone]

#1335065 — [PATCH v5 1/3] clk: samsung: Enable COMPILE_TEST for Samsung clocks

Enable the COMPILE_TEST to get build coverage of some of Samsung clock
controller drivers. Still some of them will be built only if
appropriate SoC is chosen (like SOC_EXYNOS4415 or ARCH_S3C64XX).

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Tested-by: Javier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by: Andi Shyti <andi.shyti@samsung.com>

---

Changes since v4:
1. Rebase on current clk tree which already contains patch moving
   Samsung clock drivers into the COMMON_CLK section.
   (b9e65ebc654, "clk: Move vendor's Kconfig into CCF menu section")

Changes since v3:
1. Rebase on next-20160127 (s3c64xx became multiplatform)

Changes since v2:
1. New patch.
---
 drivers/clk/samsung/Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig
index b3fe5cb01afe..dd6093a33f84 100644
--- a/drivers/clk/samsung/Kconfig
+++ b/drivers/clk/samsung/Kconfig
@@ -1,8 +1,8 @@
 config COMMON_CLK_SAMSUNG
-	bool
+	bool "Samsung Exynos clock controller support" if COMPILE_TEST
 
 config S3C2410_COMMON_CLK
-	bool
+	bool "Samsung S3C2410 clock controller support" if COMPILE_TEST
 	select COMMON_CLK_SAMSUNG
 	help
 	  Build the s3c2410 clock driver based on the common clock framework.
@@ -16,10 +16,10 @@ config S3C2410_COMMON_DCLK
 	  framework.
 
 config S3C2412_COMMON_CLK
-	bool
+	bool "Samsung S3C2412 clock controller support" if COMPILE_TEST
 	select COMMON_CLK_SAMSUNG
 
 config S3C2443_COMMON_CLK
-	bool
+	bool "Samsung S3C2443 clock controller support" if COMPILE_TEST
 	select COMMON_CLK_SAMSUNG
 
-- 
2.5.0

[toc] | [prev] | [next] | [standalone]

#1335898

Quoting Krzysztof Kozlowski (2016-02-15 22:20:29)
> Hi,
> 
> Patchset attempts to remove the ARCH_EXYNOS7 symbol.
> 
> I rebased this on top of James':
>  - clk: Move vendor's Kconfig into CCF menu section
>    http://www.spinics.net/lists/devicetree/msg111953.html
> 
> The third patch depends on previous ones so one way of merging this
> would be to prepare a tag from clk tree with first two patches
> and the dependency. The last third patch would go through arm-soc.

I've done this locally and things look good. I'm just waiting for Acks
to patch #2 and I'll merge patches #1 and #2 and provide a stable tag
named clk-samsung-kconfig, based on v4.5-rc1.

These patches were not based on -rc1, but the fixups were trivial so I'm
fine with them.

Regards,
Mike

> 
> Changes since v4:
> =================
> 1. Rebased on "clk: Move vendor's Kconfig into CCF menu section"
>    existing in clock tree.
> 2. Re-work patch 2/3 (see specific changelog).
> 
> Changes since v3:
> =================
> 1. Rebase on next-20160127 (s3c64xx became multiplatform).
> 
> Changes since v2:
> =================
> 1. Follow Arnd's advice about not enabling silently the newly added
>    EXYNOS_ARM64_COMMON_CLK, when COMPILE_TEST is enabled. This was
>    also a trigger for some changes in placement of Samsung clocks
>    Kconfig entries...
> 2. ... which lead to introducing patch 1.
> 
> 
> Rationale:
> ==========
> We don't need ARCH_EXYNOS7 symbol because all ARMv8 platforms should
> fall under generic ARCH_EXYNOS. In the same time there is no sense
> in building clocks for these ARMv8 SoCs on ARMv7 builds.
> 
> 
> Best regards,
> Krzysztof
> 
> Krzysztof Kozlowski (3):
>   clk: samsung: Enable COMPILE_TEST for Samsung clocks
>   clk: samsung: Don't build ARMv8 clock drivers on ARMv7
>   arm64: EXYNOS: Consolidate ARCH_EXYNOS7 symbol into ARCH_EXYNOS
> 
>  arch/arm64/Kconfig.platforms        | 11 ++---------
>  arch/arm64/boot/dts/exynos/Makefile |  2 +-
>  arch/arm64/configs/defconfig        |  2 +-
>  drivers/clk/samsung/Kconfig         | 18 +++++++++++++-----
>  drivers/clk/samsung/Makefile        |  4 ++--
>  5 files changed, 19 insertions(+), 18 deletions(-)
> 
> -- 
> 2.5.0
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web