Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1334996 > unrolled thread

Re: [ANNOUNCE] 4.4.1-rt6

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [ANNOUNCE] 4.4.1-rt6 Clark Williams <williams@redhat.com> - 2016-02-16 06:00 +0100
    Re: [ANNOUNCE] 4.4.1-rt6 Clark Williams <williams@redhat.com> - 2016-02-16 20:20 +0100

#1334996 — Re: [ANNOUNCE] 4.4.1-rt6

[Multipart message — attachments visible in raw view] — view raw

On Sat, 13 Feb 2016 00:47:08 +0100
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:

> - There is a useless rcu_bh thread which has been deactivated.
> 

For some strange reason I had RCU_TORTURE_TEST defined in my config. This caused my compile to blow up because kernel/rcu/rcutorture.c wanted to test the (now ifdef'ed out) rcu_bh routines. This fixes the compile issue but is untested for actually *running* rcutorture. I'll try that on a test box tomorrow. 

Clark

From a835ff3aad772520d34548dc336925788a649b17 Mon Sep 17 00:00:00 2001
From: Clark Williams <williams@redhat.com>
Date: Mon, 15 Feb 2016 22:48:04 -0600
Subject: [PATCH] rcutorture: comment out rcu_bh ops on PREEMPT_RT_FULL

RT has dropped support of rcu_bh, comment out in rcutorture.

Signed-off-by: Clark Williams <williams@redhat.com>
---
 kernel/rcu/rcutorture.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
index d89328e260df..5bb3364a6284 100644
--- a/kernel/rcu/rcutorture.c
+++ b/kernel/rcu/rcutorture.c
@@ -390,6 +390,7 @@ static struct rcu_torture_ops rcu_ops = {
 	.name		= "rcu"
 };
 
+#ifndef CONFIG_PREEMPT_RT_FULL
 /*
  * Definitions for rcu_bh torture testing.
  */
@@ -429,6 +430,12 @@ static struct rcu_torture_ops rcu_bh_ops = {
 	.name		= "rcu_bh"
 };
 
+#else
+static struct rcu_torture_ops rcu_bh_ops = {
+	.ttype		= INVALID_RCU_FLAVOR,
+};
+#endif
+
 /*
  * Don't even think about trying any of these in real life!!!
  * The names includes "busted", and they really means it!
-- 
2.5.0

[toc] | [next] | [standalone]

#1335738

[Multipart message — attachments visible in raw view] — view raw

On Mon, 15 Feb 2016 22:53:58 -0600
Clark Williams <williams@redhat.com> wrote:

> On Sat, 13 Feb 2016 00:47:08 +0100
> Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> 
> > - There is a useless rcu_bh thread which has been deactivated.
> >   
> 
> For some strange reason I had RCU_TORTURE_TEST defined in my config. This caused my compile to blow up because kernel/rcu/rcutorture.c wanted to test the (now ifdef'ed out) rcu_bh routines. This fixes the compile issue but is untested for actually *running* rcutorture. I'll try that on a test box tomorrow. 
> 
>

Successfully ran rcutorture for 5m on my test system with no errors reported and no _bh_ threads started. 

Clark

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web