Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1333057 > unrolled thread

Re: [PATCH 3/3] i2c: iproc: Support larger TX transfer

Started byWolfram Sang <wsa@the-dreams.de>
First post2016-02-12 20:40 +0100
Last post2016-02-12 20:40 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 3/3] i2c: iproc: Support larger TX transfer Wolfram Sang <wsa@the-dreams.de> - 2016-02-12 20:40 +0100
    Re: [PATCH 3/3] i2c: iproc: Support larger TX transfer Ray Jui <ray.jui@broadcom.com> - 2016-02-12 20:40 +0100

#1333057 — Re: [PATCH 3/3] i2c: iproc: Support larger TX transfer

FromWolfram Sang <wsa@the-dreams.de>
Date2016-02-12 20:40 +0100
SubjectRe: [PATCH 3/3] i2c: iproc: Support larger TX transfer
Message-ID<r1rJn-2RI-9@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

> @@ -293,7 +360,7 @@ static const struct i2c_algorithm bcm_iproc_algo = {
>  static struct i2c_adapter_quirks bcm_iproc_i2c_quirks = {
>  	/* need to reserve one byte in the FIFO for the slave address */
>  	.max_read_len = M_TX_RX_FIFO_SIZE - 1,
> -	.max_write_len = M_TX_RX_FIFO_SIZE - 1,
> +	.max_write_len = 65535,

You can simply remove this line because len is u16 in the i2c core anyhow.

[toc] | [next] | [standalone]


#1333067

FromRay Jui <ray.jui@broadcom.com>
Date2016-02-12 20:40 +0100
Message-ID<r1rJp-2RI-53@gated-at.bofh.it>
In reply to#1333057

On 2/12/2016 11:33 AM, Wolfram Sang wrote:
>> @@ -293,7 +360,7 @@ static const struct i2c_algorithm bcm_iproc_algo = {
>>  static struct i2c_adapter_quirks bcm_iproc_i2c_quirks = {
>>  	/* need to reserve one byte in the FIFO for the slave address */
>>  	.max_read_len = M_TX_RX_FIFO_SIZE - 1,
>> -	.max_write_len = M_TX_RX_FIFO_SIZE - 1,
>> +	.max_write_len = 65535,
>
> You can simply remove this line because len is u16 in the i2c core anyhow.
>

Okay will do. Thanks!

Ray

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web