Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1332875 > unrolled thread

[PATCH 0/6] HID: wacom: cleanup

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/6] HID: wacom: cleanup Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-02-12 17:30 +0100
    [PATCH 5/6] HID: wacom: cleanup input devices Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-02-12 17:30 +0100
    Re: [PATCH 0/6] HID: wacom: cleanup Jiri Kosina <jikos@kernel.org> - 2016-02-16 18:20 +0100
    Re: [PATCH 0/6] HID: wacom: cleanup Jiri Kosina <jikos@kernel.org> - 2016-02-16 20:50 +0100

#1332875 — [PATCH 0/6] HID: wacom: cleanup

Hi,

While working on the wacom.ko driver, I ended up having those 6 patches that
the current wacom.ko could benefit right now.

Besides cleaning, the only gain users will see is in patch 6 which allows to
actually use the wireless receiver (for development) without having to
unplug/replug it.

Cheers,
Benjamin

Benjamin Tissoires (6):
  HID: wacom: break out wacom_intuos_get_tool_type
  HID: wacom: break out parsing of device and registering of input
  HID: wacom: move down wireless_work()
  HID: wacom: reuse wacom_parse_and_register() in wireless_work
  HID: wacom: cleanup input devices
  HID: wacom: close the wireless receiver on remove()

 drivers/hid/wacom_sys.c | 363 ++++++++++++++++++++++++------------------------
 drivers/hid/wacom_wac.c | 166 +++++++++++-----------
 2 files changed, 265 insertions(+), 264 deletions(-)

-- 
2.5.0

[toc] | [next] | [standalone]

#1332878 — [PATCH 5/6] HID: wacom: cleanup input devices

Just some cleaning up when the input devices are unregistered.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
 drivers/hid/wacom_sys.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
index 5cb8528..9a41035 100644
--- a/drivers/hid/wacom_sys.c
+++ b/drivers/hid/wacom_sys.c
@@ -1357,6 +1357,9 @@ static void wacom_clean_inputs(struct wacom *wacom)
 	wacom->wacom_wac.pen_input = NULL;
 	wacom->wacom_wac.touch_input = NULL;
 	wacom->wacom_wac.pad_input = NULL;
+	wacom->wacom_wac.pen_registered = false;
+	wacom->wacom_wac.touch_registered = false;
+	wacom->wacom_wac.pad_registered = false;
 	wacom_destroy_leds(wacom);
 }
 
-- 
2.5.0

[toc] | [prev] | [next] | [standalone]

#1335646

On Fri, 12 Feb 2016, Benjamin Tissoires wrote:

> While working on the wacom.ko driver, I ended up having those 6 patches that
> the current wacom.ko could benefit right now.
> 
> Besides cleaning, the only gain users will see is in patch 6 which allows to
> actually use the wireless receiver (for development) without having to
> unplug/replug it.

Looks good to me. Ping, Jason, can I please have your Ack on this?

Thanks,

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [next] | [standalone]

#1335756

On Fri, 12 Feb 2016, Benjamin Tissoires wrote:

> While working on the wacom.ko driver, I ended up having those 6 patches that
> the current wacom.ko could benefit right now.
> 
> Besides cleaning, the only gain users will see is in patch 6 which allows to
> actually use the wireless receiver (for development) without having to
> unplug/replug it.

Applied to for-4.6/wacom. Thanks,

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web