Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1332740 > unrolled thread

Re: [PATCH V2] regulator: max8973: add support for junction thermal warning

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH V2] regulator: max8973: add support for junction thermal warning Rob Herring <robh+dt@kernel.org> - 2016-02-12 14:40 +0100
    Re: [PATCH V2] regulator: max8973: add support for junction thermal  warning Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-12 14:50 +0100
      Re: [PATCH V2] regulator: max8973: add support for junction thermal warning Rob Herring <robh+dt@kernel.org> - 2016-02-12 15:10 +0100

#1332740 — Re: [PATCH V2] regulator: max8973: add support for junction thermal warning

On Wed, Jan 6, 2016 at 10:07 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
> The driver MAX8973 supports the driver for Maxim PMIC MAX77621.
> MAX77621 supports the  junction temp warning at 120 degC and
> 140 degC which is configurable. It generates alert signal when
> junction temperature crosses these threshold.

Sorry, this one fell thru the cracks.

> MAX77621 does not support the continuous temp monitoring of
> junction temperature. It just report whether junction temperature
> crossed the threshold or not.
>
> Add support to
> - Configure junction temp warning threshold via DT property
>   to generate alert when it crosses the threshold.
> - Add support to interrupt the host from this device when alert
>   occurred.
> - read the junction temp via thermal framework.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
> Changes from v1:
> - Remove irq flags from DT
> - More details about supported temp by MAX77621
>
>  .../bindings/regulator/max8973-regulator.txt       |   5 +
>  drivers/regulator/max8973-regulator.c              | 140 ++++++++++++++++++++-
>  include/linux/regulator/max8973-regulator.h        |   4 +
>  3 files changed, 147 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/max8973-regulator.txt b/Documentation/devicetree/bindings/regulator/max8973-regulator.txt
> index f80ea2f..93f9939 100644
> --- a/Documentation/devicetree/bindings/regulator/max8973-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/max8973-regulator.txt
> @@ -31,6 +31,11 @@ Optional properties:
>                 property is available then etr will be enable default.
>
>  Enhanced transient response (ETR) will affect the configuration of CKADV.
> +-maxim,junction-temp-warning: Junction temp warning on which device generates
> +               warning interrupts. This is in millicelcius.

Please append units: maxim,junction-temp-warning-millicelsius or
perhaps maxim,junction-warn-millicelsius to shorten it a bit.

> +
> +Please note that thermal functionality is only supported on MAX77621. The
> +threshold warning supported by MAX77621 are 120 degC and 140 degC.
>
>  Example:
>

[toc] | [next] | [standalone]

#1332745 — Re: [PATCH V2] regulator: max8973: add support for junction thermal warning

On Friday 12 February 2016 07:06 PM, Rob Herring wrote:
> On Wed, Jan 6, 2016 at 10:07 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
>   Enhanced transient response (ETR) will affect the configuration of CKADV.
> +-maxim,junction-temp-warning: Junction temp warning on which device generates
> +               warning interrupts. This is in millicelcius.
> Please append units: maxim,junction-temp-warning-millicelsius or
> perhaps maxim,junction-warn-millicelsius to shorten it a bit.
This is very generic which is there on most of PMIC devices from Maxim,  
TI etc.
So can we make it generic i.e. do not prefix with vendor name like 
"junction-warn-millicelsius"?

[toc] | [prev] | [next] | [standalone]

#1332764

On Fri, Feb 12, 2016 at 7:31 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
> On Friday 12 February 2016 07:06 PM, Rob Herring wrote:
>>
>> On Wed, Jan 6, 2016 at 10:07 AM, Laxman Dewangan <ldewangan@nvidia.com>
>> wrote:
>>
>>   Enhanced transient response (ETR) will affect the configuration of
>> CKADV.
>> +-maxim,junction-temp-warning: Junction temp warning on which device
>> generates
>> +               warning interrupts. This is in millicelcius.
>> Please append units: maxim,junction-temp-warning-millicelsius or
>> perhaps maxim,junction-warn-millicelsius to shorten it a bit.
>
> This is very generic which is there on most of PMIC devices from Maxim,  TI
> etc.
> So can we make it generic i.e. do not prefix with vendor name like
> "junction-warn-millicelsius"?

I've got no problem with that.

Rob

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web