Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1332546 > unrolled thread
| Started by | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| First post | 2016-02-12 07:50 +0100 |
| Last post | 2016-02-12 07:50 +0100 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
[patch 1/2] misc: mic: use after free printing error message Dan Carpenter <dan.carpenter@oracle.com> - 2016-02-12 07:50 +0100
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2016-02-12 07:50 +0100 |
| Subject | [patch 1/2] misc: mic: use after free printing error message |
| Message-ID | <r1fId-3jp-3@gated-at.bofh.it> |
Swap the printk and kfree() to avoid a use after free bug.
Fixes: 61e9c905df78 ('misc: mic: Enable VOP host side functionality')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/misc/mic/vop/vop_vringh.c b/drivers/misc/mic/vop/vop_vringh.c
index c1dd000..c3613f3 100644
--- a/drivers/misc/mic/vop/vop_vringh.c
+++ b/drivers/misc/mic/vop/vop_vringh.c
@@ -290,9 +290,9 @@ static int vop_virtio_add_device(struct vop_vdev *vdev,
ret = vop_copy_dp_entry(vdev, argp, &type, &dd);
if (ret) {
- kfree(vdev);
dev_err(vop_dev(vdev), "%s %d err %d\n",
__func__, __LINE__, ret);
+ kfree(vdev);
return ret;
}
Back to top | Article view | linux.kernel
csiph-web