Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1333286 > unrolled thread

[PATCH] midi: avoid freeing umidi object twice

Back to article view | Back to linux.kernel

Contents

  [PATCH] midi: avoid freeing umidi object twice Andrey Konovalov <andreyknvl@gmail.com> - 2016-02-13 09:10 +0100
    Re: [PATCH] midi: avoid freeing umidi object twice Takashi Iwai <tiwai@suse.de> - 2016-02-13 09:50 +0100

#1333286 — [PATCH] midi: avoid freeing umidi object twice

The 'umidi' object will be free'd on the error path by snd_usbmidi_free()
when tearing down the rawmidi interface. So we shouldn't try to free it
in snd_usbmidi_create() after having registered the rawmidi interface.

Found by KASAN.

Acked-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Andrey Konovalov <andreyknvl@gmail.com>
---
 sound/usb/midi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/usb/midi.c b/sound/usb/midi.c
index cc39f63..007cf58 100644
--- a/sound/usb/midi.c
+++ b/sound/usb/midi.c
@@ -2455,7 +2455,6 @@ int snd_usbmidi_create(struct snd_card *card,
 	else
 		err = snd_usbmidi_create_endpoints(umidi, endpoints);
 	if (err < 0) {
-		snd_usbmidi_free(umidi);
 		return err;
 	}
 
-- 
1.9.1

[toc] | [next] | [standalone]

#1333289

On Sat, 13 Feb 2016 09:08:06 +0100,
Andrey Konovalov wrote:
> 
> The 'umidi' object will be free'd on the error path by snd_usbmidi_free()
> when tearing down the rawmidi interface. So we shouldn't try to free it
> in snd_usbmidi_create() after having registered the rawmidi interface.
> 
> Found by KASAN.
> 
> Acked-by: Clemens Ladisch <clemens@ladisch.de>
> Signed-off-by: Andrey Konovalov <andreyknvl@gmail.com>

Thanks, applied now with Cc to stable.


Takashi

> ---
>  sound/usb/midi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/usb/midi.c b/sound/usb/midi.c
> index cc39f63..007cf58 100644
> --- a/sound/usb/midi.c
> +++ b/sound/usb/midi.c
> @@ -2455,7 +2455,6 @@ int snd_usbmidi_create(struct snd_card *card,
>  	else
>  		err = snd_usbmidi_create_endpoints(umidi, endpoints);
>  	if (err < 0) {
> -		snd_usbmidi_free(umidi);
>  		return err;
>  	}
>  
> -- 
> 1.9.1
> 
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web