Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1330130 > unrolled thread
| Started by | Taeung Song <treeze.taeung@gmail.com> |
|---|---|
| First post | 2016-02-09 13:00 +0100 |
| Last post | 2016-02-16 09:00 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] perf python scripting: Append examples to err msg about audit-libs-python Taeung Song <treeze.taeung@gmail.com> - 2016-02-09 13:00 +0100
Re: [PATCH] perf python scripting: Append examples to err msg about audit-libs-python Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-12 00:00 +0100
Re: [PATCH] perf python scripting: Append examples to err msg about audit-libs-python Taeung Song <treeze.taeung@gmail.com> - 2016-02-12 01:10 +0100
[tip:perf/core] perf python scripting: Append examples to err msg about audit-libs-python tip-bot for Taeung Song <tipbot@zytor.com> - 2016-02-16 09:00 +0100
| From | Taeung Song <treeze.taeung@gmail.com> |
|---|---|
| Date | 2016-02-09 13:00 +0100 |
| Subject | [PATCH] perf python scripting: Append examples to err msg about audit-libs-python |
| Message-ID | <r0f7z-3uX-1@gated-at.bofh.it> |
To print the syscall name, the audit-libs-python package
should be required. If not installed, print
the erron string e.g.
# perf script syscall-counts
Install the audit-libs-python package to get syscall names.
But the package name is different in Ubuntu
so append examples the erron string like below.
(similar to a error message of util/trace-event-scripting.c)
# perf script syscall-counts
Install the audit-libs-python package to get syscall names.
For example:
# apt-get install python-audit (Ubuntu)
# yum install audit-libs-python (Fedora)
etc.
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py b/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py
index 15c8400..1d95009 100644
--- a/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py
+++ b/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py
@@ -71,7 +71,10 @@ try:
except:
if not audit_package_warned:
audit_package_warned = True
- print "Install the audit-libs-python package to get syscall names"
+ print "Install the audit-libs-python package to get syscall names.\n" \
+ "For example:\n # apt-get install python-audit (Ubuntu)" \
+ "\n # yum install audit-libs-python (Fedora)" \
+ "\n etc.\n"
def syscall_name(id):
try:
--
2.5.0
[toc] | [next] | [standalone]
| From | Arnaldo Carvalho de Melo <acme@kernel.org> |
|---|---|
| Date | 2016-02-12 00:00 +0100 |
| Subject | Re: [PATCH] perf python scripting: Append examples to err msg about audit-libs-python |
| Message-ID | <r18np-6Ne-21@gated-at.bofh.it> |
| In reply to | #1330130 |
Em Tue, Feb 09, 2016 at 08:53:10PM +0900, Taeung Song escreveu: > To print the syscall name, the audit-libs-python package > should be required. If not installed, print > the erron string e.g. After fixing spelling mistakes, applied, thanks, - Arnaldo > > # perf script syscall-counts > Install the audit-libs-python package to get syscall names. > > But the package name is different in Ubuntu > so append examples the erron string like below. > (similar to a error message of util/trace-event-scripting.c) > > # perf script syscall-counts > Install the audit-libs-python package to get syscall names. > For example: > # apt-get install python-audit (Ubuntu) > # yum install audit-libs-python (Fedora) > etc. > > Signed-off-by: Taeung Song <treeze.taeung@gmail.com> > --- > tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py b/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py > index 15c8400..1d95009 100644 > --- a/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py > +++ b/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py > @@ -71,7 +71,10 @@ try: > except: > if not audit_package_warned: > audit_package_warned = True > - print "Install the audit-libs-python package to get syscall names" > + print "Install the audit-libs-python package to get syscall names.\n" \ > + "For example:\n # apt-get install python-audit (Ubuntu)" \ > + "\n # yum install audit-libs-python (Fedora)" \ > + "\n etc.\n" > > def syscall_name(id): > try: > -- > 2.5.0
[toc] | [prev] | [next] | [standalone]
| From | Taeung Song <treeze.taeung@gmail.com> |
|---|---|
| Date | 2016-02-12 01:10 +0100 |
| Subject | Re: [PATCH] perf python scripting: Append examples to err msg about audit-libs-python |
| Message-ID | <r19t7-7Ft-9@gated-at.bofh.it> |
| In reply to | #1332424 |
Hi, Arnaldo On 02/12/2016 07:20 AM, Arnaldo Carvalho de Melo wrote: > Em Tue, Feb 09, 2016 at 08:53:10PM +0900, Taeung Song escreveu: >> To print the syscall name, the audit-libs-python package >> should be required. If not installed, print >> the erron string e.g. > > After fixing spelling mistakes, applied, thanks, > > - Arnaldo Thank you !! :) Taeung
[toc] | [prev] | [next] | [standalone]
| From | tip-bot for Taeung Song <tipbot@zytor.com> |
|---|---|
| Date | 2016-02-16 09:00 +0100 |
| Subject | [tip:perf/core] perf python scripting: Append examples to err msg about audit-libs-python |
| Message-ID | <r2IIa-4OP-9@gated-at.bofh.it> |
| In reply to | #1330130 |
Commit-ID: b416e204f88dd91d9e99f6deee3d57fbc90aee40
Gitweb: http://git.kernel.org/tip/b416e204f88dd91d9e99f6deee3d57fbc90aee40
Author: Taeung Song <treeze.taeung@gmail.com>
AuthorDate: Tue, 9 Feb 2016 20:53:10 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 12 Feb 2016 11:30:27 -0300
perf python scripting: Append examples to err msg about audit-libs-python
To print syscall names, the audit-libs-python package is required.. If
not installed, it prints this error string:
# perf script syscall-counts
Install the audit-libs-python package to get syscall names.
But the package name is different in Ubuntu, mention that in the error
message, similar to a error message of util/trace-event-scripting.c:
# perf script syscall-counts
Install the audit-libs-python package to get syscall names.
For example:
# apt-get install python-audit (Ubuntu)
# yum install audit-libs-python (Fedora)
etc.
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1455018790-13425-1-git-send-email-treeze.taeung@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py b/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py
index 15c8400..1d95009 100644
--- a/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py
+++ b/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py
@@ -71,7 +71,10 @@ try:
except:
if not audit_package_warned:
audit_package_warned = True
- print "Install the audit-libs-python package to get syscall names"
+ print "Install the audit-libs-python package to get syscall names.\n" \
+ "For example:\n # apt-get install python-audit (Ubuntu)" \
+ "\n # yum install audit-libs-python (Fedora)" \
+ "\n etc.\n"
def syscall_name(id):
try:
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web