Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1330302 > unrolled thread

Re: [PATCH V2 03/12] dtb: amd: Fix DMA ranges in device tree

Started byArnd Bergmann <arnd@arndb.de>
First post2016-02-09 16:00 +0100
Last post2016-02-11 22:30 +0100
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH V2 03/12] dtb: amd: Fix DMA ranges in device tree Arnd Bergmann <arnd@arndb.de> - 2016-02-09 16:00 +0100
    Re: [PATCH V2 03/12] dtb: amd: Fix DMA ranges in device tree Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> - 2016-02-10 22:20 +0100
      Re: [PATCH V2 03/12] dtb: amd: Fix DMA ranges in device tree Arnd Bergmann <arnd@arndb.de> - 2016-02-10 22:30 +0100
      Re: [PATCH V2 03/12] dtb: amd: Fix DMA ranges in device tree Olof Johansson <olof@lixom.net> - 2016-02-11 22:30 +0100

#1330302 — Re: [PATCH V2 03/12] dtb: amd: Fix DMA ranges in device tree

FromArnd Bergmann <arnd@arndb.de>
Date2016-02-09 16:00 +0100
SubjectRe: [PATCH V2 03/12] dtb: amd: Fix DMA ranges in device tree
Message-ID<r0hVN-5pW-19@gated-at.bofh.it>
On Monday 08 February 2016 11:59:08 Suravee Suthikulpanit wrote:
> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> 
> Fix DMA ranges of smb0 and pcie0 nodes in AMD Seattle SOC.
> 
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> 

This could use a changelog text to explain why it's broken and how the
fix works.

	Arnd

[toc] | [next] | [standalone]


#1331490

FromSuravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
Date2016-02-10 22:20 +0100
Message-ID<r0Kl4-7CM-11@gated-at.bofh.it>
In reply to#1330302
Hi Arnd,

On 2/9/16 21:57, Arnd Bergmann wrote:
> On Monday 08 February 2016 11:59:08 Suravee Suthikulpanit wrote:
>> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>>
>> Fix DMA ranges of smb0 and pcie0 nodes in AMD Seattle SOC.
>>
>> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>>
>
> This could use a changelog text to explain why it's broken and how the
> fix works.
>
> 	Arnd
>

So, I have not experience the breakage. However, IIUC, the GICv2m MSI 
frame is also considered DMA-able. So, I think it should be included in 
the dma-range specified here. Please let me know if my assumption is 
incorrect. Otherwise, I will include more description in the commit log 
in my next rev.

Thanks,
Suravee

[toc] | [prev] | [next] | [standalone]


#1331493

FromArnd Bergmann <arnd@arndb.de>
Date2016-02-10 22:30 +0100
Message-ID<r0KuK-7H1-11@gated-at.bofh.it>
In reply to#1331490
On Thursday 11 February 2016 04:13:50 Suravee Suthikulpanit wrote:
> 
> On 2/9/16 21:57, Arnd Bergmann wrote:
> > On Monday 08 February 2016 11:59:08 Suravee Suthikulpanit wrote:
> >> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> >>
> >> Fix DMA ranges of smb0 and pcie0 nodes in AMD Seattle SOC.
> >>
> >> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> >>
> >
> > This could use a changelog text to explain why it's broken and how the
> > fix works.
> >
> >       Arnd
> >
> 
> So, I have not experience the breakage. However, IIUC, the GICv2m MSI 
> frame is also considered DMA-able. So, I think it should be included in 
> the dma-range specified here. Please let me know if my assumption is 
> incorrect. Otherwise, I will include more description in the commit log 
> in my next rev.

No, I think this makes sense. Just put a more explanation into the changelog
when those things are not obvious from looking at the change.

	Arnd

[toc] | [prev] | [next] | [standalone]


#1332383

FromOlof Johansson <olof@lixom.net>
Date2016-02-11 22:30 +0100
Message-ID<r16Yj-5Zm-27@gated-at.bofh.it>
In reply to#1331490
Hi,

On Wed, Feb 10, 2016 at 1:13 PM, Suravee Suthikulpanit
<Suravee.Suthikulpanit@amd.com> wrote:
> Hi Arnd,
>
>
> On 2/9/16 21:57, Arnd Bergmann wrote:
>>
>> On Monday 08 February 2016 11:59:08 Suravee Suthikulpanit wrote:
>>>
>>> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>>>
>>> Fix DMA ranges of smb0 and pcie0 nodes in AMD Seattle SOC.
>>>
>>> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>>>
>>
>> This could use a changelog text to explain why it's broken and how the
>> fix works.
>>
>>         Arnd
>>
>
> So, I have not experience the breakage. However, IIUC, the GICv2m MSI frame
> is also considered DMA-able. So, I think it should be included in the
> dma-range specified here. Please let me know if my assumption is incorrect.
> Otherwise, I will include more description in the commit log in my next rev.

As I replied when I did it -- I've applied the patches, so respinning
won't work. Instead, please follow up with incremental fixes to this
series instead.


Thanks,

-Olof

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web