Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1332183 > unrolled thread
| Started by | Joshua Henderson <joshua.henderson@microchip.com> |
|---|---|
| First post | 2016-02-11 17:00 +0100 |
| Last post | 2016-02-11 18:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v3 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine Joshua Henderson <joshua.henderson@microchip.com> - 2016-02-11 17:00 +0100
Re: [PATCH v3 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-02-11 18:50 +0100
| From | Joshua Henderson <joshua.henderson@microchip.com> |
|---|---|
| Date | 2016-02-11 17:00 +0100 |
| Subject | [PATCH v3 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine |
| Message-ID | <r11OW-2po-33@gated-at.bofh.it> |
From: Cristian Birsan <cristian.birsan@microchip.com>
Commit 754fe4a92c07 ("usb: musb: Remove ifdefs for TX DMA for musb_host.c")
introduces a problem setting the desired channel mode for the Mentor DMA
engine.
There is a case where an address is incorrectly assigned to the DMA
channel desired mode when it should instead be assigned the actual mode
value. This results in the value of channel->desired_mode not being
correct.
Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
---
Changes since v2:
- Fix wording in commit message.
Changes since v1:
- Fix commit comment citing the cause of the regression.
---
drivers/usb/musb/musb_host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index 6a81066..0803061 100644
--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
@@ -662,7 +662,7 @@ static int musb_tx_dma_set_mode_mentor(struct dma_controller *dma,
csr &= ~(MUSB_TXCSR_AUTOSET | MUSB_TXCSR_DMAMODE);
csr |= MUSB_TXCSR_DMAENAB; /* against programmer's guide */
}
- channel->desired_mode = mode;
+ channel->desired_mode = *mode;
musb_writew(epio, MUSB_TXCSR, csr);
return 0;
--
1.7.9.5
[toc] | [next] | [standalone]
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2016-02-11 18:50 +0100 |
| Subject | Re: [PATCH v3 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine |
| Message-ID | <r13xn-3yp-5@gated-at.bofh.it> |
| In reply to | #1332183 |
On 02/11/2016 06:58 PM, Joshua Henderson wrote:
> From: Cristian Birsan <cristian.birsan@microchip.com>
>
> Commit 754fe4a92c07 ("usb: musb: Remove ifdefs for TX DMA for musb_host.c")
> introduces a problem setting the desired channel mode for the Mentor DMA
> engine.
>
> There is a case where an address is incorrectly assigned to the DMA
> channel desired mode when it should instead be assigned the actual mode
> value. This results in the value of channel->desired_mode not being
> correct.
>
> Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
> Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
MBR, Sergei
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web