Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1331695 > unrolled thread

[PATCH RESEND] scsi: sim710: fix build warning

Back to article view | Back to linux.kernel

Contents

  [PATCH RESEND] scsi: sim710: fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-11 06:00 +0100
    Re: [PATCH RESEND] scsi: sim710: fix build warning Johannes Thumshirn <jthumshirn@suse.de> - 2016-02-11 09:50 +0100
    Re: [PATCH RESEND] scsi: sim710: fix build warning "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-02-11 15:40 +0100

#1331695 — [PATCH RESEND] scsi: sim710: fix build warning

We are getting build warning about:
 "Section mismatch in reference from the variable sim710_eisa_driver to
 the function .init.text:sim710_eisa_probe()
 The variable sim710_eisa_driver references the function __init
 sim710_eisa_probe()"

sim710_eisa_probe() was having __init but that was being referenced from
sim710_eisa_driver.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---

patch first sent on 4th Sept.2015. There is no review or ACK yet.
warning is still there with next-20160209,
build log is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/107948115

 drivers/scsi/sim710.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/sim710.c b/drivers/scsi/sim710.c
index 3b3b56f..82ed998 100644
--- a/drivers/scsi/sim710.c
+++ b/drivers/scsi/sim710.c
@@ -176,8 +176,7 @@ static struct eisa_device_id sim710_eisa_ids[] = {
 };
 MODULE_DEVICE_TABLE(eisa, sim710_eisa_ids);
 
-static __init int
-sim710_eisa_probe(struct device *dev)
+static int sim710_eisa_probe(struct device *dev)
 {
 	struct eisa_device *edev = to_eisa_device(dev);
 	unsigned long io_addr = edev->base_addr;
-- 
1.9.1

[toc] | [next] | [standalone]

#1331735

On Thu, Feb 11, 2016 at 10:29:03AM +0530, Sudip Mukherjee wrote:
> We are getting build warning about:
>  "Section mismatch in reference from the variable sim710_eisa_driver to
>  the function .init.text:sim710_eisa_probe()
>  The variable sim710_eisa_driver references the function __init
>  sim710_eisa_probe()"
> 
> sim710_eisa_probe() was having __init but that was being referenced from
> sim710_eisa_driver.
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[toc] | [prev] | [next] | [standalone]

#1332093

>>>>> "Sudip" == Sudip Mukherjee <sudipm.mukherjee@gmail.com> writes:

Sudip> We are getting build warning about: "Section mismatch in
Sudip> reference from the variable sim710_eisa_driver to the function
Sudip> .init.text:sim710_eisa_probe() The variable sim710_eisa_driver
Sudip> references the function __init sim710_eisa_probe()"

Sudip> sim710_eisa_probe() was having __init but that was being
Sudip> referenced from sim710_eisa_driver.

Applied to 4.6/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web