Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1330973 > unrolled thread

[PATCH] Input: colibri-vf50-ts: fix implicit declaration

Back to article view | Back to linux.kernel

Contents

  [PATCH] Input: colibri-vf50-ts: fix implicit declaration Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-10 10:50 +0100
    Re: [PATCH] Input: colibri-vf50-ts: fix implicit declaration Geert Uytterhoeven <geert@linux-m68k.org> - 2016-02-10 11:00 +0100
      Re: [PATCH] Input: colibri-vf50-ts: fix implicit declaration Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-10 11:10 +0100

#1330973 — [PATCH] Input: colibri-vf50-ts: fix implicit declaration

The build of m32r allmodconfig fails with the error:
drivers/input/touchscreen/colibri-vf50-ts.c:302:10: error: implicit
	declaration of function 'of_property_read_u32'

of_property_read_u32() is defined in linux/of.h which was not included.	

Fixes: 1261d013daea ("Input: Allow compile test of Goodix and Colibri VF50 if !GPIOLIB")
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/input/touchscreen/colibri-vf50-ts.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/touchscreen/colibri-vf50-ts.c b/drivers/input/touchscreen/colibri-vf50-ts.c
index 5d4903a..594c096 100644
--- a/drivers/input/touchscreen/colibri-vf50-ts.c
+++ b/drivers/input/touchscreen/colibri-vf50-ts.c
@@ -25,6 +25,7 @@
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/types.h>
+#include <linux/of.h>
 
 #define DRIVER_NAME			"colibri-vf50-ts"
 #define DRV_VERSION			"1.0"
-- 
1.9.1

[toc] | [next] | [standalone]

#1330988

On Wed, Feb 10, 2016 at 10:45 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> The build of m32r allmodconfig fails with the error:
> drivers/input/touchscreen/colibri-vf50-ts.c:302:10: error: implicit
>         declaration of function 'of_property_read_u32'
>
> of_property_read_u32() is defined in linux/of.h which was not included.
>
> Fixes: 1261d013daea ("Input: Allow compile test of Goodix and Colibri VF50 if !GPIOLIB")

Actually I had sent the exact same patch to add this missing include,
to apply before 1261d013daea, but it seems Dmitry only applied the
second one.

http://permalink.gmane.org/gmane.linux.kernel.gpio/14086

> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>  drivers/input/touchscreen/colibri-vf50-ts.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/colibri-vf50-ts.c b/drivers/input/touchscreen/colibri-vf50-ts.c
> index 5d4903a..594c096 100644
> --- a/drivers/input/touchscreen/colibri-vf50-ts.c
> +++ b/drivers/input/touchscreen/colibri-vf50-ts.c
> @@ -25,6 +25,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
>  #include <linux/types.h>
> +#include <linux/of.h>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[toc] | [prev] | [next] | [standalone]

#1330995

On Wed, Feb 10, 2016 at 10:54:45AM +0100, Geert Uytterhoeven wrote:
> On Wed, Feb 10, 2016 at 10:45 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > The build of m32r allmodconfig fails with the error:
> > drivers/input/touchscreen/colibri-vf50-ts.c:302:10: error: implicit
> >         declaration of function 'of_property_read_u32'
> >
> > of_property_read_u32() is defined in linux/of.h which was not included.
> >
> > Fixes: 1261d013daea ("Input: Allow compile test of Goodix and Colibri VF50 if !GPIOLIB")
> 
> Actually I had sent the exact same patch to add this missing include,
> to apply before 1261d013daea, but it seems Dmitry only applied the
> second one.
> 
> http://permalink.gmane.org/gmane.linux.kernel.gpio/14086

apart from m32r it also affects tilegx, s390, m68k allmodconfig.
I hope Dmitry applies any one from your or mine patch today.

regards
sudip

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web