Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1330217 > unrolled thread
| Started by | Christoph Hellwig <hch@lst.de> |
|---|---|
| First post | 2016-02-09 14:00 +0100 |
| Last post | 2016-02-09 16:40 +0100 |
| Articles | 7 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional Christoph Hellwig <hch@lst.de> - 2016-02-09 14:00 +0100
Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional Jens Axboe <axboe@kernel.dk> - 2016-02-09 14:30 +0100
Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional Christoph Hellwig <hch@lst.de> - 2016-02-09 18:20 +0100
Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional Jens Axboe <axboe@kernel.dk> - 2016-02-09 18:30 +0100
Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional Jens Axboe <axboe@kernel.dk> - 2016-02-09 18:20 +0100
Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional Christoph Hellwig <hch@lst.de> - 2016-02-09 18:20 +0100
Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-02-09 16:40 +0100
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Date | 2016-02-09 14:00 +0100 |
| Subject | Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional |
| Message-ID | <r0g3F-48r-17@gated-at.bofh.it> |
Jens, do you want a 'default y' patch or just a better description? I'd be happy to send either one.
[toc] | [next] | [standalone]
| From | Jens Axboe <axboe@kernel.dk> |
|---|---|
| Date | 2016-02-09 14:30 +0100 |
| Subject | Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional |
| Message-ID | <r0gwG-4Ai-19@gated-at.bofh.it> |
| In reply to | #1330217 |
On Feb 9, 2016, at 5:50 AM, Christoph Hellwig <hch@lst.de> wrote: > > Jens, > > do you want a 'default y' patch or just a better description? I'd be > happy to send either one. A better description -- Jens Axboe
[toc] | [prev] | [next] | [standalone]
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Date | 2016-02-09 18:20 +0100 |
| Message-ID | <r0k7f-7b0-9@gated-at.bofh.it> |
| In reply to | #1330228 |
Updated version below: --- From d63251560cf2670badbc86c83502502f29c087e0 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig <hch@lst.de> Date: Tue, 9 Feb 2016 18:11:32 +0100 Subject: nvme: fix Kconfig description for BLK_DEV_NVME_SCSI Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/nvme/host/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig index 59307f8..68fa858 100644 --- a/drivers/nvme/host/Kconfig +++ b/drivers/nvme/host/Kconfig @@ -17,8 +17,9 @@ config BLK_DEV_NVME_SCSI and block devices nodes, as well a a translation for a small number of selected SCSI commands to NVMe commands to the NVMe driver. If you don't know what this means you probably want - to say N here, and if you know what it means you probably - want to say N as well. + to say N here, unless you run a distro that abuses the SCSI + emulation to provide stable device names for mount by id like + some OpenSuSE and SLES versions. config NVME_FABRICS tristate -- 2.1.4
[toc] | [prev] | [next] | [standalone]
| From | Jens Axboe <axboe@kernel.dk> |
|---|---|
| Date | 2016-02-09 18:30 +0100 |
| Message-ID | <r0kgX-7eu-29@gated-at.bofh.it> |
| In reply to | #1330496 |
On 02/09/2016 10:19 AM, Christoph Hellwig wrote: > Updated version below: > > --- > From d63251560cf2670badbc86c83502502f29c087e0 Mon Sep 17 00:00:00 2001 > From: Christoph Hellwig <hch@lst.de> > Date: Tue, 9 Feb 2016 18:11:32 +0100 > Subject: nvme: fix Kconfig description for BLK_DEV_NVME_SCSI > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > drivers/nvme/host/Kconfig | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig > index 59307f8..68fa858 100644 > --- a/drivers/nvme/host/Kconfig > +++ b/drivers/nvme/host/Kconfig > @@ -17,8 +17,9 @@ config BLK_DEV_NVME_SCSI > and block devices nodes, as well a a translation for a small > number of selected SCSI commands to NVMe commands to the NVMe > driver. If you don't know what this means you probably want > - to say N here, and if you know what it means you probably > - want to say N as well. > + to say N here, unless you run a distro that abuses the SCSI > + emulation to provide stable device names for mount by id like > + some OpenSuSE and SLES versions. Thanks, looks good to me, I'll fold it in for the current series. -- Jens Axboe
[toc] | [prev] | [next] | [standalone]
| From | Jens Axboe <axboe@kernel.dk> |
|---|---|
| Date | 2016-02-09 18:20 +0100 |
| Message-ID | <r0k7f-7b0-13@gated-at.bofh.it> |
| In reply to | #1330228 |
On 02/09/2016 10:12 AM, Christoph Hellwig wrote: > Does this looks reasonable? > > --- > From 7843fae979df3fc14007735f54cc6bb2f6f66dc5 Mon Sep 17 00:00:00 2001 > From: Christoph Hellwig <hch@lst.de> > Date: Tue, 9 Feb 2016 18:11:32 +0100 > Subject: nvme: fix Kconfig description for BLK_DEV_NVME_SCSI > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > drivers/nvme/host/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig > index 59307f8..2e24156 100644 > --- a/drivers/nvme/host/Kconfig > +++ b/drivers/nvme/host/Kconfig > @@ -17,8 +17,8 @@ config BLK_DEV_NVME_SCSI > and block devices nodes, as well a a translation for a small > number of selected SCSI commands to NVMe commands to the NVMe > driver. If you don't know what this means you probably want > - to say N here, and if you know what it means you probably > - want to say N as well. > + to say N here, unless you run a distro that abuses this for > + stable device names like some OpenSuSE and SLES versions. Yep, that looks a lot more reasonable to me. Might be wort including that it impacts the mount-by-id on those distros. -- Jens Axboe
[toc] | [prev] | [next] | [standalone]
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Date | 2016-02-09 18:20 +0100 |
| Message-ID | <r0k7f-7b0-11@gated-at.bofh.it> |
| In reply to | #1330228 |
Does this looks reasonable? --- From 7843fae979df3fc14007735f54cc6bb2f6f66dc5 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig <hch@lst.de> Date: Tue, 9 Feb 2016 18:11:32 +0100 Subject: nvme: fix Kconfig description for BLK_DEV_NVME_SCSI Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/nvme/host/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig index 59307f8..2e24156 100644 --- a/drivers/nvme/host/Kconfig +++ b/drivers/nvme/host/Kconfig @@ -17,8 +17,8 @@ config BLK_DEV_NVME_SCSI and block devices nodes, as well a a translation for a small number of selected SCSI commands to NVMe commands to the NVMe driver. If you don't know what this means you probably want - to say N here, and if you know what it means you probably - want to say N as well. + to say N here, unless you run a distro that abuses this for + stable device names like some OpenSuSE and SLES versions. config NVME_FABRICS tristate -- 2.1.4
[toc] | [prev] | [next] | [standalone]
| From | James Bottomley <James.Bottomley@HansenPartnership.com> |
|---|---|
| Date | 2016-02-09 16:40 +0100 |
| Message-ID | <r0iyz-5W6-203@gated-at.bofh.it> |
| In reply to | #1330217 |
On Tue, 2016-02-09 at 13:50 +0100, Christoph Hellwig wrote: > Jens, > > do you want a 'default y' patch or just a better description? I'd be > happy to send either one. Since it only appears to be SUSE and they've now been told, better description is fine. James
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web