Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1330103 > unrolled thread

[patch] dm: check for kmalloc failure in dm_init_request_based_blk_mq_queue()

Back to article view | Back to linux.kernel

Contents

  [patch] dm: check for kmalloc failure in  dm_init_request_based_blk_mq_queue() Dan Carpenter <dan.carpenter@oracle.com> - 2016-02-09 12:20 +0100
    Re: [dm-devel] [patch] dm: check for kmalloc failure in  dm_init_request_based_blk_mq_queue() Johannes Thumshirn <jthumshirn@suse.de> - 2016-02-09 12:40 +0100
    Re: dm: check for kmalloc failure in  dm_init_request_based_blk_mq_queue() Mike Snitzer <snitzer@redhat.com> - 2016-02-09 16:10 +0100

#1330103 — [patch] dm: check for kmalloc failure in dm_init_request_based_blk_mq_queue()

We can just return -ENOMEM if the kzalloc() fails.

Fixes: 41b2facaf4ba ('dm: allocate blk_mq_tag_set rather than embed in mapped_device')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 6b7e80e..1a5f879 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -2736,6 +2736,8 @@ static int dm_init_request_based_blk_mq_queue(struct mapped_device *md,
 	int err;
 
 	md->tag_set = kzalloc(sizeof(struct blk_mq_tag_set), GFP_KERNEL);
+	if (!md->tag_set)
+		return -ENOMEM;
 	md->tag_set->ops = &dm_mq_ops;
 	md->tag_set->queue_depth = dm_get_blk_mq_queue_depth();
 	md->tag_set->numa_node = NUMA_NO_NODE;

[toc] | [next] | [standalone]

#1330118 — Re: [dm-devel] [patch] dm: check for kmalloc failure in dm_init_request_based_blk_mq_queue()

On Tue, Feb 09, 2016 at 02:14:40PM +0300, Dan Carpenter wrote:
> We can just return -ENOMEM if the kzalloc() fails.
> 
> Fixes: 41b2facaf4ba ('dm: allocate blk_mq_tag_set rather than embed in mapped_device')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/md/dm.c b/drivers/md/dm.c
> index 6b7e80e..1a5f879 100644
> --- a/drivers/md/dm.c
> +++ b/drivers/md/dm.c
> @@ -2736,6 +2736,8 @@ static int dm_init_request_based_blk_mq_queue(struct mapped_device *md,
>  	int err;
>  
>  	md->tag_set = kzalloc(sizeof(struct blk_mq_tag_set), GFP_KERNEL);
> +	if (!md->tag_set)
> +		return -ENOMEM;
>  	md->tag_set->ops = &dm_mq_ops;
>  	md->tag_set->queue_depth = dm_get_blk_mq_queue_depth();
>  	md->tag_set->numa_node = NUMA_NO_NODE;
> 
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

Good catch,

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[toc] | [prev] | [next] | [standalone]

#1330320 — Re: dm: check for kmalloc failure in dm_init_request_based_blk_mq_queue()

On Tue, Feb 09 2016 at  6:14am -0500,
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> We can just return -ENOMEM if the kzalloc() fails.
> 
> Fixes: 41b2facaf4ba ('dm: allocate blk_mq_tag_set rather than embed in mapped_device')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, folded in.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web