Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1330015 > unrolled thread

Re: [PATCH] x86/kernel: use pr_<level>() and dev_<level>

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] x86/kernel: use pr_<level>() and dev_<level> Ingo Molnar <mingo@kernel.org> - 2016-02-09 11:00 +0100
    Re: [PATCH] x86/kernel: use pr_<level>() and dev_<level> Thomas Gleixner <tglx@linutronix.de> - 2016-02-09 12:00 +0100
    Re: [PATCH] x86/kernel: use pr_<level>() and dev_<level> Joe Perches <joe@perches.com> - 2016-02-10 01:00 +0100

#1330015 — Re: [PATCH] x86/kernel: use pr_<level>() and dev_<level>

* Chen Yucong <slaoub@gmail.com> wrote:

> arch/x86/kernel/* use a mixture of printk(KERN_<level> ) and pr_<level>().
> This patch converts the bulk of printk(KERN_<level> ) to pr_<level>() and
> uses dev_dbg() instead of the dev_printk(KERN_DEBUG,). All pr_warning()
> calls have been replaced with pr_warn().
> 
> Not sure what to do about the printk(KERN_DEFAULT) and printk() without a
> log level.
> 
> Signed-off-by: Chen Yucong <slaoub@gmail.com>

When converting please also join broken up format strings, such as:

-               printk(KERN_WARNING PREFIX
-                      "HPET id: %#x base: 0xfed0000000000000 fixed up "
-                      "to 0xfed00000.\n", hpet_tbl->id);
+               pr_warn(PREFIX "HPET id: %#x base: 0xfed0000000000000 fixed up "
+                       "to 0xfed00000.\n", hpet_tbl->id);

ignore checkpatch: we don't line-break user visible strings.

Thanks,

	Ingo

[toc] | [next] | [standalone]

#1330090

On Tue, 9 Feb 2016, Ingo Molnar wrote:
> 
> * Chen Yucong <slaoub@gmail.com> wrote:
> 
> > arch/x86/kernel/* use a mixture of printk(KERN_<level> ) and pr_<level>().
> > This patch converts the bulk of printk(KERN_<level> ) to pr_<level>() and
> > uses dev_dbg() instead of the dev_printk(KERN_DEBUG,). All pr_warning()
> > calls have been replaced with pr_warn().
> > 
> > Not sure what to do about the printk(KERN_DEFAULT) and printk() without a
> > log level.
> > 
> > Signed-off-by: Chen Yucong <slaoub@gmail.com>
> 
> When converting please also join broken up format strings, such as:
> 
> -               printk(KERN_WARNING PREFIX
> -                      "HPET id: %#x base: 0xfed0000000000000 fixed up "
> -                      "to 0xfed00000.\n", hpet_tbl->id);
> +               pr_warn(PREFIX "HPET id: %#x base: 0xfed0000000000000 fixed up "
> +                       "to 0xfed00000.\n", hpet_tbl->id);
> 
> ignore checkpatch: we don't line-break user visible strings.

And please get rid of PREFIX. define pr_fmt instead.

Thanks,

	tglx

[toc] | [prev] | [next] | [standalone]

#1330780

On Tue, 2016-02-09 at 10:57 +0100, Ingo Molnar wrote:
> * Chen Yucong <slaoub@gmail.com> wrote:
> 
> > arch/x86/kernel/* use a mixture of printk(KERN_ ) and pr_().
> > This patch converts the bulk of printk(KERN_ ) to pr_() and
> > uses dev_dbg() instead of the dev_printk(KERN_DEBUG,). All pr_warning()
> > calls have been replaced with pr_warn().
> > 
> > Not sure what to do about the printk(KERN_DEFAULT) and printk() without a
> > log level.
> > 
> > Signed-off-by: Chen Yucong <slaoub@gmail.com>
> 
> When converting please also join broken up format strings, such as:
> 
> -               printk(KERN_WARNING PREFIX
> -                      "HPET id: %#x base: 0xfed0000000000000 fixed up "
> -                      "to 0xfed00000.\n", hpet_tbl->id);
> +               pr_warn(PREFIX "HPET id: %#x base: 0xfed0000000000000 fixed up "
> +                       "to 0xfed00000.\n", hpet_tbl->id);
> 
> ignore checkpatch: we don't line-break user visible strings.

Umm, checkpatch already suggests to coalesce split strings.

ie:

WARNING: quoted string split across lines
#850: FILE: arch/x86/kernel/hpet.c:850:
+			       "HPET config register value = 0xFFFFFFFF. "
+			       "Disabling HPET\n");

and checkpatch does the fixing using something like:

$ ./scripts/checkpatch.pl -f --fix-inplace --types=split_string arch/x86/kernel/hpet.c

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web