Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1331828 > unrolled thread

[PATCH v2] firmware: qemu_fw_cfg.c: fix typo FW_CFG_DATA_OFF

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2] firmware: qemu_fw_cfg.c: fix typo FW_CFG_DATA_OFF Valentin Rothberg <valentin.rothberg@posteo.net> - 2016-02-11 12:20 +0100
    Re: [PATCH v2] firmware: qemu_fw_cfg.c: fix typo FW_CFG_DATA_OFF "Gabriel L. Somlo" <somlo@cmu.edu> - 2016-02-11 13:20 +0100

#1331828 — [PATCH v2] firmware: qemu_fw_cfg.c: fix typo FW_CFG_DATA_OFF

s/FW_CTRL_DATA_OFF/FW_CFG_DATA_OFF/

Signed-off-by: Valentin Rothberg <valentin.rothberg@posteo.net>
Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
---
v2: corrected typo in signed-off-by

 drivers/firmware/qemu_fw_cfg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
index 19f6851be87f..fedbff55a7f3 100644
--- a/drivers/firmware/qemu_fw_cfg.c
+++ b/drivers/firmware/qemu_fw_cfg.c
@@ -98,7 +98,7 @@ static void fw_cfg_io_cleanup(void)
 }
 
 /* arch-specific ctrl & data register offsets are not available in ACPI, DT */
-#if !(defined(FW_CFG_CTRL_OFF) && defined(FW_CTRL_DATA_OFF))
+#if !(defined(FW_CFG_CTRL_OFF) && defined(FW_CFG_DATA_OFF))
 # if (defined(CONFIG_ARM) || defined(CONFIG_ARM64))
 #  define FW_CFG_CTRL_OFF 0x08
 #  define FW_CFG_DATA_OFF 0x00
-- 
2.5.0

[toc] | [next] | [standalone]

#1331898

On Thu, Feb 11, 2016 at 12:19:03PM +0100, Valentin Rothberg wrote:
> s/FW_CTRL_DATA_OFF/FW_CFG_DATA_OFF/

Thanks for catching that !

Acked-by: Gabriel Somlo <somlo@cmu.edu>


> 
> Signed-off-by: Valentin Rothberg <valentin.rothberg@posteo.net>
> Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
> ---
> v2: corrected typo in signed-off-by
> 
>  drivers/firmware/qemu_fw_cfg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> index 19f6851be87f..fedbff55a7f3 100644
> --- a/drivers/firmware/qemu_fw_cfg.c
> +++ b/drivers/firmware/qemu_fw_cfg.c
> @@ -98,7 +98,7 @@ static void fw_cfg_io_cleanup(void)
>  }
>  
>  /* arch-specific ctrl & data register offsets are not available in ACPI, DT */
> -#if !(defined(FW_CFG_CTRL_OFF) && defined(FW_CTRL_DATA_OFF))
> +#if !(defined(FW_CFG_CTRL_OFF) && defined(FW_CFG_DATA_OFF))
>  # if (defined(CONFIG_ARM) || defined(CONFIG_ARM64))
>  #  define FW_CFG_CTRL_OFF 0x08
>  #  define FW_CFG_DATA_OFF 0x00
> -- 
> 2.5.0
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web