Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1331783 > unrolled thread
| Started by | Suganath prabu Subramani <suganath-prabu.subramani@broadcom.com> |
|---|---|
| First post | 2016-02-11 10:40 +0100 |
| Last post | 2016-02-11 16:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/1] mpt3sas: Fix - Remove cpumask_clear for zalloc_cpumask_var and dont free free_cpu_mask_var before reply_q Suganath prabu Subramani <suganath-prabu.subramani@broadcom.com> - 2016-02-11 10:40 +0100
Re: [PATCH 1/1] mpt3sas: Fix - Remove cpumask_clear for zalloc_cpumask_var and dont free free_cpu_mask_var before reply_q "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-02-11 16:10 +0100
| From | Suganath prabu Subramani <suganath-prabu.subramani@broadcom.com> |
|---|---|
| Date | 2016-02-11 10:40 +0100 |
| Subject | [PATCH 1/1] mpt3sas: Fix - Remove cpumask_clear for zalloc_cpumask_var and dont free free_cpu_mask_var before reply_q |
| Message-ID | <r0VTd-6SY-5@gated-at.bofh.it> |
From: Suganath prabu Subramani <suganath-prabu.subramani@broadcom.com>
Removed cpumask_clear as it is not required for zalloc_cpumask_var and
free free_cpumask_var before freeing reply_q.
Signed-off-by: Suganath prabu Subramani <suganath-prabu.subramani@broadcom.com>
Signed-off-by: Chaitra P B <chaitra.basappa@broadcom.com>
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index c0a9d97..afdb13a 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -1855,7 +1855,6 @@ _base_request_irq(struct MPT3SAS_ADAPTER *ioc, u8 index, u32 vector)
kfree(reply_q);
return -ENOMEM;
}
- cpumask_clear(reply_q->affinity_hint);
}
atomic_set(&reply_q->busy, 0);
@@ -1870,8 +1869,8 @@ _base_request_irq(struct MPT3SAS_ADAPTER *ioc, u8 index, u32 vector)
if (r) {
pr_err(MPT3SAS_FMT "unable to allocate interrupt %d!\n",
reply_q->name, vector);
- kfree(reply_q);
free_cpumask_var(reply_q->affinity_hint);
+ kfree(reply_q);
return -EBUSY;
}
--
1.8.3.1
[toc] | [next] | [standalone]
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Date | 2016-02-11 16:10 +0100 |
| Message-ID | <r112y-23q-1@gated-at.bofh.it> |
| In reply to | #1331783 |
>>>>> "Suganath" == Suganath prabu Subramani <suganath-prabu.subramani@broadcom.com> writes: Suganath> Removed cpumask_clear as it is not required for Suganath> zalloc_cpumask_var and free free_cpumask_var before freeing Suganath> reply_q. Applied to 4.6/scsi-queue. However, next time please submit two patches, one for each issue. -- Martin K. Petersen Oracle Linux Engineering
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web