Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1331663 > unrolled thread

[PATCH] sched: remove an unnecessary memory access, rq->cpu in __schedule()

Started byByungchul Park <byungchul.park@lge.com>
First post2016-02-11 04:10 +0100
Last post2016-02-17 13:20 +0100
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] sched: remove an unnecessary memory access, rq->cpu in __schedule() Byungchul Park <byungchul.park@lge.com> - 2016-02-11 04:10 +0100
    Re: [PATCH] sched: remove an unnecessary memory access, rq->cpu in  __schedule() Ingo Molnar <mingo@kernel.org> - 2016-02-17 09:40 +0100
      Re: [PATCH] sched: remove an unnecessary memory access, rq->cpu in  __schedule() Byungchul Park <byungchul.park@lge.com> - 2016-02-17 09:50 +0100
    [tip:sched/core] sched/core: Remove dead statement in __schedule(  ) tip-bot for Byungchul Park <tipbot@zytor.com> - 2016-02-17 13:20 +0100

#1331663 — [PATCH] sched: remove an unnecessary memory access, rq->cpu in __schedule()

FromByungchul Park <byungchul.park@lge.com>
Date2016-02-11 04:10 +0100
Subject[PATCH] sched: remove an unnecessary memory access, rq->cpu in __schedule()
Message-ID<r0PNL-2MN-1@gated-at.bofh.it>
Is there any reason keeping this statement on the code?

-----8<-----
From d8a387efb8199b69b6464970d6f9fc57cbcf0ab0 Mon Sep 17 00:00:00 2001
From: Byungchul Park <byungchul.park@lge.com>
Date: Thu, 11 Feb 2016 11:50:53 +0900
Subject: [PATCH] sched: remove an unnecessary memory access, rq->cpu in
 __schedule()

Remove an unnecessary assignment of variable not used any more.

Signed-off-by: Byungchul Park <byungchul.park@lge.com>
---
 kernel/sched/core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 1315cec..501f5d9 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3193,7 +3193,6 @@ static void __sched notrace __schedule(bool preempt)
 
 		trace_sched_switch(preempt, prev, next);
 		rq = context_switch(rq, prev, next); /* unlocks the rq */
-		cpu = cpu_of(rq);
 	} else {
 		lockdep_unpin_lock(&rq->lock);
 		raw_spin_unlock_irq(&rq->lock);
-- 
1.9.1

[toc] | [next] | [standalone]

#1336134 — Re: [PATCH] sched: remove an unnecessary memory access, rq->cpu in __schedule()

FromIngo Molnar <mingo@kernel.org>
Date2016-02-17 09:40 +0100
SubjectRe: [PATCH] sched: remove an unnecessary memory access, rq->cpu in __schedule()
Message-ID<r35Oq-3Mb-11@gated-at.bofh.it>
In reply to#1331663
* Byungchul Park <byungchul.park@lge.com> wrote:

> Is there any reason keeping this statement on the code?
> 
> -----8<-----
> From d8a387efb8199b69b6464970d6f9fc57cbcf0ab0 Mon Sep 17 00:00:00 2001
> From: Byungchul Park <byungchul.park@lge.com>
> Date: Thu, 11 Feb 2016 11:50:53 +0900
> Subject: [PATCH] sched: remove an unnecessary memory access, rq->cpu in
>  __schedule()
> 
> Remove an unnecessary assignment of variable not used any more.
> 
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> ---
>  kernel/sched/core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 1315cec..501f5d9 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -3193,7 +3193,6 @@ static void __sched notrace __schedule(bool preempt)
>  
>  		trace_sched_switch(preempt, prev, next);
>  		rq = context_switch(rq, prev, next); /* unlocks the rq */
> -		cpu = cpu_of(rq);
>  	} else {
>  		lockdep_unpin_lock(&rq->lock);
>  		raw_spin_unlock_irq(&rq->lock);

There's no memory access that I can see - GCC will optimize it out.

Having said that, it is a dead statement so can be removed. I fixed the title 
accordingly.

Thanks,

	Ingo

[toc] | [prev] | [next] | [standalone]

#1336145 — Re: [PATCH] sched: remove an unnecessary memory access, rq->cpu in __schedule()

FromByungchul Park <byungchul.park@lge.com>
Date2016-02-17 09:50 +0100
SubjectRe: [PATCH] sched: remove an unnecessary memory access, rq->cpu in __schedule()
Message-ID<r35Y7-3PR-37@gated-at.bofh.it>
In reply to#1336134
On Wed, Feb 17, 2016 at 09:31:09AM +0100, Ingo Molnar wrote:
> 
> * Byungchul Park <byungchul.park@lge.com> wrote:
> 
> > Is there any reason keeping this statement on the code?
> > 
> > -----8<-----
> > From d8a387efb8199b69b6464970d6f9fc57cbcf0ab0 Mon Sep 17 00:00:00 2001
> > From: Byungchul Park <byungchul.park@lge.com>
> > Date: Thu, 11 Feb 2016 11:50:53 +0900
> > Subject: [PATCH] sched: remove an unnecessary memory access, rq->cpu in
> >  __schedule()
> > 
> > Remove an unnecessary assignment of variable not used any more.
> > 
> > Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> > ---
> >  kernel/sched/core.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> > index 1315cec..501f5d9 100644
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -3193,7 +3193,6 @@ static void __sched notrace __schedule(bool preempt)
> >  
> >  		trace_sched_switch(preempt, prev, next);
> >  		rq = context_switch(rq, prev, next); /* unlocks the rq */
> > -		cpu = cpu_of(rq);
> >  	} else {
> >  		lockdep_unpin_lock(&rq->lock);
> >  		raw_spin_unlock_irq(&rq->lock);
> 
> There's no memory access that I can see - GCC will optimize it out.

Yes, gcc will do it. So I expect no performance effect.

> 
> Having said that, it is a dead statement so can be removed. I fixed the title 
> accordingly.

Thank you.

> 
> Thanks,
> 
> 	Ingo

[toc] | [prev] | [next] | [standalone]

#1336322 — [tip:sched/core] sched/core: Remove dead statement in __schedule( )

Fromtip-bot for Byungchul Park <tipbot@zytor.com>
Date2016-02-17 13:20 +0100
Subject[tip:sched/core] sched/core: Remove dead statement in __schedule( )
Message-ID<r39fk-6j5-15@gated-at.bofh.it>
In reply to#1331663
Commit-ID:  3223d052b79eb9b620d170584c417d60a8bfd649
Gitweb:     http://git.kernel.org/tip/3223d052b79eb9b620d170584c417d60a8bfd649
Author:     Byungchul Park <byungchul.park@lge.com>
AuthorDate: Thu, 11 Feb 2016 11:59:38 +0900
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 17 Feb 2016 09:32:03 +0100

sched/core: Remove dead statement in __schedule()

Remove an unnecessary assignment of variable not used any more.

( This has no runtime effects as GCC is smart enough to optimize
  this out. )

Signed-off-by: Byungchul Park <byungchul.park@lge.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1455159578-17256-1-git-send-email-byungchul.park@lge.com
[ Edited the changelog. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 7e548bd..87ca0be 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3346,7 +3346,6 @@ static void __sched notrace __schedule(bool preempt)
 
 		trace_sched_switch(preempt, prev, next);
 		rq = context_switch(rq, prev, next); /* unlocks the rq */
-		cpu = cpu_of(rq);
 	} else {
 		lockdep_unpin_lock(&rq->lock);
 		raw_spin_unlock_irq(&rq->lock);

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web