Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1331611 > unrolled thread
| Started by | Justin Keller <justincompsci@gmail.com> |
|---|---|
| First post | 2016-02-11 01:50 +0100 |
| Last post | 2016-02-11 02:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
possible patch Justin Keller <justincompsci@gmail.com> - 2016-02-11 01:50 +0100
Re: possible patch Jonathan Corbet <corbet@lwn.net> - 2016-02-11 02:30 +0100
| From | Justin Keller <justincompsci@gmail.com> |
|---|---|
| Date | 2016-02-11 01:50 +0100 |
| Subject | possible patch |
| Message-ID | <r0NCi-1dh-7@gated-at.bofh.it> |
Hello,
I am new to submitting patches, so sorry if I am doing it wrong. My idea was
to change line 147 in drivers/isdn/pcbit/callbacks.c from
if (cbdata->data.setup.CallingPN == NULL) {
to
if (cbdata->data.setup.CallingPN == NULL ||
sizeof(cbdata->data.setup.CallingPN)>sizeof(ictl.parm.setup.phone) {
Justin Keller
[toc] | [next] | [standalone]
| From | Jonathan Corbet <corbet@lwn.net> |
|---|---|
| Date | 2016-02-11 02:30 +0100 |
| Message-ID | <r0Of0-1Jz-1@gated-at.bofh.it> |
| In reply to | #1331611 |
On Wed, 10 Feb 2016 19:49:11 -0500
Justin Keller <justincompsci@gmail.com> wrote:
> I am new to submitting patches, so sorry if I am doing it wrong. My idea was
> to change line 147 in drivers/isdn/pcbit/callbacks.c from
> if (cbdata->data.setup.CallingPN == NULL) {
>
> to
>
> if (cbdata->data.setup.CallingPN == NULL ||
> sizeof(cbdata->data.setup.CallingPN)>sizeof(ictl.parm.setup.phone) {
If you want to patch the kernel, the best way to describe what you want to
do is to ... send a patch.
Before you do so, though:
- Please read the available documentation, including SubmittingPatches and
development-process/*
- Prepare a proper changelog saying *why* you want to make this change.
You are trying to change the ISDN subsystem, which is pretty static
these days; what current problem are you running into that makes you
think this change needs to be applied to the kernel?
Thanks,
jon
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web