Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1331193 > unrolled thread
| Started by | David Howells <dhowells@redhat.com> |
|---|---|
| First post | 2016-02-10 15:20 +0100 |
| Last post | 2016-02-16 21:50 +0100 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api David Howells <dhowells@redhat.com> - 2016-02-10 15:20 +0100
Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api Tadeusz Struk <tadeusz.struk@intel.com> - 2016-02-11 00:20 +0100
Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api David Howells <dhowells@redhat.com> - 2016-02-11 11:00 +0100
Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api David Howells <dhowells@redhat.com> - 2016-02-11 11:10 +0100
Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api Tadeusz Struk <tadeusz.struk@intel.com> - 2016-02-16 21:50 +0100
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Date | 2016-02-10 15:20 +0100 |
| Subject | Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api |
| Message-ID | <r0DMC-3gn-7@gated-at.bofh.it> |
Why didn't you put the RSA signature parsing - ie. where the OID and the other bits are checked - into crypto/rsa.c? David
[toc] | [next] | [standalone]
| From | Tadeusz Struk <tadeusz.struk@intel.com> |
|---|---|
| Date | 2016-02-11 00:20 +0100 |
| Subject | Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api |
| Message-ID | <r0Mdb-t3-7@gated-at.bofh.it> |
| In reply to | #1331193 |
Hi David, On 02/10/2016 06:17 AM, David Howells wrote: > Why didn't you put the RSA signature parsing - ie. where the OID and the other > bits are checked - into crypto/rsa.c? > Do you want to get rid of the crypto/asymmetric_keys/rsa.c completely? I wanted to make the conversion churn as small as possible. I can move it in a subsequent patch if you want. Thanks, -- TS
[toc] | [prev] | [next] | [standalone]
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Date | 2016-02-11 11:00 +0100 |
| Message-ID | <r0WcA-6ZA-17@gated-at.bofh.it> |
| In reply to | #1331577 |
Tadeusz Struk <tadeusz.struk@intel.com> wrote: > > Why didn't you put the RSA signature parsing - ie. where the OID and the other > > bits are checked - into crypto/rsa.c? > > > > Do you want to get rid of the crypto/asymmetric_keys/rsa.c completely? > I wanted to make the conversion churn as small as possible. > I can move it in a subsequent patch if you want. I was thinking of getting rid of it completely, yes. But I was wondering if you had some other motivation, such as keeping the crypto layer purely the mathematical operation. It's an interesting question where to draw the line, actually. The answer may hinge on what things like the TPM do. I should ask the TPM folks. David
[toc] | [prev] | [next] | [standalone]
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Date | 2016-02-11 11:10 +0100 |
| Message-ID | <r0Wme-7iA-21@gated-at.bofh.it> |
| In reply to | #1331792 |
David Howells <dhowells@redhat.com> wrote: > Tadeusz Struk <tadeusz.struk@intel.com> wrote: > > > > Why didn't you put the RSA signature parsing - ie. where the OID and the other > > > bits are checked - into crypto/rsa.c? > > > > > > > Do you want to get rid of the crypto/asymmetric_keys/rsa.c completely? > > I wanted to make the conversion churn as small as possible. > > I can move it in a subsequent patch if you want. > > I was thinking of getting rid of it completely, yes. > > But I was wondering if you had some other motivation, such as keeping the > crypto layer purely the mathematical operation. > > It's an interesting question where to draw the line, actually. The answer may > hinge on what things like the TPM do. I should ask the TPM folks. Looking in the TPM emulator, the TPM_Sign operation indeed puts the wrappings on, so this needs to go into the crypto layer. David
[toc] | [prev] | [next] | [standalone]
| From | Tadeusz Struk <tadeusz.struk@intel.com> |
|---|---|
| Date | 2016-02-16 21:50 +0100 |
| Subject | Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api |
| Message-ID | <r2UJk-4va-21@gated-at.bofh.it> |
| In reply to | #1331799 |
Hi David, On 02/11/2016 02:08 AM, David Howells wrote: > David Howells <dhowells@redhat.com> wrote: > >> > Tadeusz Struk <tadeusz.struk@intel.com> wrote: >> > >>>> > > > Why didn't you put the RSA signature parsing - ie. where the OID and the other >>>> > > > bits are checked - into crypto/rsa.c? >>>> > > > >>> > > >>> > > Do you want to get rid of the crypto/asymmetric_keys/rsa.c completely? >>> > > I wanted to make the conversion churn as small as possible. >>> > > I can move it in a subsequent patch if you want. >> > >> > I was thinking of getting rid of it completely, yes. >> > >> > But I was wondering if you had some other motivation, such as keeping the >> > crypto layer purely the mathematical operation. >> > >> > It's an interesting question where to draw the line, actually. The answer may >> > hinge on what things like the TPM do. I should ask the TPM folks. > Looking in the TPM emulator, the TPM_Sign operation indeed puts the wrappings > on, so this needs to go into the crypto layer. David, If you could tell me what repo should I work with then I can prepare subsequent patch to move this to a new file under crypto/ Thanks, -- TS
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web