Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1331486 > unrolled thread

[PATCH v2] Staging: fix coding style in rtl8188eu/core

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] Staging: fix coding style in rtl8188eu/core Colin Vidal <colin@cvidal.org> - 2016-02-10 22:10 +0100
    Re: [PATCH v2] Staging: fix coding style in rtl8188eu/core Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-12 05:10 +0100

#1331486 — [PATCH v2] Staging: fix coding style in rtl8188eu/core

Set constant operand on right of test, and refactor the code in a more
compact and readable way.

Signed-off-by: Colin Vidal <colin@cvidal.org>
---
 drivers/staging/rtl8188eu/core/rtw_iol.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c
index cdcf0ea..00e1136 100644
--- a/drivers/staging/rtl8188eu/core/rtw_iol.c
+++ b/drivers/staging/rtl8188eu/core/rtw_iol.c
@@ -18,14 +18,11 @@
  *
  ******************************************************************************/
 
-#include<rtw_iol.h>
+#include <rtw_iol.h>
 
-bool rtw_IOL_applied(struct adapter  *adapter)
+bool rtw_IOL_applied(struct adapter *adapter)
 {
-	if (1 == adapter->registrypriv.fw_iol)
-		return true;
-
-	if ((2 == adapter->registrypriv.fw_iol) && (!adapter_to_dvobj(adapter)->ishighspeed))
-		return true;
-	return false;
+	return adapter->registrypriv.fw_iol == 1 ||
+		(adapter->registrypriv.fw_iol == 2 &&
+		 !adapter_to_dvobj(adapter)->ishighspeed);
 }
-- 
2.5.0

[toc] | [next] | [standalone]

#1332509

On Wed, Feb 10, 2016 at 10:09:28PM +0100, Colin Vidal wrote:
> Set constant operand on right of test, and refactor the code in a more
> compact and readable way.

Please don't do two different things in the same patch, break this up
into different patches.

thanks,

gregk -h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web