Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1331371 > unrolled thread
| Started by | Julien Grossholtz <julien.grossholtz@savoirfairelinux.com> |
|---|---|
| First post | 2016-02-10 18:50 +0100 |
| Last post | 2016-02-15 14:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] gpio: TS-4800: remove useless bgpio_init flags Julien Grossholtz <julien.grossholtz@savoirfairelinux.com> - 2016-02-10 18:50 +0100
Re: [PATCH v2] gpio: TS-4800: remove useless bgpio_init flags Linus Walleij <linus.walleij@linaro.org> - 2016-02-15 14:30 +0100
| From | Julien Grossholtz <julien.grossholtz@savoirfairelinux.com> |
|---|---|
| Date | 2016-02-10 18:50 +0100 |
| Subject | [PATCH v2] gpio: TS-4800: remove useless bgpio_init flags |
| Message-ID | <r0H3R-5r5-17@gated-at.bofh.it> |
No flags are required for bgpio_init in the TS-4800 gpio driver. This
patch set zero instead. The driver will have the same behaviour since
the & operator between the flags already resulted to zero.
Fixes: 5041e791440a ("gpio: add TS-4800 fpga GPIO support")
Signed-off-by: Julien Grossholtz <julien.grossholtz@savoirfairelinux.com>
---
drivers/gpio/gpio-ts4800.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-ts4800.c b/drivers/gpio/gpio-ts4800.c
index c4908a4..9da79e4 100644
--- a/drivers/gpio/gpio-ts4800.c
+++ b/drivers/gpio/gpio-ts4800.c
@@ -48,8 +48,7 @@ static int ts4800_gpio_probe(struct platform_device *pdev)
retval = bgpio_init(chip, &pdev->dev, 2, base_addr + INPUT_REG_OFFSET,
base_addr + OUTPUT_REG_OFFSET, NULL,
- base_addr + DIRECTION_REG_OFFSET, NULL,
- BGPIOF_BIG_ENDIAN & BGPIOF_BIG_ENDIAN_BYTE_ORDER);
+ base_addr + DIRECTION_REG_OFFSET, NULL, 0);
if (retval) {
dev_err(&pdev->dev, "bgpio_init failed\n");
return retval;
--
2.5.0
[toc] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2016-02-15 14:30 +0100 |
| Message-ID | <r2rnZ-1yI-19@gated-at.bofh.it> |
| In reply to | #1331371 |
On Wed, Feb 10, 2016 at 6:20 PM, Julien Grossholtz
<julien.grossholtz@savoirfairelinux.com> wrote:
> No flags are required for bgpio_init in the TS-4800 gpio driver. This
> patch set zero instead. The driver will have the same behaviour since
> the & operator between the flags already resulted to zero.
>
> Fixes: 5041e791440a ("gpio: add TS-4800 fpga GPIO support")
>
> Signed-off-by: Julien Grossholtz <julien.grossholtz@savoirfairelinux.com>
Patch applied.
Yours,
Linus Walleij
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web