Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1331366 > unrolled thread

Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-02-10 18:40 +0100
    Re: [PATCH] lpfc: Remove redundant code block in  lpfc_scsi_cmd_iocb_cmpl Johannes Thumshirn <jthumshirn@suse.de> - 2016-02-11 12:40 +0100

#1331366 — Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

>>>>> "Johannes" == Johannes Thumshirn <jthumshirn@suse.de> writes:

Johannes> This removes a redundant code block that will either be
Johannes> executed if the ENABLE_FCP_RING_POLLING flag is set in
Johannes> phba->cfg_poll or not. The code is just duplicated in both
Johannes> cases, hence we unify it again.

James and Dick: Ping!

https://patchwork.kernel.org/patch/8072451/

-- 
Martin K. Petersen	Oracle Linux Engineering

[toc] | [next] | [standalone]

#1331839 — Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

On Wed, Feb 10, 2016 at 01:32:50PM -0500, Dick Kennedy wrote:
> Martin, 
> the FCP_RING_POLLING feature is an old driver option that we would like to
> remove from the driver. It was put in in 2006 as a feature request.
> What we don't know is if any customers still use it? or ever used it. 
> 
> The patch looks fine. 
> ACK

Dick, is there any chance you could Ack my lockdep assertion patch as well?
Bart seemed to like it and I think our support people will do as well as it
screams pretty loud when something isn't golden there.

TIA,
	Johannes

> 
> On Wed, Feb 10, 2016 at 12:37 PM, Martin K. Petersen <
> martin.petersen@oracle.com> wrote:
> 
>     >>>>> "Johannes" == Johannes Thumshirn <jthumshirn@suse.de> writes:
> 
>     Johannes> This removes a redundant code block that will either be
>     Johannes> executed if the ENABLE_FCP_RING_POLLING flag is set in
>     Johannes> phba->cfg_poll or not. The code is just duplicated in both
>     Johannes> cases, hence we unify it again.
> 
>     James and Dick: Ping!
> 
>     https://patchwork.kernel.org/patch/8072451/
>    
>     --
>     Martin K. Petersen      Oracle Linux Engineering
> 
> 

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web