Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1331264 > unrolled thread

[PATCH] cpufreq: select IRQ_WORK in Kconfig

Back to article view | Back to linux.kernel

Contents

  [PATCH] cpufreq: select IRQ_WORK in Kconfig Arnd Bergmann <arnd@arndb.de> - 2016-02-10 16:20 +0100
    Re: [PATCH] cpufreq: select IRQ_WORK in Kconfig "Rafael J. Wysocki" <rafael@kernel.org> - 2016-02-10 16:30 +0100

#1331264 — [PATCH] cpufreq: select IRQ_WORK in Kconfig

The cpufreq core code has started using the irq_work infrastructure, but that
can be disabled in Kconfig, causing a link failure:

drivers/cpufreq/cpufreq_governor.c: In function 'gov_queue_irq_work':
drivers/cpufreq/cpufreq_governor.c:251:3: error: implicit declaration of function 'irq_work_queue_on' [-Werror=implicit-function-declaration]

This adds an explicit 'select' to ensure it's always enabled.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 0144fa03ef46 ("cpufreq: governor: Replace timers with utilization update callbacks")
---
 drivers/cpufreq/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
index 3050e8d48887..ca05037dd565 100644
--- a/drivers/cpufreq/Kconfig
+++ b/drivers/cpufreq/Kconfig
@@ -3,6 +3,7 @@ menu "CPU Frequency scaling"
 config CPU_FREQ
 	bool "CPU Frequency scaling"
 	select SRCU
+	select IRQ_WORK
 	help
 	  CPU Frequency scaling allows you to change the clock speed of 
 	  CPUs on the fly. This is a nice method to save power, because 
-- 
2.7.0

[toc] | [next] | [standalone]

#1331274

On Wed, Feb 10, 2016 at 4:14 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The cpufreq core code has started using the irq_work infrastructure, but that
> can be disabled in Kconfig, causing a link failure:
>
> drivers/cpufreq/cpufreq_governor.c: In function 'gov_queue_irq_work':
> drivers/cpufreq/cpufreq_governor.c:251:3: error: implicit declaration of function 'irq_work_queue_on' [-Werror=implicit-function-declaration]
>
> This adds an explicit 'select' to ensure it's always enabled.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0144fa03ef46 ("cpufreq: governor: Replace timers with utilization update callbacks")
> ---
>  drivers/cpufreq/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index 3050e8d48887..ca05037dd565 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -3,6 +3,7 @@ menu "CPU Frequency scaling"
>  config CPU_FREQ
>         bool "CPU Frequency scaling"
>         select SRCU
> +       select IRQ_WORK
>         help
>           CPU Frequency scaling allows you to change the clock speed of
>           CPUs on the fly. This is a nice method to save power, because
> --

Good catch, thanks!

I'll update the patch to do that.

Thanks,
Rafael

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web