Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1331192 > unrolled thread
| Started by | Chris Paterson <chris.paterson2@renesas.com> |
|---|---|
| First post | 2016-02-10 15:20 +0100 |
| Last post | 2016-02-10 15:50 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] mmc: sh_mmcif: Correct TX DMA channel allocation Chris Paterson <chris.paterson2@renesas.com> - 2016-02-10 15:20 +0100
Re: [PATCH] mmc: sh_mmcif: Correct TX DMA channel allocation Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-02-10 15:40 +0100
Re: [PATCH] mmc: sh_mmcif: Correct TX DMA channel allocation Ulf Hansson <ulf.hansson@linaro.org> - 2016-02-10 15:40 +0100
Re: [PATCH] mmc: sh_mmcif: Correct TX DMA channel allocation Arnd Bergmann <arnd@arndb.de> - 2016-02-10 15:50 +0100
| From | Chris Paterson <chris.paterson2@renesas.com> |
|---|---|
| Date | 2016-02-10 15:20 +0100 |
| Subject | [PATCH] mmc: sh_mmcif: Correct TX DMA channel allocation |
| Message-ID | <r0DMC-3gn-3@gated-at.bofh.it> |
Commit 27cbd7e815a8 ("mmc: sh_mmcif: rework dma channel handling")
introduced a typo causing the TX DMA channel allocation to be overwritten
by the requested RX DMA channel.
Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
---
drivers/mmc/host/sh_mmcif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
index e0c076a..8d870ce 100644
--- a/drivers/mmc/host/sh_mmcif.c
+++ b/drivers/mmc/host/sh_mmcif.c
@@ -445,7 +445,7 @@ static void sh_mmcif_request_dma(struct sh_mmcif_host *host)
pdata->slave_id_rx);
} else {
host->chan_tx = dma_request_slave_channel(dev, "tx");
- host->chan_tx = dma_request_slave_channel(dev, "rx");
+ host->chan_rx = dma_request_slave_channel(dev, "rx");
}
dev_dbg(dev, "%s: got channel TX %p RX %p\n", __func__, host->chan_tx,
host->chan_rx);
--
1.9.1
[toc] | [next] | [standalone]
| From | Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
|---|---|
| Date | 2016-02-10 15:40 +0100 |
| Message-ID | <r0E5Y-3mS-11@gated-at.bofh.it> |
| In reply to | #1331192 |
Hi Chris,
Thank you for the patch.
On Wednesday 10 February 2016 14:07:01 Chris Paterson wrote:
> Commit 27cbd7e815a8 ("mmc: sh_mmcif: rework dma channel handling")
> introduced a typo causing the TX DMA channel allocation to be overwritten
> by the requested RX DMA channel.
>
> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/mmc/host/sh_mmcif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
> index e0c076a..8d870ce 100644
> --- a/drivers/mmc/host/sh_mmcif.c
> +++ b/drivers/mmc/host/sh_mmcif.c
> @@ -445,7 +445,7 @@ static void sh_mmcif_request_dma(struct sh_mmcif_host
> *host) pdata->slave_id_rx);
> } else {
> host->chan_tx = dma_request_slave_channel(dev, "tx");
> - host->chan_tx = dma_request_slave_channel(dev, "rx");
> + host->chan_rx = dma_request_slave_channel(dev, "rx");
> }
> dev_dbg(dev, "%s: got channel TX %p RX %p\n", __func__, host->chan_tx,
> host->chan_rx);
--
Regards,
Laurent Pinchart
[toc] | [prev] | [next] | [standalone]
| From | Ulf Hansson <ulf.hansson@linaro.org> |
|---|---|
| Date | 2016-02-10 15:40 +0100 |
| Message-ID | <r0E5Y-3mS-17@gated-at.bofh.it> |
| In reply to | #1331192 |
On 10 February 2016 at 15:07, Chris Paterson
<chris.paterson2@renesas.com> wrote:
> Commit 27cbd7e815a8 ("mmc: sh_mmcif: rework dma channel handling")
> introduced a typo causing the TX DMA channel allocation to be overwritten
> by the requested RX DMA channel.
>
> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
Thanks, applied for fixes and I also added a corresponding fixes tag.
Kind regards
Uffe
> ---
> drivers/mmc/host/sh_mmcif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
> index e0c076a..8d870ce 100644
> --- a/drivers/mmc/host/sh_mmcif.c
> +++ b/drivers/mmc/host/sh_mmcif.c
> @@ -445,7 +445,7 @@ static void sh_mmcif_request_dma(struct sh_mmcif_host *host)
> pdata->slave_id_rx);
> } else {
> host->chan_tx = dma_request_slave_channel(dev, "tx");
> - host->chan_tx = dma_request_slave_channel(dev, "rx");
> + host->chan_rx = dma_request_slave_channel(dev, "rx");
> }
> dev_dbg(dev, "%s: got channel TX %p RX %p\n", __func__, host->chan_tx,
> host->chan_rx);
> --
> 1.9.1
>
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-02-10 15:50 +0100 |
| Message-ID | <r0EfF-3qm-37@gated-at.bofh.it> |
| In reply to | #1331192 |
On Wednesday 10 February 2016 14:07:01 Chris Paterson wrote:
> Commit 27cbd7e815a8 ("mmc: sh_mmcif: rework dma channel handling")
> introduced a typo causing the TX DMA channel allocation to be overwritten
> by the requested RX DMA channel.
>
> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
> ---
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Sorry about the trouble.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web