Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1329135 > unrolled thread

[PATCH] clk: socfpga: fix __init annotation

Back to article view | Back to linux.kernel

Contents

  [PATCH] clk: socfpga: fix __init annotation Arnd Bergmann <arnd@arndb.de> - 2016-02-08 15:50 +0100
    Re: [PATCH] clk: socfpga: fix __init annotation Stephen Boyd <sboyd@codeaurora.org> - 2016-02-08 23:20 +0100

#1329135 — [PATCH] clk: socfpga: fix __init annotation

clang found a bug with the __socfpga_pll_init definition:

drivers/clk/socfpga/clk-pll-a10.c:77:15: error: '__section__' attribute only applies to functions and
      global variables

This moves the __init annotation to the right place so the function
actually gets discarded.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/clk/socfpga/clk-pll-a10.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/socfpga/clk-pll-a10.c b/drivers/clk/socfpga/clk-pll-a10.c
index 402d630bd531..35fabe1a32c3 100644
--- a/drivers/clk/socfpga/clk-pll-a10.c
+++ b/drivers/clk/socfpga/clk-pll-a10.c
@@ -74,7 +74,7 @@ static struct clk_ops clk_pll_ops = {
 	.get_parent = clk_pll_get_parent,
 };
 
-static struct __init clk * __socfpga_pll_init(struct device_node *node,
+static struct clk * __init __socfpga_pll_init(struct device_node *node,
 	const struct clk_ops *ops)
 {
 	u32 reg;
-- 
2.7.0

[toc] | [next] | [standalone]

#1329640

On 02/08, Arnd Bergmann wrote:
> clang found a bug with the __socfpga_pll_init definition:
> 
> drivers/clk/socfpga/clk-pll-a10.c:77:15: error: '__section__' attribute only applies to functions and
>       global variables
> 
> This moves the __init annotation to the right place so the function
> actually gets discarded.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web