Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1272976 > unrolled thread

[PATCH] sp5100_tco: Add AMD Mullins platform support

Started byDenis Turischev <denis.turischev@compulab.co.il>
First post2015-11-19 11:00 +0100
Last post2015-11-24 15:00 +0100
Articles 7 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] sp5100_tco: Add AMD Mullins platform support Denis Turischev <denis.turischev@compulab.co.il> - 2015-11-19 11:00 +0100
    Re: [PATCH] sp5100_tco: Add AMD Mullins platform support Guenter Roeck <linux@roeck-us.net> - 2015-11-19 17:20 +0100
    Re: [PATCH] sp5100_tco: Add AMD Mullins platform support Denis Turischev <denis.turischev@compulab.co.il> - 2015-11-22 10:00 +0100
    [PATCH v2] sp5100_tco: Add AMD Mullins platform support Denis Turischev <denis.turischev@compulab.co.il> - 2015-11-23 09:00 +0100
      Re: [PATCH v2] sp5100_tco: Add AMD Mullins platform support Guenter Roeck <linux@roeck-us.net> - 2015-11-23 18:00 +0100
        [PATCH v3] sp5100_tco: Add AMD Mullins platform support Denis Turischev <denis.turischev@compulab.co.il> - 2015-11-24 09:50 +0100
          Re: [PATCH v3] sp5100_tco: Add AMD Mullins platform support Guenter Roeck <linux@roeck-us.net> - 2015-11-24 15:00 +0100

#1272976 — [PATCH] sp5100_tco: Add AMD Mullins platform support

FromDenis Turischev <denis.turischev@compulab.co.il>
Date2015-11-19 11:00 +0100
Subject[PATCH] sp5100_tco: Add AMD Mullins platform support
Message-ID<qwuav-7Bg-15@gated-at.bofh.it>
AMD Mullins watchdog is fully compatible to the previous Hudson chipset,
reuse the existent sp5100_tco driver.

Signed-off-by: Denis Turischev <denis.turischev@compulab.co.il>

diff -Nru linux-4.3.orig/drivers/watchdog/sp5100_tco.c linux-4.3/drivers/watchdog/sp5100_tco.c
--- linux-4.3.orig/drivers/watchdog/sp5100_tco.c	2015-11-02 02:05:25.000000000 +0200
+++ linux-4.3/drivers/watchdog/sp5100_tco.c	2015-11-19 11:08:06.272777718 +0200
@@ -306,6 +306,8 @@
 static const struct pci_device_id sp5100_tco_pci_tbl[] = {
 	{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS, PCI_ANY_ID,
 	  PCI_ANY_ID, },
+	{ PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, PCI_ANY_ID,
+	  PCI_ANY_ID, },
 	{ 0, },			/* End of list */
 };
 MODULE_DEVICE_TABLE(pci, sp5100_tco_pci_tbl);	
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1273260

FromGuenter Roeck <linux@roeck-us.net>
Date2015-11-19 17:20 +0100
Message-ID<qwA6e-3ds-7@gated-at.bofh.it>
In reply to#1272976
On 11/19/2015 01:56 AM, Denis Turischev wrote:
> AMD Mullins watchdog is fully compatible to the previous Hudson chipset,
> reuse the existent sp5100_tco driver.
>
> Signed-off-by: Denis Turischev <denis.turischev@compulab.co.il>
>
> diff -Nru linux-4.3.orig/drivers/watchdog/sp5100_tco.c linux-4.3/drivers/watchdog/sp5100_tco.c
> --- linux-4.3.orig/drivers/watchdog/sp5100_tco.c	2015-11-02 02:05:25.000000000 +0200
> +++ linux-4.3/drivers/watchdog/sp5100_tco.c	2015-11-19 11:08:06.272777718 +0200
> @@ -306,6 +306,8 @@
>   static const struct pci_device_id sp5100_tco_pci_tbl[] = {
>   	{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS, PCI_ANY_ID,
>   	  PCI_ANY_ID, },
> +	{ PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, PCI_ANY_ID,
> +	  PCI_ANY_ID, },
>   	{ 0, },			/* End of list */
>   };
>   MODULE_DEVICE_TABLE(pci, sp5100_tco_pci_tbl);	
> --

Your patch does not apply to the latest kernel. Can you rebase to v4.4-rc1 and resubmit ?

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1274822

FromDenis Turischev <denis.turischev@compulab.co.il>
Date2015-11-22 10:00 +0100
Message-ID<qxyF3-1jE-3@gated-at.bofh.it>
In reply to#1272976
Hi Rui,

On 11/20/2015 04:33 AM, Huang Rui wrote:
> Hi Denis,
> 
> On Thu, Nov 19, 2015 at 05:56:00PM +0800, Denis Turischev wrote:
>> AMD Mullins watchdog is fully compatible to the previous Hudson chipset,
>> reuse the existent sp5100_tco driver.
>>
> 
> Thank you to add this support!
> Actually, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS is only the SMBus device id
> on AMD mullins but also on many other AMD platforms. Could you please
> share some test method to me, that I am glad to do some quick tests. :)

My device is Compulabs's fitlet. It's a fanless mini PC, also known as mintbox mini.
http://fit-pc.com/wiki/index.php/Fit-PC_Product_Line:_fitlet
Processor's datasheet:
http://support.amd.com/TechDocs/52740_16h_Models_30h-3Fh_BKDG.pdf

The dmesg output:
sp5100_tco: SP5100/SB800 TCO WatchDog Timer Driver v0.05
sp5100_tco: PCI Revision ID: 0x42
sp5100_tco: Using 0xfeb00000 for watchdog MMIO address
sp5100_tco: Last reboot was not triggered by watchdog.
sp5100_tco: initialized (0xffffc90000702000). heartbeat=60 sec (nowayout=0)

Please let me know if you need any other info or tests to be performed.

Denis

> 
> Thanks,
> Rui
> 
>> Signed-off-by: Denis Turischev <denis.turischev@compulab.co.il>
>>
>> diff -Nru linux-4.3.orig/drivers/watchdog/sp5100_tco.c linux-4.3/drivers/watchdog/sp5100_tco.c
>> --- linux-4.3.orig/drivers/watchdog/sp5100_tco.c	2015-11-02 02:05:25.000000000 +0200
>> +++ linux-4.3/drivers/watchdog/sp5100_tco.c	2015-11-19 11:08:06.272777718 +0200
>> @@ -306,6 +306,8 @@
>>  static const struct pci_device_id sp5100_tco_pci_tbl[] = {
>>  	{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS, PCI_ANY_ID,
>>  	  PCI_ANY_ID, },
>> +	{ PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, PCI_ANY_ID,
>> +	  PCI_ANY_ID, },
>>  	{ 0, },			/* End of list */
>>  };
>>  MODULE_DEVICE_TABLE(pci, sp5100_tco_pci_tbl);	
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1275082 — [PATCH v2] sp5100_tco: Add AMD Mullins platform support

FromDenis Turischev <denis.turischev@compulab.co.il>
Date2015-11-23 09:00 +0100
Subject[PATCH v2] sp5100_tco: Add AMD Mullins platform support
Message-ID<qxUcx-7gY-3@gated-at.bofh.it>
In reply to#1272976
AMD Mullins watchdog is fully compatible to the previous Hudson chipset,
reuse the existent sp5100_tco driver.

v2: rebased to v4.4-rc2

Signed-off-by: Denis Turischev <denis.turischev@compulab.co.il>

diff -Nru linux-4.4-rc2.orig/drivers/watchdog/sp5100_tco.c linux-4.4-rc2/drivers/watchdog/sp5100_tco.c
--- linux-4.4-rc2.orig/drivers/watchdog/sp5100_tco.c	2015-11-23 02:45:59.000000000 +0200
+++ linux-4.4-rc2/drivers/watchdog/sp5100_tco.c	2015-11-23 09:51:48.701245853 +0200
@@ -306,6 +306,8 @@
 static const struct pci_device_id sp5100_tco_pci_tbl[] = {
 	{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS, PCI_ANY_ID,
 	  PCI_ANY_ID, },
+	{ PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, PCI_ANY_ID,
+	  PCI_ANY_ID, }, 
 	{ 0, },			/* End of list */
 };
 MODULE_DEVICE_TABLE(pci, sp5100_tco_pci_tbl);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1275636 — Re: [PATCH v2] sp5100_tco: Add AMD Mullins platform support

FromGuenter Roeck <linux@roeck-us.net>
Date2015-11-23 18:00 +0100
SubjectRe: [PATCH v2] sp5100_tco: Add AMD Mullins platform support
Message-ID<qy2D8-4un-7@gated-at.bofh.it>
In reply to#1275082
On 11/22/2015 11:59 PM, Denis Turischev wrote:
> AMD Mullins watchdog is fully compatible to the previous Hudson chipset,
> reuse the existent sp5100_tco driver.
>
> v2: rebased to v4.4-rc2
>
> Signed-off-by: Denis Turischev <denis.turischev@compulab.co.il>
>
> diff -Nru linux-4.4-rc2.orig/drivers/watchdog/sp5100_tco.c linux-4.4-rc2/drivers/watchdog/sp5100_tco.c
> --- linux-4.4-rc2.orig/drivers/watchdog/sp5100_tco.c	2015-11-23 02:45:59.000000000 +0200
> +++ linux-4.4-rc2/drivers/watchdog/sp5100_tco.c	2015-11-23 09:51:48.701245853 +0200
> @@ -306,6 +306,8 @@
>   static const struct pci_device_id sp5100_tco_pci_tbl[] = {
>   	{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS, PCI_ANY_ID,
>   	  PCI_ANY_ID, },
> +	{ PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, PCI_ANY_ID,
> +	  PCI_ANY_ID, },
>   	{ 0, },			/* End of list */
>   };
>   MODULE_DEVICE_TABLE(pci, sp5100_tco_pci_tbl);

$ scripts/checkpatch.pl index.html
ERROR: trailing whitespace
#32: FILE: drivers/watchdog/sp5100_tco.c:310:
+^I  PCI_ANY_ID, }, $

total: 1 errors, 0 warnings, 8 lines checked

Please fix.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1276162 — [PATCH v3] sp5100_tco: Add AMD Mullins platform support

FromDenis Turischev <denis.turischev@compulab.co.il>
Date2015-11-24 09:50 +0100
Subject[PATCH v3] sp5100_tco: Add AMD Mullins platform support
Message-ID<qyhsu-5Kj-1@gated-at.bofh.it>
In reply to#1275636
AMD Mullins watchdog is fully compatible to the previous Hudson chipset,
reuse the existent sp5100_tco driver.

v2: rebased to v4.4-rc2
v3: fixed trailing whitespace

Signed-off-by: Denis Turischev <denis.turischev@compulab.co.il>

diff -Nru linux-4.4-rc2.orig/drivers/watchdog/sp5100_tco.c linux-4.4-rc2/drivers/watchdog/sp5100_tco.c
--- linux-4.4-rc2.orig/drivers/watchdog/sp5100_tco.c	2015-11-23 02:45:59.000000000 +0200
+++ linux-4.4-rc2/drivers/watchdog/sp5100_tco.c	2015-11-23 09:51:48.701245853 +0200
@@ -306,6 +306,8 @@
 static const struct pci_device_id sp5100_tco_pci_tbl[] = {
 	{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS, PCI_ANY_ID,
 	  PCI_ANY_ID, },
+	{ PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, PCI_ANY_ID,
+	  PCI_ANY_ID, },
 	{ 0, },			/* End of list */
 };
 MODULE_DEVICE_TABLE(pci, sp5100_tco_pci_tbl);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1276487 — Re: [PATCH v3] sp5100_tco: Add AMD Mullins platform support

FromGuenter Roeck <linux@roeck-us.net>
Date2015-11-24 15:00 +0100
SubjectRe: [PATCH v3] sp5100_tco: Add AMD Mullins platform support
Message-ID<qymiu-n6-21@gated-at.bofh.it>
In reply to#1276162
On 11/24/2015 12:46 AM, Denis Turischev wrote:
> AMD Mullins watchdog is fully compatible to the previous Hudson chipset,
> reuse the existent sp5100_tco driver.
>
> v2: rebased to v4.4-rc2
> v3: fixed trailing whitespace
>
> Signed-off-by: Denis Turischev <denis.turischev@compulab.co.il>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

>
> diff -Nru linux-4.4-rc2.orig/drivers/watchdog/sp5100_tco.c linux-4.4-rc2/drivers/watchdog/sp5100_tco.c
> --- linux-4.4-rc2.orig/drivers/watchdog/sp5100_tco.c	2015-11-23 02:45:59.000000000 +0200
> +++ linux-4.4-rc2/drivers/watchdog/sp5100_tco.c	2015-11-23 09:51:48.701245853 +0200
> @@ -306,6 +306,8 @@
>   static const struct pci_device_id sp5100_tco_pci_tbl[] = {
>   	{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS, PCI_ANY_ID,
>   	  PCI_ANY_ID, },
> +	{ PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, PCI_ANY_ID,
> +	  PCI_ANY_ID, },
>   	{ 0, },			/* End of list */
>   };
>   MODULE_DEVICE_TABLE(pci, sp5100_tco_pci_tbl);
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web