Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1276343 > unrolled thread

Re: [PATCH 1/3] video: omapdss: delete unneeded of_node_put

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/3] video: omapdss: delete unneeded of_node_put Tomi Valkeinen <tomi.valkeinen@ti.com> - 2015-11-24 12:40 +0100

#1276343 — Re: [PATCH 1/3] video: omapdss: delete unneeded of_node_put

[Multipart message — attachments visible in raw view] — view raw

On 12/10/15 23:43, Julia Lawall wrote:
> Device node iterators perform an of_node_put on each iteration, so putting
> an of_node_put before a continue results in a double put.
> 
> A simplified version of the semantic match that finds this problem is as
> follows (http://coccinelle.lip6.fr):
> 
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> iterator i;
> @@
> 
>  i(..., child, ...) {
>    ... when != of_node_get(child)
> *  of_node_put(child);
>    ...
> *  continue;
> }
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
>  drivers/video/fbdev/omap2/dss/omapdss-boot-init.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Thanks, queued for 4.5.

 Tomi

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web