Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1277938 > unrolled thread

checkpatch: GIT_COMMIT_ID rule catches 'cherry picked from commit <sha1>' lines

Back to article view | Back to linux.kernel

Contents

  checkpatch: GIT_COMMIT_ID rule catches 'cherry picked from commit  <sha1>' lines Shawn N <shawnn@chromium.org> - 2015-11-26 03:20 +0100
    Re: checkpatch: GIT_COMMIT_ID rule catches 'cherry picked from  commit <sha1>' lines Joe Perches <joe@perches.com> - 2015-11-26 07:00 +0100

#1277938 — checkpatch: GIT_COMMIT_ID rule catches 'cherry picked from commit <sha1>' lines

Hello,

The checkpatch.pl GIT_COMMIT_ID rule appears to be designed to enforce
a minimum description when citing patches: 'commit <12+ chars of sha1>
(\"<title line>\")'. One (unintended?) consequence of this rule is
that unmodified 'cherry picked from commit <sha1>' (git cherry-pick
-x) lines are flagged.

- Is the disallowing of 'cherry picked from commit <sha1>' lines by
GIT_COMMIT_ID working as intended?
- If yes, would it be acceptable to instead add a new rule with
clearer error output ("Don't include git cherry-pick -x description
lines")?
- If no (and such lines are actually acceptable) then I will just
patch the GIT_COMMIT_ID rule.

Thanks,

Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1277984 — Re: checkpatch: GIT_COMMIT_ID rule catches 'cherry picked from commit <sha1>' lines

On Wed, 2015-11-25 at 18:15 -0800, Shawn N wrote:
> Hello,
> 
> The checkpatch.pl GIT_COMMIT_ID rule appears to be designed to enforce
> a minimum description when citing patches: 'commit <12+ chars of sha1>
> (\"\")'. One (unintended?) consequence of this rule is
> that unmodified 'cherry picked from commit ' (git cherry-pick
> -x) lines are flagged.
> 
> - Is the disallowing of 'cherry picked from commit ' lines by
> GIT_COMMIT_ID working as intended?
> - If yes, would it be acceptable to instead add a new rule with
> clearer error output ("Don't include git cherry-pick -x description
> lines")?
> - If no (and such lines are actually acceptable) then I will just
> patch the GIT_COMMIT_ID rule.
> 
> Thanks,
> 
> Shawn

I think sha1 commit ids should always be followed by a
git commit description.

If that's not the general consensus, it's pretty easy
to change.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web