Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1276938 > unrolled thread

[PATCH 3/3] ARM: qcom: Drop ARCH_MSM* configs

Started byStephen Boyd <sboyd@codeaurora.org>
First post2015-11-25 02:10 +0100
Last post2015-11-25 21:40 +0100
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 3/3] ARM: qcom: Drop ARCH_MSM* configs Stephen Boyd <sboyd@codeaurora.org> - 2015-11-25 02:10 +0100
    Re: [PATCH 3/3] ARM: qcom: Drop ARCH_MSM* configs Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-25 13:30 +0100
      Re: [PATCH 3/3] ARM: qcom: Drop ARCH_MSM* configs Arnd Bergmann <arnd@arndb.de> - 2015-11-25 14:00 +0100
        Re: [PATCH 3/3] ARM: qcom: Drop ARCH_MSM* configs Stephen Boyd <sboyd@codeaurora.org> - 2015-11-25 20:40 +0100
          Re: [PATCH 3/3] ARM: qcom: Drop ARCH_MSM* configs Arnd Bergmann <arnd@arndb.de> - 2015-11-25 21:40 +0100
            Re: [PATCH 3/3] ARM: qcom: Drop ARCH_MSM* configs Stephen Boyd <sboyd@codeaurora.org> - 2015-11-25 21:40 +0100

#1276938 — [PATCH 3/3] ARM: qcom: Drop ARCH_MSM* configs

FromStephen Boyd <sboyd@codeaurora.org>
Date2015-11-25 02:10 +0100
Subject[PATCH 3/3] ARM: qcom: Drop ARCH_MSM* configs
Message-ID<qywKS-7sm-1@gated-at.bofh.it>
Drop these configs now that we select the clocksources we need
via the defconfig.

Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 arch/arm/mach-qcom/Kconfig | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/arch/arm/mach-qcom/Kconfig b/arch/arm/mach-qcom/Kconfig
index 2256cd1e25d1..37572fd79c87 100644
--- a/arch/arm/mach-qcom/Kconfig
+++ b/arch/arm/mach-qcom/Kconfig
@@ -7,19 +7,3 @@ menuconfig ARCH_QCOM
 	select QCOM_SCM if SMP
 	help
 	  Support for Qualcomm's devicetree based systems.
-
-if ARCH_QCOM
-
-config ARCH_MSM8X60
-	bool "Enable support for MSM8X60"
-	select CLKSRC_QCOM
-
-config ARCH_MSM8960
-	bool "Enable support for MSM8960"
-	select CLKSRC_QCOM
-
-config ARCH_MSM8974
-	bool "Enable support for MSM8974"
-	select HAVE_ARM_ARCH_TIMER
-
-endif
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1277328

FromDaniel Lezcano <daniel.lezcano@linaro.org>
Date2015-11-25 13:30 +0100
Message-ID<qyHmV-6e1-5@gated-at.bofh.it>
In reply to#1276938
On 11/25/2015 02:08 AM, Stephen Boyd wrote:
> Drop these configs now that we select the clocksources we need
> via the defconfig.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>   arch/arm/mach-qcom/Kconfig | 16 ----------------
>   1 file changed, 16 deletions(-)
>
> diff --git a/arch/arm/mach-qcom/Kconfig b/arch/arm/mach-qcom/Kconfig
> index 2256cd1e25d1..37572fd79c87 100644
> --- a/arch/arm/mach-qcom/Kconfig
> +++ b/arch/arm/mach-qcom/Kconfig
> @@ -7,19 +7,3 @@ menuconfig ARCH_QCOM
>   	select QCOM_SCM if SMP
>   	help
>   	  Support for Qualcomm's devicetree based systems.
> -
> -if ARCH_QCOM
> -
> -config ARCH_MSM8X60
> -	bool "Enable support for MSM8X60"
> -	select CLKSRC_QCOM
> -
> -config ARCH_MSM8960
> -	bool "Enable support for MSM8960"
> -	select CLKSRC_QCOM
> -
> -config ARCH_MSM8974
> -	bool "Enable support for MSM8974"
> -	select HAVE_ARM_ARCH_TIMER
> -
> -endif
>

What about:

textofs-$(CONFIG_ARCH_MSM8X60) := 0x00208000
textofs-$(CONFIG_ARCH_MSM8960) := 0x00208000

in arch/arm/Makefile

and

CONFIG_ARCH_MSM8X60=y
CONFIG_ARCH_MSM8960=y
CONFIG_ARCH_MSM8974=y

in arch/arm/configs/qcom_defconfig and multi_v7_defconfig

?

(perhaps you already did the changes and I am not looking at the right 
branch).

-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1277362

FromArnd Bergmann <arnd@arndb.de>
Date2015-11-25 14:00 +0100
Message-ID<qyHPX-6p2-7@gated-at.bofh.it>
In reply to#1277328
On Wednesday 25 November 2015 13:27:55 Daniel Lezcano wrote:
> 
> What about:
> 
> textofs-$(CONFIG_ARCH_MSM8X60) := 0x00208000
> textofs-$(CONFIG_ARCH_MSM8960) := 0x00208000
> 
> in arch/arm/Makefile

Good point, we need to do something about these still.

> and
> 
> CONFIG_ARCH_MSM8X60=y
> CONFIG_ARCH_MSM8960=y
> CONFIG_ARCH_MSM8974=y
> 
> in arch/arm/configs/qcom_defconfig and multi_v7_defconfig
> 
> ?

These should be removed, but they are harmless.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1277743

FromStephen Boyd <sboyd@codeaurora.org>
Date2015-11-25 20:40 +0100
Message-ID<qyO56-266-53@gated-at.bofh.it>
In reply to#1277362
On 11/25, Arnd Bergmann wrote:
> On Wednesday 25 November 2015 13:27:55 Daniel Lezcano wrote:
> > 
> > What about:
> > 
> > textofs-$(CONFIG_ARCH_MSM8X60) := 0x00208000
> > textofs-$(CONFIG_ARCH_MSM8960) := 0x00208000
> > 
> > in arch/arm/Makefile
> 
> Good point, we need to do something about these still.
> 

Yeah good catch! My brain must be shutting down due to the
holiday coming up.

The nice thing is that CLKSRC_QCOM and this text offset stuff are
always used on the same SoCs, so we should be able to make one
config in mach-qcom/Kconfig that selects the qcom clksrc driver
and adjusts the text offset. So is the suggestion to move
CLKSRC_QCOM to mach-qcom/Kconfig, or to make a new config that
selects it?

> > and
> > 
> > CONFIG_ARCH_MSM8X60=y
> > CONFIG_ARCH_MSM8960=y
> > CONFIG_ARCH_MSM8974=y
> > 
> > in arch/arm/configs/qcom_defconfig and multi_v7_defconfig
> > 
> > ?
> 
> These should be removed, but they are harmless.

Yes I was planning to let those fall out of some defconfig update
patch later on.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1277785

FromArnd Bergmann <arnd@arndb.de>
Date2015-11-25 21:40 +0100
Message-ID<qyP18-2J1-19@gated-at.bofh.it>
In reply to#1277743
On Wednesday 25 November 2015 11:34:47 Stephen Boyd wrote:
> On 11/25, Arnd Bergmann wrote:
> > On Wednesday 25 November 2015 13:27:55 Daniel Lezcano wrote:
> > > 
> > > What about:
> > > 
> > > textofs-$(CONFIG_ARCH_MSM8X60) := 0x00208000
> > > textofs-$(CONFIG_ARCH_MSM8960) := 0x00208000
> > > 
> > > in arch/arm/Makefile
> > 
> > Good point, we need to do something about these still.
> > 
> 
> Yeah good catch! My brain must be shutting down due to the
> holiday coming up.
> 
> The nice thing is that CLKSRC_QCOM and this text offset stuff are
> always used on the same SoCs, so we should be able to make one
> config in mach-qcom/Kconfig that selects the qcom clksrc driver
> and adjusts the text offset. So is the suggestion to move
> CLKSRC_QCOM to mach-qcom/Kconfig, or to make a new config that
> selects it?

I was thinking of a new option that selects it, which I think is
more in line with what Daniel wants.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1277786

FromStephen Boyd <sboyd@codeaurora.org>
Date2015-11-25 21:40 +0100
Message-ID<qyP18-2J1-27@gated-at.bofh.it>
In reply to#1277785
On 11/25/15 12:30, Arnd Bergmann wrote:
> On Wednesday 25 November 2015 11:34:47 Stephen Boyd wrote:
>> On 11/25, Arnd Bergmann wrote:
>>> On Wednesday 25 November 2015 13:27:55 Daniel Lezcano wrote:
>>>> What about:
>>>>
>>>> textofs-$(CONFIG_ARCH_MSM8X60) := 0x00208000
>>>> textofs-$(CONFIG_ARCH_MSM8960) := 0x00208000
>>>>
>>>> in arch/arm/Makefile
>>> Good point, we need to do something about these still.
>>>
>> Yeah good catch! My brain must be shutting down due to the
>> holiday coming up.
>>
>> The nice thing is that CLKSRC_QCOM and this text offset stuff are
>> always used on the same SoCs, so we should be able to make one
>> config in mach-qcom/Kconfig that selects the qcom clksrc driver
>> and adjusts the text offset. So is the suggestion to move
>> CLKSRC_QCOM to mach-qcom/Kconfig, or to make a new config that
>> selects it?
> I was thinking of a new option that selects it, which I think is
> more in line with what Daniel wants.
>
>

Ok. Sounds good. Patch will follow soon after I boot test on all the
affected devices.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web