Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1277224 > unrolled thread
| Started by | William Dauchy <wdauchy@gmail.com> |
|---|---|
| First post | 2015-11-25 12:10 +0100 |
| Last post | 2015-11-25 18:10 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] block: kmemleak: Track the page allocations for struct request William Dauchy <wdauchy@gmail.com> - 2015-11-25 12:10 +0100
Re: [PATCH] block: kmemleak: Track the page allocations for struct request Jens Axboe <axboe@kernel.dk> - 2015-11-25 17:50 +0100
Re: [PATCH] block: kmemleak: Track the page allocations for struct request William Dauchy <wdauchy@gmail.com> - 2015-11-25 18:10 +0100
| From | William Dauchy <wdauchy@gmail.com> |
|---|---|
| Date | 2015-11-25 12:10 +0100 |
| Subject | Re: [PATCH] block: kmemleak: Track the page allocations for struct request |
| Message-ID | <qyG7y-5tK-65@gated-at.bofh.it> |
Hi Jens, On Mon, Sep 14, 2015 at 7:21 PM, Jens Axboe <axboe@kernel.dk> wrote: > On 09/14/2015 11:16 AM, Catalin Marinas wrote: >> >> The pages allocated for struct request contain pointers to other slab >> allocations (via ops->init_request). Since kmemleak does not track/scan >> page allocations, the slab objects will be reported as leaks (false >> positives). This patch adds kmemleak callbacks to allow tracking of such >> pages. >> >> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> >> Reported-by: Bart Van Assche <bart.vanassche@sandisk.com> >> Tested-by: Bart Van Assche<bart.vanassche@sandisk.com> >> Cc: Christoph Hellwig <hch@infradead.org> >> Cc: Jens Axboe <axboe@kernel.dk> >> --- >> >> Jens, >> >> I just realised that no-one has picked this patch up for -rc1. It was >> discussed here previously: >> >> >> http://lkml.kernel.org/r/20150803104309.GB4033@e104818-lin.cambridge.arm.com >> >> Since it touches the block layer, are you fine with merging it? > > > Yeah looks simple enough for me, not sure why it got missed. I'll add it for > 4.4-rc1, thanks. I saw the related kmemleaks reports on my v4.1.x kernel. Since it's actually fixing these wrong reports, do you think it could be a good candidate for -stable tree? Thanks, -- William -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jens Axboe <axboe@kernel.dk> |
|---|---|
| Date | 2015-11-25 17:50 +0100 |
| Subject | Re: [PATCH] block: kmemleak: Track the page allocations for struct request |
| Message-ID | <qyLqx-nr-5@gated-at.bofh.it> |
| In reply to | #1277224 |
On 11/25/2015 04:04 AM, William Dauchy wrote: > Hi Jens, > > On Mon, Sep 14, 2015 at 7:21 PM, Jens Axboe <axboe@kernel.dk> wrote: >> On 09/14/2015 11:16 AM, Catalin Marinas wrote: >>> >>> The pages allocated for struct request contain pointers to other slab >>> allocations (via ops->init_request). Since kmemleak does not track/scan >>> page allocations, the slab objects will be reported as leaks (false >>> positives). This patch adds kmemleak callbacks to allow tracking of such >>> pages. >>> >>> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> >>> Reported-by: Bart Van Assche <bart.vanassche@sandisk.com> >>> Tested-by: Bart Van Assche<bart.vanassche@sandisk.com> >>> Cc: Christoph Hellwig <hch@infradead.org> >>> Cc: Jens Axboe <axboe@kernel.dk> >>> --- >>> >>> Jens, >>> >>> I just realised that no-one has picked this patch up for -rc1. It was >>> discussed here previously: >>> >>> >>> http://lkml.kernel.org/r/20150803104309.GB4033@e104818-lin.cambridge.arm.com >>> >>> Since it touches the block layer, are you fine with merging it? >> >> >> Yeah looks simple enough for me, not sure why it got missed. I'll add it for >> 4.4-rc1, thanks. > > I saw the related kmemleaks reports on my v4.1.x kernel. Since it's > actually fixing these wrong reports, do you think it could be a good > candidate for -stable tree? I'd say it's borderline. It's fixing a tracking bug. Unless others feel strongly otherwise, I don't think it's stable material. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | William Dauchy <wdauchy@gmail.com> |
|---|---|
| Date | 2015-11-25 18:10 +0100 |
| Message-ID | <qyLJV-K2-33@gated-at.bofh.it> |
| In reply to | #1277601 |
On Wed, Nov 25, 2015 at 5:45 PM, Jens Axboe <axboe@kernel.dk> wrote: > I'd say it's borderline. It's fixing a tracking bug. Unless others feel > strongly otherwise, I don't think it's stable material. ok thanks for your feedback. -- William -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web