Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1277264 > unrolled thread

[PATCH v3 1/5] arcmsr: fixed getting wrong configuration data

Started byChing Huang <ching2048@areca.com.tw>
First post2015-11-25 12:40 +0100
Last post2015-11-25 13:10 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data Ching Huang <ching2048@areca.com.tw> - 2015-11-25 12:40 +0100
    Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data Johannes Thumshirn <jthumshirn@suse.de> - 2015-11-25 13:00 +0100
    Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data Hannes Reinecke <hare@suse.de> - 2015-11-25 13:10 +0100

#1277264 — [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data

FromChing Huang <ching2048@areca.com.tw>
Date2015-11-25 12:40 +0100
Subject[PATCH v3 1/5] arcmsr: fixed getting wrong configuration data
Message-ID<qyGAz-5Fi-35@gated-at.bofh.it>
From: Ching Huang <ching2048@areca.com.tw>

Fixed getting wrong configuration data of adapter type B and type D.

Signed-of-by: Ching Huang <ching2048@areca.com.tw>

---

diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
--- a/drivers/scsi/arcmsr/arcmsr_hba.c	2015-11-23 16:25:22.000000000 +0800
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c	2015-11-24 11:35:26.000000000 +0800
@@ -2694,15 +2694,15 @@ static bool arcmsr_hbaB_get_config(struc
 		acb->firm_model,
 		acb->firm_version);
 
-	acb->signature = readl(&reg->message_rwbuffer[1]);
+	acb->signature = readl(&reg->message_rwbuffer[0]);
 	/*firm_signature,1,00-03*/
-	acb->firm_request_len = readl(&reg->message_rwbuffer[2]);
+	acb->firm_request_len = readl(&reg->message_rwbuffer[1]);
 	/*firm_request_len,1,04-07*/
-	acb->firm_numbers_queue = readl(&reg->message_rwbuffer[3]);
+	acb->firm_numbers_queue = readl(&reg->message_rwbuffer[2]);
 	/*firm_numbers_queue,2,08-11*/
-	acb->firm_sdram_size = readl(&reg->message_rwbuffer[4]);
+	acb->firm_sdram_size = readl(&reg->message_rwbuffer[3]);
 	/*firm_sdram_size,3,12-15*/
-	acb->firm_hd_channels = readl(&reg->message_rwbuffer[5]);
+	acb->firm_hd_channels = readl(&reg->message_rwbuffer[4]);
 	/*firm_ide_channels,4,16-19*/
 	acb->firm_cfg_version = readl(&reg->message_rwbuffer[25]);  /*firm_cfg_version,25,100-103*/
 	/*firm_ide_channels,4,16-19*/
@@ -2880,15 +2880,15 @@ static bool arcmsr_hbaD_get_config(struc
 		iop_device_map++;
 		count--;
 	}
-	acb->signature = readl(&reg->msgcode_rwbuffer[1]);
+	acb->signature = readl(&reg->msgcode_rwbuffer[0]);
 	/*firm_signature,1,00-03*/
-	acb->firm_request_len = readl(&reg->msgcode_rwbuffer[2]);
+	acb->firm_request_len = readl(&reg->msgcode_rwbuffer[1]);
 	/*firm_request_len,1,04-07*/
-	acb->firm_numbers_queue = readl(&reg->msgcode_rwbuffer[3]);
+	acb->firm_numbers_queue = readl(&reg->msgcode_rwbuffer[2]);
 	/*firm_numbers_queue,2,08-11*/
-	acb->firm_sdram_size = readl(&reg->msgcode_rwbuffer[4]);
+	acb->firm_sdram_size = readl(&reg->msgcode_rwbuffer[3]);
 	/*firm_sdram_size,3,12-15*/
-	acb->firm_hd_channels = readl(&reg->msgcode_rwbuffer[5]);
+	acb->firm_hd_channels = readl(&reg->msgcode_rwbuffer[4]);
 	/*firm_hd_channels,4,16-19*/
 	acb->firm_cfg_version = readl(&reg->msgcode_rwbuffer[25]);
 	pr_notice("Areca RAID Controller%d: Model %s, F/W %s\n",


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1277277

FromJohannes Thumshirn <jthumshirn@suse.de>
Date2015-11-25 13:00 +0100
Message-ID<qyGTU-5MV-9@gated-at.bofh.it>
In reply to#1277264
On Wed, 2015-11-25 at 19:36 +0800, Ching Huang wrote:
> From: Ching Huang <ching2048@areca.com.tw>
> 
> Fixed getting wrong configuration data of adapter type B and type D.
> 
> Signed-of-by: Ching Huang <ching2048@areca.com.tw>
> 
> ---
> 
> diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c
> b/drivers/scsi/arcmsr/arcmsr_hba.c
> --- a/drivers/scsi/arcmsr/arcmsr_hba.c	2015-11-23 16:25:22.000000000
> +0800
> +++ b/drivers/scsi/arcmsr/arcmsr_hba.c	2015-11-24 11:35:26.000000000
> +0800
> @@ -2694,15 +2694,15 @@ static bool arcmsr_hbaB_get_config(struc
>  		acb->firm_model,
>  		acb->firm_version);
>  
> -	acb->signature = readl(&reg->message_rwbuffer[1]);
> +	acb->signature = readl(&reg->message_rwbuffer[0]);
>  	/*firm_signature,1,00-03*/
> -	acb->firm_request_len = readl(&reg->message_rwbuffer[2]);
> +	acb->firm_request_len = readl(&reg->message_rwbuffer[1]);
>  	/*firm_request_len,1,04-07*/
> -	acb->firm_numbers_queue = readl(&reg->message_rwbuffer[3]);
> +	acb->firm_numbers_queue = readl(&reg->message_rwbuffer[2]);
>  	/*firm_numbers_queue,2,08-11*/
> -	acb->firm_sdram_size = readl(&reg->message_rwbuffer[4]);
> +	acb->firm_sdram_size = readl(&reg->message_rwbuffer[3]);
>  	/*firm_sdram_size,3,12-15*/
> -	acb->firm_hd_channels = readl(&reg->message_rwbuffer[5]);
> +	acb->firm_hd_channels = readl(&reg->message_rwbuffer[4]);
>  	/*firm_ide_channels,4,16-19*/
>  	acb->firm_cfg_version = readl(&reg-
> >message_rwbuffer[25]);  /*firm_cfg_version,25,100-103*/
>  	/*firm_ide_channels,4,16-19*/
> @@ -2880,15 +2880,15 @@ static bool arcmsr_hbaD_get_config(struc
>  		iop_device_map++;
>  		count--;
>  	}
> -	acb->signature = readl(&reg->msgcode_rwbuffer[1]);
> +	acb->signature = readl(&reg->msgcode_rwbuffer[0]);
>  	/*firm_signature,1,00-03*/
> -	acb->firm_request_len = readl(&reg->msgcode_rwbuffer[2]);
> +	acb->firm_request_len = readl(&reg->msgcode_rwbuffer[1]);
>  	/*firm_request_len,1,04-07*/
> -	acb->firm_numbers_queue = readl(&reg->msgcode_rwbuffer[3]);
> +	acb->firm_numbers_queue = readl(&reg->msgcode_rwbuffer[2]);
>  	/*firm_numbers_queue,2,08-11*/
> -	acb->firm_sdram_size = readl(&reg->msgcode_rwbuffer[4]);
> +	acb->firm_sdram_size = readl(&reg->msgcode_rwbuffer[3]);
>  	/*firm_sdram_size,3,12-15*/
> -	acb->firm_hd_channels = readl(&reg->msgcode_rwbuffer[5]);
> +	acb->firm_hd_channels = readl(&reg->msgcode_rwbuffer[4]);
>  	/*firm_hd_channels,4,16-19*/
>  	acb->firm_cfg_version = readl(&reg->msgcode_rwbuffer[25]);
>  	pr_notice("Areca RAID Controller%d: Model %s, F/W %s\n",
> 
> 

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1277286

FromHannes Reinecke <hare@suse.de>
Date2015-11-25 13:10 +0100
Message-ID<qyH3z-67h-11@gated-at.bofh.it>
In reply to#1277264
On 11/25/2015 12:36 PM, Ching Huang wrote:
> From: Ching Huang <ching2048@areca.com.tw>
> 
> Fixed getting wrong configuration data of adapter type B and type D.
> 
> Signed-of-by: Ching Huang <ching2048@areca.com.tw>
> 
> ---
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web