Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1271829 > unrolled thread
| Started by | Bayi Cheng <bayi.cheng@mediatek.com> |
|---|---|
| First post | 2015-11-18 04:40 +0100 |
| Last post | 2015-11-26 03:50 +0100 |
| Articles | 7 — 5 participants |
Back to article view | Back to linux.kernel
[PATCH v8 0/2] Mediatek SPI-NOR flash driver Bayi Cheng <bayi.cheng@mediatek.com> - 2015-11-18 04:40 +0100
[PATCH v8 2/2] arm64: dts: mt8173: Add nor flash node Bayi Cheng <bayi.cheng@mediatek.com> - 2015-11-18 04:40 +0100
Re: [PATCH v8 2/2] arm64: dts: mt8173: Add nor flash node Yingjoe Chen <yingjoe.chen@mediatek.com> - 2015-11-25 12:00 +0100
Re: [PATCH v8 2/2] arm64: dts: mt8173: Add nor flash node Matthias Brugger <matthias.bgg@gmail.com> - 2015-11-25 13:40 +0100
Re: [PATCH v8 2/2] arm64: dts: mt8173: Add nor flash node Matthias Brugger <matthias.bgg@gmail.com> - 2015-11-25 12:00 +0100
Re: [PATCH v8 2/2] arm64: dts: mt8173: Add nor flash node Daniel Kurtz <djkurtz@chromium.org> - 2015-11-26 02:30 +0100
Re: [PATCH v8 2/2] arm64: dts: mt8173: Add nor flash node bayi cheng <bayi.cheng@mediatek.com> - 2015-11-26 03:50 +0100
| From | Bayi Cheng <bayi.cheng@mediatek.com> |
|---|---|
| Date | 2015-11-18 04:40 +0100 |
| Subject | [PATCH v8 0/2] Mediatek SPI-NOR flash driver |
| Message-ID | <qw1Lb-5Jr-5@gated-at.bofh.it> |
This series is based on v4.4-rc1 and l2-mtd.git [0] and erase_sector implementation patch [1] [0]: git://git.infradead.org/l2-mtd.git [1]: http://lists.infradead.org/pipermail/linux-mtd/2015-October//062959.html Change in v8: 1: rewrite the macro MTK_NOR_MAX_SHIFT from 6 to 7 2: add a new macro MTK_NOR_MAX_RX_TX_SHIFT for max len of TX&RX Change in v7: 1: change PRGDATA3 to PRGDATA4 for quad mode 2: drop PRGDATA3 for signal read mode 3: drop unnecessary partition parser data 4: convert mtd_device_parse_register to mtd_device_register 5: disable clocks on failure Change in v6: 1: delete mt8173_nor_do_rx 2: delete mt8173_nor_do_rx 3: add mt8173_nor_do_tx_rx for general usage 4: support nor flash with 6 IDs 5: delete mt8173_nor_erase_sector and use "nor->erase_opcode" 6: add mt8173_nor_set_addr to programming the address register 7: initialize the ppdata in mtk_nor_init Change in v5: 1: add "status = "disable"" to device tree 2: add document "flash" node 3: fix some statement error in Kconfig file 4: fix alphabetical order error in makefile 5: delete the parament "mtd_info *mtd" in mt8173_nor structure 6: delete SPINOR_OP_WREN repeated calls 7: add mt8173_nor_do_tx & mt8173_nor_do_rx for them full potential 8: use a subnode to represent the flash Change in v4: 1: delete the parament "write_enable" for mt8173_nor_write_reg 2: fix the build warning for calling mt8173_nor_write_single_byte Change in v3: 1: use switch() to replace some if-else statement 2: use shifts to replace endianness statement 3: delete some unused macros 4: use auto-increment mechanism for single write 5: write address added to 32bytes Change in v2: 1. Rebase to 4.3-rc1 2. propagate error code 3. delete mux clock and axi clock in dts file 4. descripts more exactly for binding file 5. change file names from mtk-nor.c to mtk_quadspi.c 6. delete some functions witch were used once time Bayi Cheng (2): mtd: mtk-nor: mtk serial flash controller driver arm64: dts: mt8173: Add nor flash node arch/arm64/boot/dts/mediatek/mt8173.dtsi | 18 +- drivers/mtd/spi-nor/Kconfig | 7 + drivers/mtd/spi-nor/Makefile | 1 + drivers/mtd/spi-nor/mtk-quadspi.c | 483 +++++++++++++++++++++++++++++++ 4 files changed, 508 insertions(+), 1 deletion(-) create mode 100644 drivers/mtd/spi-nor/mtk-quadspi.c -- 1.8.1.1.dirty -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Bayi Cheng <bayi.cheng@mediatek.com> |
|---|---|
| Date | 2015-11-18 04:40 +0100 |
| Subject | [PATCH v8 2/2] arm64: dts: mt8173: Add nor flash node |
| Message-ID | <qw1Lb-5Jr-11@gated-at.bofh.it> |
| In reply to | #1271829 |
Add Mediatek nor flash node
Signed-off-by: Bayi Cheng <bayi.cheng@mediatek.com>
Acked-by: Brian Norris <computersforpeace@gmail.com>
---
arch/arm64/boot/dts/mediatek/mt8173.dtsi | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index 4dd5f93..7988656 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
@@ -387,7 +387,23 @@
status = "disabled";
};
- i2c3: i2c@11010000 {
+ nor_flash: spi@1100d000 {
+ compatible = "mediatek,mt8173-nor";
+ reg = <0 0x1100d000 0 0xe0>;
+ clocks = <&pericfg CLK_PERI_SPI>,
+ <&topckgen CLK_TOP_SPINFI_IFR_SEL>;
+ clock-names = "spi", "sf";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+
+ flash@0 {
+ compatible = "jedec,spi-nor";
+ reg = <0>;
+ };
+ };
+
+ i2c3: i2c3@11010000 {
compatible = "mediatek,mt8173-i2c";
reg = <0 0x11010000 0 0x70>,
<0 0x11000280 0 0x80>;
--
1.8.1.1.dirty
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Yingjoe Chen <yingjoe.chen@mediatek.com> |
|---|---|
| Date | 2015-11-25 12:00 +0100 |
| Subject | Re: [PATCH v8 2/2] arm64: dts: mt8173: Add nor flash node |
| Message-ID | <qyFXP-5aJ-5@gated-at.bofh.it> |
| In reply to | #1271830 |
On Wed, 2015-11-25 at 11:50 +0100, Matthias Brugger wrote:
>
> On 18/11/15 04:30, Bayi Cheng wrote:
> > Add Mediatek nor flash node
> >
> > Signed-off-by: Bayi Cheng <bayi.cheng@mediatek.com>
> > Acked-by: Brian Norris <computersforpeace@gmail.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 18 +++++++++++++++++-
> > 1 file changed, 17 insertions(+), 1 deletion(-)
> >
>
> Applied to v4.5-next/dts
>
> Thanks.
> Matthias
>
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 4dd5f93..7988656 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -387,7 +387,23 @@
> > status = "disabled";
> > };
> >
> > - i2c3: i2c@11010000 {
> > + nor_flash: spi@1100d000 {
> > + compatible = "mediatek,mt8173-nor";
> > + reg = <0 0x1100d000 0 0xe0>;
> > + clocks = <&pericfg CLK_PERI_SPI>,
> > + <&topckgen CLK_TOP_SPINFI_IFR_SEL>;
> > + clock-names = "spi", "sf";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + status = "disabled";
> > +
> > + flash@0 {
> > + compatible = "jedec,spi-nor";
> > + reg = <0>;
> > + };
> > + };
> > +
> > + i2c3: i2c3@11010000 {
Hi Matthias,
Just notice this one. Please make sure this line should be
i2c3: i2c@11010000 {
instead of
i2c3: i2c3@11010000 {
Joe.C
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Matthias Brugger <matthias.bgg@gmail.com> |
|---|---|
| Date | 2015-11-25 13:40 +0100 |
| Subject | Re: [PATCH v8 2/2] arm64: dts: mt8173: Add nor flash node |
| Message-ID | <qyHwC-6ho-29@gated-at.bofh.it> |
| In reply to | #1277196 |
On 25/11/15 11:57, Yingjoe Chen wrote:
> On Wed, 2015-11-25 at 11:50 +0100, Matthias Brugger wrote:
>>
>> On 18/11/15 04:30, Bayi Cheng wrote:
>>> Add Mediatek nor flash node
>>>
>>> Signed-off-by: Bayi Cheng <bayi.cheng@mediatek.com>
>>> Acked-by: Brian Norris <computersforpeace@gmail.com>
>>> ---
>>> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 18 +++++++++++++++++-
>>> 1 file changed, 17 insertions(+), 1 deletion(-)
>>>
>>
>> Applied to v4.5-next/dts
>>
>> Thanks.
>> Matthias
>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> index 4dd5f93..7988656 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> @@ -387,7 +387,23 @@
>>> status = "disabled";
>>> };
>>>
>>> - i2c3: i2c@11010000 {
>>> + nor_flash: spi@1100d000 {
>>> + compatible = "mediatek,mt8173-nor";
>>> + reg = <0 0x1100d000 0 0xe0>;
>>> + clocks = <&pericfg CLK_PERI_SPI>,
>>> + <&topckgen CLK_TOP_SPINFI_IFR_SEL>;
>>> + clock-names = "spi", "sf";
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + status = "disabled";
>>> +
>>> + flash@0 {
>>> + compatible = "jedec,spi-nor";
>>> + reg = <0>;
>>> + };
>>> + };
>>> +
>>> + i2c3: i2c3@11010000 {
>
> Hi Matthias,
>
> Just notice this one. Please make sure this line should be
>
> i2c3: i2c@11010000 {
>
> instead of
>
> i2c3: i2c3@11010000 {
>
Fixed, thanks for catching this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Matthias Brugger <matthias.bgg@gmail.com> |
|---|---|
| Date | 2015-11-25 12:00 +0100 |
| Subject | Re: [PATCH v8 2/2] arm64: dts: mt8173: Add nor flash node |
| Message-ID | <qyFXP-5aJ-7@gated-at.bofh.it> |
| In reply to | #1271830 |
On 18/11/15 04:30, Bayi Cheng wrote:
> Add Mediatek nor flash node
>
> Signed-off-by: Bayi Cheng <bayi.cheng@mediatek.com>
> Acked-by: Brian Norris <computersforpeace@gmail.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
Applied to v4.5-next/dts
Thanks.
Matthias
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index 4dd5f93..7988656 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -387,7 +387,23 @@
> status = "disabled";
> };
>
> - i2c3: i2c@11010000 {
> + nor_flash: spi@1100d000 {
> + compatible = "mediatek,mt8173-nor";
> + reg = <0 0x1100d000 0 0xe0>;
> + clocks = <&pericfg CLK_PERI_SPI>,
> + <&topckgen CLK_TOP_SPINFI_IFR_SEL>;
> + clock-names = "spi", "sf";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> +
> + flash@0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + };
> + };
> +
> + i2c3: i2c3@11010000 {
> compatible = "mediatek,mt8173-i2c";
> reg = <0 0x11010000 0 0x70>,
> <0 0x11000280 0 0x80>;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Daniel Kurtz <djkurtz@chromium.org> |
|---|---|
| Date | 2015-11-26 02:30 +0100 |
| Subject | Re: [PATCH v8 2/2] arm64: dts: mt8173: Add nor flash node |
| Message-ID | <qyTxL-5Gc-1@gated-at.bofh.it> |
| In reply to | #1271830 |
Hi Bayi, Matthias,
Sorry for the late review, one comment below...
On Wed, Nov 18, 2015 at 11:30 AM, Bayi Cheng <bayi.cheng@mediatek.com> wrote:
> Add Mediatek nor flash node
>
> Signed-off-by: Bayi Cheng <bayi.cheng@mediatek.com>
> Acked-by: Brian Norris <computersforpeace@gmail.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index 4dd5f93..7988656 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -387,7 +387,23 @@
> status = "disabled";
> };
>
> - i2c3: i2c@11010000 {
> + nor_flash: spi@1100d000 {
> + compatible = "mediatek,mt8173-nor";
> + reg = <0 0x1100d000 0 0xe0>;
> + clocks = <&pericfg CLK_PERI_SPI>,
> + <&topckgen CLK_TOP_SPINFI_IFR_SEL>;
> + clock-names = "spi", "sf";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> +
> + flash@0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + };
I think this flash@0 node represents the flash device present on the
board and should therefore be moved to the board-specific .dts.
-Dan
> + };
> +
> + i2c3: i2c3@11010000 {
> compatible = "mediatek,mt8173-i2c";
> reg = <0 0x11010000 0 0x70>,
> <0 0x11000280 0 0x80>;
> --
> 1.8.1.1.dirty
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | bayi cheng <bayi.cheng@mediatek.com> |
|---|---|
| Date | 2015-11-26 03:50 +0100 |
| Subject | Re: [PATCH v8 2/2] arm64: dts: mt8173: Add nor flash node |
| Message-ID | <qyUNb-6uZ-1@gated-at.bofh.it> |
| In reply to | #1277926 |
On Thu, 2015-11-26 at 09:20 +0800, Daniel Kurtz wrote:
> Hi Bayi, Matthias,
>
> Sorry for the late review, one comment below...
>
> On Wed, Nov 18, 2015 at 11:30 AM, Bayi Cheng <bayi.cheng@mediatek.com> wrote:
> > Add Mediatek nor flash node
> >
> > Signed-off-by: Bayi Cheng <bayi.cheng@mediatek.com>
> > Acked-by: Brian Norris <computersforpeace@gmail.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 18 +++++++++++++++++-
> > 1 file changed, 17 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 4dd5f93..7988656 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -387,7 +387,23 @@
> > status = "disabled";
> > };
> >
> > - i2c3: i2c@11010000 {
> > + nor_flash: spi@1100d000 {
> > + compatible = "mediatek,mt8173-nor";
> > + reg = <0 0x1100d000 0 0xe0>;
> > + clocks = <&pericfg CLK_PERI_SPI>,
> > + <&topckgen CLK_TOP_SPINFI_IFR_SEL>;
> > + clock-names = "spi", "sf";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + status = "disabled";
> > +
> > + flash@0 {
> > + compatible = "jedec,spi-nor";
> > + reg = <0>;
> > + };
>
> I think this flash@0 node represents the flash device present on the
> board and should therefore be moved to the board-specific .dts.
>
> -Dan
>
Hi Daniel, Thanks for your comments, and I will fixed it in the next
patch.
> > + };
> > +
> > + i2c3: i2c3@11010000 {
> > compatible = "mediatek,mt8173-i2c";
> > reg = <0 0x11010000 0 0x70>,
> > <0 0x11000280 0 0x80>;
> > --
> > 1.8.1.1.dirty
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web