Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1276157 > unrolled thread

[PATCH] mm/compaction: improve comment

Back to article view | Back to linux.kernel

Contents

  [PATCH] mm/compaction: improve comment Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2015-11-24 09:30 +0100
    Re: [PATCH] mm/compaction: improve comment Vlastimil Babka <vbabka@suse.cz> - 2015-11-24 17:00 +0100
      Re: [PATCH] mm/compaction: improve comment Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2015-11-25 10:00 +0100

#1276157 — [PATCH] mm/compaction: improve comment

Make comment more accurate.

Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
---
 mm/compaction.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index de3e1e7..b3cf915 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1708,7 +1708,9 @@ static void compact_nodes(void)
 /* The written value is actually unused, all memory is compacted */
 int sysctl_compact_memory;
 
-/* This is the entry point for compacting all nodes via /proc/sys/vm */
+/* This is the entry point for compacting all nodes via
+ * /proc/sys/vm/compact_memory
+ */
 int sysctl_compaction_handler(struct ctl_table *table, int write,
 			void __user *buffer, size_t *length, loff_t *ppos)
 {
-- 
1.9.1



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1276592

On 11/24/2015 09:23 AM, Yaowei Bai wrote:
> Make comment more accurate.

Make changelog more descriptive? :)

> Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
> ---
>   mm/compaction.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index de3e1e7..b3cf915 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1708,7 +1708,9 @@ static void compact_nodes(void)
>   /* The written value is actually unused, all memory is compacted */
>   int sysctl_compact_memory;
>
> -/* This is the entry point for compacting all nodes via /proc/sys/vm */
> +/* This is the entry point for compacting all nodes via
> + * /proc/sys/vm/compact_memory
> + */

Strictly speaking, multi-line comments should have a leading empty line, 
e.g.:

/*
  * This is the entry point ...



>   int sysctl_compaction_handler(struct ctl_table *table, int write,
>   			void __user *buffer, size_t *length, loff_t *ppos)
>   {
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1277106

On Tue, Nov 24, 2015 at 04:52:17PM +0100, Vlastimil Babka wrote:
> On 11/24/2015 09:23 AM, Yaowei Bai wrote:
> >Make comment more accurate.
> 
> Make changelog more descriptive? :)

ok

> 
> >Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
> >---
> >  mm/compaction.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> >diff --git a/mm/compaction.c b/mm/compaction.c
> >index de3e1e7..b3cf915 100644
> >--- a/mm/compaction.c
> >+++ b/mm/compaction.c
> >@@ -1708,7 +1708,9 @@ static void compact_nodes(void)
> >  /* The written value is actually unused, all memory is compacted */
> >  int sysctl_compact_memory;
> >
> >-/* This is the entry point for compacting all nodes via /proc/sys/vm */
> >+/* This is the entry point for compacting all nodes via
> >+ * /proc/sys/vm/compact_memory
> >+ */
> 
> Strictly speaking, multi-line comments should have a leading empty
> line, e.g.:
> 
> /*
>  * This is the entry point ...

Got it, will send an updated one soon. Thanks.

> 
> 
> 
> >  int sysctl_compaction_handler(struct ctl_table *table, int write,
> >  			void __user *buffer, size_t *length, loff_t *ppos)
> >  {
> >
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web