Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1275283 > unrolled thread
| Started by | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| First post | 2015-11-23 13:40 +0100 |
| Last post | 2015-11-24 08:40 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] libertas: fix possible NULL dereference Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-11-23 13:40 +0100
Re: [PATCH] libertas: fix possible NULL dereference Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-24 00:50 +0100
Re: [PATCH] libertas: fix possible NULL dereference Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-11-24 08:40 +0100
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| Date | 2015-11-23 13:40 +0100 |
| Subject | [PATCH] libertas: fix possible NULL dereference |
| Message-ID | <qxYzw-1JL-23@gated-at.bofh.it> |
We were dereferencing cmd first and checking for NULL later. Lets first check for NULL. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- drivers/net/wireless/marvell/libertas/cfg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/libertas/cfg.c b/drivers/net/wireless/marvell/libertas/cfg.c index 8317afd..e38ad1d 100644 --- a/drivers/net/wireless/marvell/libertas/cfg.c +++ b/drivers/net/wireless/marvell/libertas/cfg.c @@ -1108,7 +1108,7 @@ static int lbs_associate(struct lbs_private *priv, size_t len, resp_ie_len; int status; int ret; - u8 *pos = &(cmd->iebuf[0]); + u8 *pos; u8 *tmp; lbs_deb_enter(LBS_DEB_CFG80211); @@ -1117,6 +1117,7 @@ static int lbs_associate(struct lbs_private *priv, ret = -ENOMEM; goto done; } + pos = &cmd->iebuf[0]; /* * cmd 50 00 -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2015-11-24 00:50 +0100 |
| Message-ID | <qy91T-dn-5@gated-at.bofh.it> |
| In reply to | #1275283 |
On Mon, Nov 23, 2015 at 2:32 PM, Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote: > We were dereferencing cmd first and checking for NULL later. Lets first > check for NULL. However the patch is valid due to reducing error prone part, the commit message seems wrong. There is no dereferencing, it is a simple pointer arithmetic. > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- > drivers/net/wireless/marvell/libertas/cfg.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/marvell/libertas/cfg.c b/drivers/net/wireless/marvell/libertas/cfg.c > index 8317afd..e38ad1d 100644 > --- a/drivers/net/wireless/marvell/libertas/cfg.c > +++ b/drivers/net/wireless/marvell/libertas/cfg.c > @@ -1108,7 +1108,7 @@ static int lbs_associate(struct lbs_private *priv, > size_t len, resp_ie_len; > int status; > int ret; > - u8 *pos = &(cmd->iebuf[0]); > + u8 *pos; > u8 *tmp; > > lbs_deb_enter(LBS_DEB_CFG80211); > @@ -1117,6 +1117,7 @@ static int lbs_associate(struct lbs_private *priv, > ret = -ENOMEM; > goto done; > } > + pos = &cmd->iebuf[0]; > > /* > * cmd 50 00 > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| Date | 2015-11-24 08:40 +0100 |
| Message-ID | <qygmK-558-17@gated-at.bofh.it> |
| In reply to | #1275969 |
On Tue, Nov 24, 2015 at 01:43:38AM +0200, Andy Shevchenko wrote: > On Mon, Nov 23, 2015 at 2:32 PM, Sudip Mukherjee > <sudipm.mukherjee@gmail.com> wrote: > > We were dereferencing cmd first and checking for NULL later. Lets first > > check for NULL. > > However the patch is valid due to reducing error prone part, the > commit message seems wrong. I will send v2 with modified commit message. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web