Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1275073 > unrolled thread

Re: Re: [PATCH 6/6] PM / devfreq: Set the min_freq and max_freq of devfreq device

Started byMyungJoo Ham <myungjoo.ham@samsung.com>
First post2015-11-23 08:30 +0100
Last post2015-11-23 10:00 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  Re: Re: [PATCH 6/6] PM / devfreq: Set the min_freq and max_freq of  devfreq device MyungJoo Ham <myungjoo.ham@samsung.com> - 2015-11-23 08:30 +0100
    Re: Re: [PATCH 6/6] PM / devfreq: Set the min_freq and max_freq of  devfreq device Chanwoo Choi <cwchoi00@gmail.com> - 2015-11-23 10:00 +0100

#1275073 — Re: Re: [PATCH 6/6] PM / devfreq: Set the min_freq and max_freq of devfreq device

FromMyungJoo Ham <myungjoo.ham@samsung.com>
Date2015-11-23 08:30 +0100
SubjectRe: Re: [PATCH 6/6] PM / devfreq: Set the min_freq and max_freq of devfreq device
Message-ID<qxTJw-76I-13@gated-at.bofh.it>
W10NCj4gPiANCj4gPiBUaGUgdmFsdWUgMCBpcyB1c2VkIGZvciBtaW4vbWF4X2ZyZXEgdG8gZGVj
bGFyZQ0KPiA+IHRoYXQgbWluL21heF9mcmVxIGlzIGRlYWN0aXZhdGVkLiBUaGVyZWZvcmUsIGl0
IGlzIG5vdA0KPiA+IHJlcXVpcmVkIHRvIGRvIHNvOyB0aGV5IGFyZSBub3QgaW50ZW5kZWQgdG8g
c2hvdyB0aGUgaGFyZHdhcmUNCj4gPiBjb25maWd1cmF0aW9uIGFzIHdlbGwuDQo+IA0KPiBUaGlz
IGNhc2UgY29uc2lkZXIgdGhlIGRldmZyZXEgZGV2aWNlIHVzaW5nIE9QUCBiZWNhdXNlIGRldmZy
ZXFfc2V0X2ZyZXFfdGFibGUoKQ0KPiBnZXQgdGhlIG51bWJlciBvZiBPUFAgZW50cnkgaW4gT1BQ
IGxpc3QgYmVmb3JlIHNldHRpbmcgdGhlIG1pbl9mcmVxL21heF9mcmVxLg0KPiBJZiB0aGUgZGV2
ZnJlcSBkZXZpY2UgZG9uJ3QgdXNlIHRoZSBPUFAgZW50cnksIGRldmZyZXFfc2V0X2ZyZXFfdGFi
bGUoKQ0KPiB3aWxsIHJldHVybiB3aXRob3V0IGFueSBvcGVyYXRpb24uDQo+IA0KPiBJTUhPLCB3
aGVuIGRldmZyZXEgZGV2aWNlIHVzZXMgdGhlIE9QUCB0YWJsZSBpbmNsdWRpbmcgdGhlIGZyZXF1
ZW5jeSwNCj4gbWluX2ZyZXEvbWF4X2ZyZXEgc2hvdWxkIHNob3cgdGhlIGNvcnJlY3QgdmFsdWUg
YXMgQ1BVRlJFUSBmcmFtZXdvcmsuDQo+IA0KDQpUaGUgc2lkZSBlZmZlY3Qgb2YgdGhpcyBwYXRj
aCBzaG93cyB1cCB3aGVuIG9wcF9kaXNhYmxlKCkgYW5kIG9wcF9lbmFibGUoKQ0KYXJlIHVzZWQu
DQoNCkZvciBleGFtcGxlLA0KMS4gZGV2LT5vcHBfZGlzYWJsZSgyR0h6KTsgLyogMkdIeiBpcyB0
aGUgZmFzdGVzdCBhbmQgMS42IGlzIHRoZSBzZWNvbmQgKi8NCjIuIGluaXQgZGV2ZnJlcSBvZiBk
ZXY7IC8qIHNldHRpbmcgbWF4X2ZyZXEgQCAxLjZHIGJ5IHRoaXMgcGF0Y2ggKi8NCjMuIGRldi0+
b3BwX2VuYWJsZSgyR0h6KTsNCjQuIDJHSHogaXMgc3RpbGwgbm90IGFjdGl2ZSBiZWNhdXNlIG1h
eF9mcmVxIGlzIG5vdyAxLjZHSHouDQoNCkNoZWVycywNCk15dW5nSm9vLg0KDQoNCg==


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1275140

FromChanwoo Choi <cwchoi00@gmail.com>
Date2015-11-23 10:00 +0100
Message-ID<qxV8D-7TP-33@gated-at.bofh.it>
In reply to#1275073
On Mon, Nov 23, 2015 at 4:21 PM, MyungJoo Ham <myungjoo.ham@samsung.com> wrote:
> []
>> >
>> > The value 0 is used for min/max_freq to declare
>> > that min/max_freq is deactivated. Therefore, it is not
>> > required to do so; they are not intended to show the hardware
>> > configuration as well.
>>
>> This case consider the devfreq device using OPP because devfreq_set_freq_table()
>> get the number of OPP entry in OPP list before setting the min_freq/max_freq.
>> If the devfreq device don't use the OPP entry, devfreq_set_freq_table()
>> will return without any operation.
>>
>> IMHO, when devfreq device uses the OPP table including the frequency,
>> min_freq/max_freq should show the correct value as CPUFREQ framework.
>>
>
> The side effect of this patch shows up when opp_disable() and opp_enable()
> are used.

Ah. You're right.
I was not considering the the case of using opp_disable() and opp_enable().
I'll consider it again including the usage case of opp_diable/opp_enable.

Regards,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web