Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1274461 > unrolled thread

[PATCH v2 1/3] Documentation: dt-bindings: add async_irq to msm_hsusb

Started byTim Bird <tim.bird@sonymobile.com>
First post2015-11-20 23:40 +0100
Last post2015-11-21 00:00 +0100
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 1/3] Documentation: dt-bindings: add async_irq to msm_hsusb Tim Bird <tim.bird@sonymobile.com> - 2015-11-20 23:40 +0100
    [PATCH v2 3/3] usb: chipidea: register driver as a peripheral with the phy Tim Bird <tim.bird@sonymobile.com> - 2015-11-20 23:40 +0100
    [PATCH v2 2/3] usb: phy: msm: fix connect/disconnect bug for dragonboard OTG port Tim Bird <tim.bird@sonymobile.com> - 2015-11-20 23:40 +0100
    Re: [PATCH v2 1/3] Documentation: dt-bindings: add async_irq to  msm_hsusb Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-11-20 23:50 +0100
    Re: [PATCH v2 1/3] Documentation: dt-bindings: add async_irq to msm_hsusb Arnd Bergmann <arnd@arndb.de> - 2015-11-20 23:50 +0100
      Re: [PATCH v2 1/3] Documentation: dt-bindings: add async_irq to  msm_hsusb Tim Bird <tim.bird@sonymobile.com> - 2015-11-21 00:00 +0100

#1274461 — [PATCH v2 1/3] Documentation: dt-bindings: add async_irq to msm_hsusb

FromTim Bird <tim.bird@sonymobile.com>
Date2015-11-20 23:40 +0100
Subject[PATCH v2 1/3] Documentation: dt-bindings: add async_irq to msm_hsusb
Message-ID<qx2vv-50g-1@gated-at.bofh.it>
Add optional async_irq to msm_hsusb binding doc.

Signed-off-by: Tim Bird <tim.bird@sonymobile.com>
Acked-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/usb/msm-hsusb.txt | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/msm-hsusb.txt b/Documentation/devicetree/bindings/usb/msm-hsusb.txt
index 8654a3e..7ba1dff 100644
--- a/Documentation/devicetree/bindings/usb/msm-hsusb.txt
+++ b/Documentation/devicetree/bindings/usb/msm-hsusb.txt
@@ -23,7 +23,12 @@ Required properties:
   "qcom,usb-otg-snps" for chipsets with Synopsys 28nm PHY
 
 - regs:         Offset and length of the register set in the memory map
-- interrupts:   interrupt-specifier for the OTG interrupt.
+- interrupts:   interrupt-specifier for the OTG interrupts
+
+- interrupt-names: Should contain the following:
+  "core_irq"    USB core interrupt
+  "async_irq"   Asynchronous interrupt to wake up from low power mode
+                (optional)
 
 - clocks:       A list of phandle + clock-specifier pairs for the
                 clocks listed in clock-names
@@ -89,7 +94,8 @@ Example HSUSB OTG controller device node:
     usb@f9a55000 {
         compatible = "qcom,usb-otg-snps";
         reg = <0xf9a55000 0x400>;
-        interrupts = <0 134 0>;
+        interrupts = <0 134 0>, <0 140 0>;
+        interrupt-names = "core_irq", "async_irq";
         dr_mode = "peripheral";
 
         clocks = <&gcc GCC_XO_CLK>, <&gcc GCC_USB_HS_SYSTEM_CLK>,
-- 
1.8.2.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1274462 — [PATCH v2 3/3] usb: chipidea: register driver as a peripheral with the phy

FromTim Bird <tim.bird@sonymobile.com>
Date2015-11-20 23:40 +0100
Subject[PATCH v2 3/3] usb: chipidea: register driver as a peripheral with the phy
Message-ID<qx2vv-50g-5@gated-at.bofh.it>
In reply to#1274461
Register the chipidea driver with the phy, so that the phy
driver can kick the gadget driver when it resumes from low power.
The phy-msm-usb (Qualcomm) driver requires this in order to
recover gadget operation after you disconnect the USB cable
and reconnect it.

Signed-off-by: Tim Bird <tim.bird@sonymobile.com>
---
 drivers/usb/chipidea/udc.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index 8223fe7..06234cd 100644
--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipidea/udc.c
@@ -1890,6 +1890,12 @@ static int udc_start(struct ci_hdrc *ci)
 
 	ci->gadget.ep0 = &ci->ep0in->ep;
 
+	if (ci->usb_phy) {
+		retval = otg_set_peripheral(ci->usb_phy->otg, &ci->gadget);
+		if (retval)
+			goto destroy_eps;
+	}
+
 	retval = usb_add_gadget_udc(dev, &ci->gadget);
 	if (retval)
 		goto destroy_eps;
-- 
1.8.2.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1274463 — [PATCH v2 2/3] usb: phy: msm: fix connect/disconnect bug for dragonboard OTG port

FromTim Bird <tim.bird@sonymobile.com>
Date2015-11-20 23:40 +0100
Subject[PATCH v2 2/3] usb: phy: msm: fix connect/disconnect bug for dragonboard OTG port
Message-ID<qx2vw-50g-7@gated-at.bofh.it>
In reply to#1274461
Add support for async_irq to wake up driver from low power mode.
Without this, the power management code never calls resume.
Remove a spurious interrupt enable in the driver resume function.

Signed-off-by: Tim Bird <tim.bird@sonymobile.com>
---
 drivers/usb/phy/phy-msm-usb.c | 17 ++++++++++++++++-
 include/linux/usb/msm_hsusb.h |  1 +
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
index e40a071..db6297c 100644
--- a/drivers/usb/phy/phy-msm-usb.c
+++ b/drivers/usb/phy/phy-msm-usb.c
@@ -648,7 +648,6 @@ skip_phy_resume:
 	if (motg->async_int) {
 		motg->async_int = 0;
 		pm_runtime_put(phy->dev);
-		enable_irq(motg->irq);
 	}
 
 	dev_info(phy->dev, "USB exited from low power mode\n");
@@ -1732,6 +1731,12 @@ static int msm_otg_probe(struct platform_device *pdev)
 		return motg->irq;
 	}
 
+	motg->async_irq = platform_get_irq_byname(pdev, "async_irq");
+	if (motg->async_irq < 0) {
+		dev_err(&pdev->dev, "platform_get_irq for async_irq failed\n");
+		motg->async_irq = 0;
+	}
+
 	regs[0].supply = "vddcx";
 	regs[1].supply = "v3p3";
 	regs[2].supply = "v1p8";
@@ -1781,6 +1786,16 @@ static int msm_otg_probe(struct platform_device *pdev)
 		goto disable_ldo;
 	}
 
+	if (motg->async_irq) {
+		ret = devm_request_irq(&pdev->dev, motg->async_irq,
+				      msm_otg_irq, IRQF_TRIGGER_RISING,
+				      "msm_otg", motg);
+		if (ret) {
+			dev_err(&pdev->dev, "request irq failed (ASYNC INT)\n");
+			goto disable_ldo;
+		}
+	}
+
 	phy->init = msm_phy_init;
 	phy->set_power = msm_otg_set_power;
 	phy->notify_disconnect = msm_phy_notify_disconnect;
diff --git a/include/linux/usb/msm_hsusb.h b/include/linux/usb/msm_hsusb.h
index 8c8f685..08c67a3 100644
--- a/include/linux/usb/msm_hsusb.h
+++ b/include/linux/usb/msm_hsusb.h
@@ -164,6 +164,7 @@ struct msm_otg {
 	struct usb_phy phy;
 	struct msm_otg_platform_data *pdata;
 	int irq;
+	int async_irq;
 	struct clk *clk;
 	struct clk *pclk;
 	struct clk *core_clk;
-- 
1.8.2.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1274467 — Re: [PATCH v2 1/3] Documentation: dt-bindings: add async_irq to msm_hsusb

FromSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date2015-11-20 23:50 +0100
SubjectRe: [PATCH v2 1/3] Documentation: dt-bindings: add async_irq to msm_hsusb
Message-ID<qx2Fb-53P-3@gated-at.bofh.it>
In reply to#1274461
Hello.

On 11/21/2015 01:37 AM, Tim Bird wrote:

> Add optional async_irq to msm_hsusb binding doc.
>
> Signed-off-by: Tim Bird <tim.bird@sonymobile.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
>   Documentation/devicetree/bindings/usb/msm-hsusb.txt | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/msm-hsusb.txt b/Documentation/devicetree/bindings/usb/msm-hsusb.txt
> index 8654a3e..7ba1dff 100644
> --- a/Documentation/devicetree/bindings/usb/msm-hsusb.txt
> +++ b/Documentation/devicetree/bindings/usb/msm-hsusb.txt
> @@ -23,7 +23,12 @@ Required properties:
>     "qcom,usb-otg-snps" for chipsets with Synopsys 28nm PHY
>
>   - regs:         Offset and length of the register set in the memory map
> -- interrupts:   interrupt-specifier for the OTG interrupt.
> +- interrupts:   interrupt-specifier for the OTG interrupts
> +
> +- interrupt-names: Should contain the following:
> +  "core_irq"    USB core interrupt
> +  "async_irq"   Asynchronous interrupt to wake up from low power mode

    I think the "_irq" part can be dropped...

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1274472

FromArnd Bergmann <arnd@arndb.de>
Date2015-11-20 23:50 +0100
Message-ID<qx2Fb-53P-19@gated-at.bofh.it>
In reply to#1274461
On Friday 20 November 2015 14:37:16 Tim Bird wrote:
> +- interrupt-names: Should contain the following:
> +  "core_irq"    USB core interrupt
> +  "async_irq"   Asynchronous interrupt to wake up from low power mode
> +                (optional)
>  
> 

Sorry for the bike-shedding but how about just naming them "core" and "async"?

The redundant "_irq" postfix seems a little redundant.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1274473 — Re: [PATCH v2 1/3] Documentation: dt-bindings: add async_irq to msm_hsusb

FromTim Bird <tim.bird@sonymobile.com>
Date2015-11-21 00:00 +0100
SubjectRe: [PATCH v2 1/3] Documentation: dt-bindings: add async_irq to msm_hsusb
Message-ID<qx2OR-571-3@gated-at.bofh.it>
In reply to#1274472

On 11/20/2015 02:44 PM, Arnd Bergmann wrote:
> On Friday 20 November 2015 14:37:16 Tim Bird wrote:
>> +- interrupt-names: Should contain the following:
>> +  "core_irq"    USB core interrupt
>> +  "async_irq"   Asynchronous interrupt to wake up from low power mode
>> +                (optional)
>>  
>>
> 
> Sorry for the bike-shedding but how about just naming them "core" and "async"?
> 
> The redundant "_irq" postfix seems a little redundant.
OK - look for v3 RSN(tm)  (Real Soon Now)
 -- Tim

P.S. This is a cynical ploy to get me to automate my patch release process, isn't it? :-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web