Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1272996 > unrolled thread
| Started by | Rasmus Villemoes <linux@rasmusvillemoes.dk> |
|---|---|
| First post | 2015-11-19 11:20 +0100 |
| Last post | 2015-11-23 10:40 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v1 6/7] test_hexdump: test all possible group sizes for overflow Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-11-19 11:20 +0100
Re: [PATCH v1 6/7] test_hexdump: test all possible group sizes for overflow Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-11-20 17:50 +0100
Re: [PATCH v1 6/7] test_hexdump: test all possible group sizes for overflow Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-11-23 10:40 +0100
| From | Rasmus Villemoes <linux@rasmusvillemoes.dk> |
|---|---|
| Date | 2015-11-19 11:20 +0100 |
| Subject | Re: [PATCH v1 6/7] test_hexdump: test all possible group sizes for overflow |
| Message-ID | <qwutQ-7Ys-11@gated-at.bofh.it> |
On Wed, Nov 11 2015, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Currently only one combination is tested for overflow, i.e. rowsize = 16,
> groupsize = 1, len = 1. Do various test to go all possible branches.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> lib/test_hexdump.c | 23 ++++++++++++++++++-----
> 1 file changed, 18 insertions(+), 5 deletions(-)
>
> diff --git a/lib/test_hexdump.c b/lib/test_hexdump.c
> index 9b95b67..fa2f4af 100644
> --- a/lib/test_hexdump.c
> +++ b/lib/test_hexdump.c
> @@ -126,12 +126,13 @@ static void __init test_hexdump_set(int rowsize, bool ascii)
> test_hexdump(len, rowsize, 1, ascii);
> }
>
> -static void __init test_hexdump_overflow(size_t buflen, bool ascii)
> +static void __init test_hexdump_overflow(size_t buflen, size_t len,
> + int rowsize, int groupsize,
> + bool ascii)
> {
> char test[TEST_HEXDUMP_BUF_SIZE];
> char buf[TEST_HEXDUMP_BUF_SIZE];
> - size_t len = 1;
> - int rs = 16, gs = 1;
> + int rs = rowsize, gs = groupsize;
> int ae, he, e, r;
> bool a;
>
> @@ -170,6 +171,18 @@ static void __init test_hexdump_overflow(size_t buflen, bool ascii)
> }
> }
>
> +static void __init test_hexdump_overflow_set(size_t buflen, bool ascii)
> +{
> + unsigned int i = 0;
> +
> + do {
> + int gs = 1 << i;
> + size_t len = get_random_int() % 16 + gs;
> +
> + test_hexdump_overflow(buflen, rounddown(len, gs), 16, gs, ascii);
> + } while (i++ < 3);
> +}
aren't you missing a
test_hexdump_overflow(buflen, rounddown(len, gs), 32, gs, ascii);
here to also exercise the rowsize==32 code?
> +
> static int __init test_hexdump_init(void)
> {
> unsigned int i;
> @@ -186,10 +199,10 @@ static int __init test_hexdump_init(void)
> test_hexdump_set(rowsize, true);
>
> for (i = 0; i <= TEST_HEXDUMP_BUF_SIZE; i++)
> - test_hexdump_overflow(i, false);
> + test_hexdump_overflow_set(i, false);
>
> for (i = 0; i <= TEST_HEXDUMP_BUF_SIZE; i++)
> - test_hexdump_overflow(i, true);
> + test_hexdump_overflow_set(i, true);
It seems neater to do one loop:
for (i = 0; i <= TEST_HEXDUMP_BUF_SIZE; i++) {
test_hexdump_overflow_set(i, false);
test_hexdump_overflow_set(i, true);
}
Rasmus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Date | 2015-11-20 17:50 +0100 |
| Subject | Re: [PATCH v1 6/7] test_hexdump: test all possible group sizes for overflow |
| Message-ID | <qwX2P-1hA-51@gated-at.bofh.it> |
| In reply to | #1272996 |
On Thu, 2015-11-19 at 11:14 +0100, Rasmus Villemoes wrote:
> On Wed, Nov 11 2015, Andy Shevchenko <andriy.shevchenko@linux.intel.c
> om> wrote:
>
> > Currently only one combination is tested for overflow, i.e. rowsize
> > = 16,
> > groupsize = 1, len = 1. Do various test to go all possible
> > branches.
[]
> > + do {
> > + int gs = 1 << i;
> > + size_t len = get_random_int() % 16 + gs;
> > +
> > + test_hexdump_overflow(buflen, rounddown(len, gs),
> > 16, gs, ascii);
> > + } while (i++ < 3);
> > +}
>
>
> aren't you missing a
>
> test_hexdump_overflow(buflen, rounddown(len, gs), 32, gs, ascii);
>
> here to also exercise the rowsize==32 code?
I could add that as well, though it seems minor since the idea is to go
for all branches, which 16 covers anyway.
> static int __init test_hexdump_init(void)
> > {
> > unsigned int i;
> > @@ -186,10 +199,10 @@ static int __init test_hexdump_init(void)
> > test_hexdump_set(rowsize, true);
> >
> > for (i = 0; i <= TEST_HEXDUMP_BUF_SIZE; i++)
> > - test_hexdump_overflow(i, false);
> > + test_hexdump_overflow_set(i, false);
> >
> > for (i = 0; i <= TEST_HEXDUMP_BUF_SIZE; i++)
> > - test_hexdump_overflow(i, true);
> > + test_hexdump_overflow_set(i, true);
>
> It seems neater to do one loop:
>
> for (i = 0; i <= TEST_HEXDUMP_BUF_SIZE; i++) {
> test_hexdump_overflow_set(i, false);
> test_hexdump_overflow_set(i, true);
> }
I would like to keep them separately, though I'm also okay to do it in
one loop.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Rasmus Villemoes <linux@rasmusvillemoes.dk> |
|---|---|
| Date | 2015-11-23 10:40 +0100 |
| Message-ID | <qxVLk-8n9-21@gated-at.bofh.it> |
| In reply to | #1274259 |
On Fri, Nov 20 2015, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Thu, 2015-11-19 at 11:14 +0100, Rasmus Villemoes wrote:
>>
>> aren't you missing a
>>
>> test_hexdump_overflow(buflen, rounddown(len, gs), 32, gs, ascii);
>>
>> here to also exercise the rowsize==32 code?
>
> I could add that as well, though it seems minor since the idea is to go
> for all branches, which 16 covers anyway.
Well, I didn't look into the implementation when I wrote that; it just
seemed like an obvious thing to check all allowed combinations of
rowsize, groupsize and ascii.
>> static int __init test_hexdump_init(void)
>> > {
>> > unsigned int i;
>> > @@ -186,10 +199,10 @@ static int __init test_hexdump_init(void)
>> > test_hexdump_set(rowsize, true);
>> >
>> > for (i = 0; i <= TEST_HEXDUMP_BUF_SIZE; i++)
>> > - test_hexdump_overflow(i, false);
>> > + test_hexdump_overflow_set(i, false);
>> >
>> > for (i = 0; i <= TEST_HEXDUMP_BUF_SIZE; i++)
>> > - test_hexdump_overflow(i, true);
>> > + test_hexdump_overflow_set(i, true);
>>
>> It seems neater to do one loop:
>>
>> for (i = 0; i <= TEST_HEXDUMP_BUF_SIZE; i++) {
>> test_hexdump_overflow_set(i, false);
>> test_hexdump_overflow_set(i, true);
>> }
>
> I would like to keep them separately, though I'm also okay to do it in
> one loop.
Your code, your call.
Rasmus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web